[v1] migration: Some enhancements and cleanups for 10.1

[PATCH 04/11] migration/bg-snapshot: Do not check for SKIP in iterator

Posted by Peter Xu 5 months, 3 weeks ago

It's not possible to happen in bg-snapshot case.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/migration.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index 4697732bef..7bd78dd524 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3890,9 +3890,8 @@ static void *bg_migration_thread(void *opaque)
 
     while (migration_is_active()) {
         MigIterateState iter_state = bg_migration_iteration_run(s);
-        if (iter_state == MIG_ITERATE_SKIP) {
-            continue;
-        } else if (iter_state == MIG_ITERATE_BREAK) {
+
+        if (iter_state == MIG_ITERATE_BREAK) {
             break;
         }
 
-- 
2.49.0

Re: [PATCH 04/11] migration/bg-snapshot: Do not check for SKIP in iterator

Posted by Juraj Marcin 5 months, 2 weeks ago

On 2025-05-27 17:58, Peter Xu wrote:
> It's not possible to happen in bg-snapshot case.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  migration/migration.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Juraj Marcin <jmarcin@redhat.com>