1. Patchew
  2. QEMU
  3. [PATCH 0/3] hw/ppc: Fix --without-default-devices build
  4. View patch

[PATCH 2/3] hw/ppc: PowerNV machines expose a I2C bus

Philippe Mathieu-Daudé posted 3 patches 5 months, 3 weeks ago
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Frédéric Barrat" <fbarrat@linux.ibm.com>
[PATCH 2/3] hw/ppc: PowerNV machines expose a I2C bus
Posted by Philippe Mathieu-Daudé 5 months, 3 weeks ago 
Since commit 263b81ee15a, PowerNV machines instanciate
a I2C controller, so expose a I2C bus. Express that in
Kconfig, otherwise we get a configure error when trying
to use '--without-default-devices':

  The following clauses were found for PCA9552
      config PCA9552 depends on I2C
      select PCA9552 if POWERNV

Fixes: 263b81ee15a ("ppc/pnv: Add an I2C controller model")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/ppc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index ced6bbc7404..0d017df83ee 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -29,6 +29,7 @@ config POWERNV
     depends on PPC64 && FDT
     imply PCI_DEVICES
     imply TEST_DEVICES
+    select I2C
     select ISA_IPMI_BT
     select IPMI_LOCAL
     select ISA_BUS
-- 
2.47.1
Re: [PATCH 2/3] hw/ppc: PowerNV machines expose a I2C bus
Posted by Cédric Le Goater 5 months, 3 weeks ago 
On 5/26/25 13:23, Philippe Mathieu-Daudé wrote:
> Since commit 263b81ee15a, PowerNV machines instanciate
> a I2C controller, so expose a I2C bus. Express that in
> Kconfig, otherwise we get a configure error when trying
> to use '--without-default-devices':
> 
>    The following clauses were found for PCA9552
>        config PCA9552 depends on I2C
>        select PCA9552 if POWERNV
> 
> Fixes: 263b81ee15a ("ppc/pnv: Add an I2C controller model")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/ppc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index ced6bbc7404..0d017df83ee 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -29,6 +29,7 @@ config POWERNV
>       depends on PPC64 && FDT
>       imply PCI_DEVICES
>       imply TEST_DEVICES
> +    select I2C
>       select ISA_IPMI_BT
>       select IPMI_LOCAL
>       select ISA_BUS



Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.
Re: [PATCH 2/3] hw/ppc: PowerNV machines expose a I2C bus
Posted by Thomas Huth 5 months, 3 weeks ago 
On 26/05/2025 13.23, Philippe Mathieu-Daudé wrote:
> Since commit 263b81ee15a, PowerNV machines instanciate
> a I2C controller, so expose a I2C bus. Express that in
> Kconfig, otherwise we get a configure error when trying
> to use '--without-default-devices':
> 
>    The following clauses were found for PCA9552
>        config PCA9552 depends on I2C
>        select PCA9552 if POWERNV
> 
> Fixes: 263b81ee15a ("ppc/pnv: Add an I2C controller model")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/ppc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index ced6bbc7404..0d017df83ee 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -29,6 +29,7 @@ config POWERNV
>       depends on PPC64 && FDT
>       imply PCI_DEVICES
>       imply TEST_DEVICES
> +    select I2C
>       select ISA_IPMI_BT
>       select IPMI_LOCAL
>       select ISA_BUS

Reviewed-by: Thomas Huth <thuth@redhat.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.