[PATCH v3 2/2] semihosting/uaccess: Compile once

Philippe Mathieu-Daudé posted 2 patches 5 months, 3 weeks ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>
[PATCH v3 2/2] semihosting/uaccess: Compile once
Posted by Philippe Mathieu-Daudé 5 months, 3 weeks ago
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 semihosting/meson.build | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/semihosting/meson.build b/semihosting/meson.build
index f3d38dda91d..b1ab2506c6e 100644
--- a/semihosting/meson.build
+++ b/semihosting/meson.build
@@ -3,15 +3,12 @@ specific_ss.add(when: 'CONFIG_SEMIHOSTING', if_true: files(
   'syscalls.c',
 ))
 
-specific_ss.add(when: ['CONFIG_SEMIHOSTING', 'CONFIG_SYSTEM_ONLY'], if_true: files(
-  'uaccess.c',
-))
-
 common_ss.add(when: 'CONFIG_SEMIHOSTING', if_false: files('stubs-all.c'))
 user_ss.add(when: 'CONFIG_SEMIHOSTING', if_true: files('user.c'))
 system_ss.add(when: 'CONFIG_SEMIHOSTING', if_true: files(
   'config.c',
   'console.c',
+  'uaccess.c',
 ), if_false: files(
   'stubs-system.c',
 ))
-- 
2.47.1


Re: [PATCH v3 2/2] semihosting/uaccess: Compile once
Posted by Richard Henderson 5 months, 3 weeks ago
On 5/26/25 10:52, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   semihosting/meson.build | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/semihosting/meson.build b/semihosting/meson.build
> index f3d38dda91d..b1ab2506c6e 100644
> --- a/semihosting/meson.build
> +++ b/semihosting/meson.build
> @@ -3,15 +3,12 @@ specific_ss.add(when: 'CONFIG_SEMIHOSTING', if_true: files(
>     'syscalls.c',
>   ))
>   
> -specific_ss.add(when: ['CONFIG_SEMIHOSTING', 'CONFIG_SYSTEM_ONLY'], if_true: files(
> -  'uaccess.c',
> -))
> -
>   common_ss.add(when: 'CONFIG_SEMIHOSTING', if_false: files('stubs-all.c'))
>   user_ss.add(when: 'CONFIG_SEMIHOSTING', if_true: files('user.c'))
>   system_ss.add(when: 'CONFIG_SEMIHOSTING', if_true: files(
>     'config.c',
>     'console.c',
> +  'uaccess.c',
>   ), if_false: files(
>     'stubs-system.c',
>   ))

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~