tests/functional/test_mips_malta: Re-enable the check for the PCI host bridge

[PATCH] tests/functional/test_mips_malta: Re-enable the check for the PCI host bridge

Posted by Thomas Huth 5 months, 3 weeks ago

From: Thomas Huth <thuth@redhat.com>

The problem with the PCI bridge has been fixed in commit e5894fd6f411c1
("hw/pci-host/gt64120: Fix endianness handling"), so we can enable the
corresponding test again.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/test_mips_malta.py | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/functional/test_mips_malta.py b/tests/functional/test_mips_malta.py
index 89b9556f30d..30279f0ff21 100755
--- a/tests/functional/test_mips_malta.py
+++ b/tests/functional/test_mips_malta.py
@@ -80,10 +80,8 @@ def mips_check_wheezy(test, kernel_path, image_path, kernel_command_line,
     exec_command_and_wait_for_pattern(test, 'cat /proc/devices', 'usb')
     exec_command_and_wait_for_pattern(test, 'cat /proc/ioports',
                                       ' : piix4_smbus')
-    # lspci for the host bridge does not work on big endian targets:
-    # https://gitlab.com/qemu-project/qemu/-/issues/2826
-    # exec_command_and_wait_for_pattern(test, 'lspci -d 11ab:4620',
-    #                                   'GT-64120')
+    exec_command_and_wait_for_pattern(test, 'lspci -d 11ab:4620',
+                                      'GT-64120')
     exec_command_and_wait_for_pattern(test,
                                       'cat /sys/bus/i2c/devices/i2c-0/name',
                                       'SMBus PIIX4 adapter')
-- 
2.49.0

Re: [PATCH] tests/functional/test_mips_malta: Re-enable the check for the PCI host bridge

Posted by Philippe Mathieu-Daudé 5 months, 3 weeks ago

On 22/5/25 10:02, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> The problem with the PCI bridge has been fixed in commit e5894fd6f411c1
> ("hw/pci-host/gt64120: Fix endianness handling"), so we can enable the
> corresponding test again.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/functional/test_mips_malta.py | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/functional/test_mips_malta.py b/tests/functional/test_mips_malta.py
> index 89b9556f30d..30279f0ff21 100755
> --- a/tests/functional/test_mips_malta.py
> +++ b/tests/functional/test_mips_malta.py
> @@ -80,10 +80,8 @@ def mips_check_wheezy(test, kernel_path, image_path, kernel_command_line,
>       exec_command_and_wait_for_pattern(test, 'cat /proc/devices', 'usb')
>       exec_command_and_wait_for_pattern(test, 'cat /proc/ioports',
>                                         ' : piix4_smbus')
> -    # lspci for the host bridge does not work on big endian targets:
> -    # https://gitlab.com/qemu-project/qemu/-/issues/2826
> -    # exec_command_and_wait_for_pattern(test, 'lspci -d 11ab:4620',
> -    #                                   'GT-64120')
> +    exec_command_and_wait_for_pattern(test, 'lspci -d 11ab:4620',
> +                                      'GT-64120')
>       exec_command_and_wait_for_pattern(test,
>                                         'cat /sys/bus/i2c/devices/i2c-0/name',
>                                         'SMBus PIIX4 adapter')

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] tests/functional/test_mips_malta: Re-enable the check for the PCI host bridge

Posted by Alex Bennée 5 months, 3 weeks ago

Thomas Huth <thuth@redhat.com> writes:

> From: Thomas Huth <thuth@redhat.com>
>
> The problem with the PCI bridge has been fixed in commit e5894fd6f411c1
> ("hw/pci-host/gt64120: Fix endianness handling"), so we can enable the
> corresponding test again.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro