tests/functional/test_sparc64_tuxrun: Explicitly set the 'sun4u' machine

[PATCH] tests/functional/test_sparc64_tuxrun: Explicitly set the 'sun4u' machine

Thomas Huth posted 1 patch 5 months, 4 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250521145112.142222-1-thuth@redhat.com

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

tests/functional/test_sparc64_tuxrun.py | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] tests/functional/test_sparc64_tuxrun: Explicitly set the 'sun4u' machine

Posted by Thomas Huth 5 months, 4 weeks ago

From: Thomas Huth <thuth@redhat.com>

Use self.set_machine() to set the machine instead of relying on the
default machine of the binary. This way the test can be skipped in
case the machine has not been compiled into the QEMU binary.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/test_sparc64_tuxrun.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/functional/test_sparc64_tuxrun.py b/tests/functional/test_sparc64_tuxrun.py
index 3be08d6102b..0d7b43dd74c 100755
--- a/tests/functional/test_sparc64_tuxrun.py
+++ b/tests/functional/test_sparc64_tuxrun.py
@@ -24,6 +24,7 @@ class TuxRunSparc64Test(TuxRunBaselineTest):
         '479c3dc104c82b68be55e2c0c5c38cd473d0b37ad4badccde4775bb88ce34611')
 
     def test_sparc64(self):
+        self.set_machine('sun4u')
         self.root='sda'
         self.wait_for_shutdown=False
         self.common_tuxrun(kernel_asset=self.ASSET_SPARC64_KERNEL,
-- 
2.49.0

Re: [PATCH] tests/functional/test_sparc64_tuxrun: Explicitly set the 'sun4u' machine

Posted by Alex Bennée 5 months, 4 weeks ago

Thomas Huth <thuth@redhat.com> writes:

> From: Thomas Huth <thuth@redhat.com>
>
> Use self.set_machine() to set the machine instead of relying on the
> default machine of the binary. This way the test can be skipped in
> case the machine has not been compiled into the QEMU binary.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro