[v2] tcg/perf: Placate clang-21's -Wdefault-const-init-field-unsafe

[PATCH v2] tcg/perf: Placate clang-21's -Wdefault-const-init-field-unsafe

Ilya Leoshkevich posted 1 patch 5 months, 4 weeks ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250520084225.90079-1-iii@linux.ibm.com

Maintainers: Richard Henderson <richard.henderson@linaro.org>

tcg/perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH v2] tcg/perf: Placate clang-21's -Wdefault-const-init-field-unsafe

Posted by Ilya Leoshkevich 5 months, 4 weeks ago

The not-yet-released clang-21 complains about the const "name" field in
struct debug_entry. While this warning may be too aggressive, there is
not too much value in having const there, so just drop it.

Note: in addition to this fix, I had to turn off the following clang-21
warnings to make the build work:

* -Wno-parentheses-equality
* -Wno-unused-value
* -Wno-tautological-unsigned-enum-zero-compare
* -Wno-tautological-compare

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Closes: https://gitlab.com/qemu-project/qemu/-/issues/2970
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---

v1: https://lore.kernel.org/qemu-devel/20250519214903.55284-1-iii@linux.ibm.com/
v1 -> v2: Mention in the commit message that clang-21 is not released
          yet. Add Peter's R-b.

 tcg/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tcg/perf.c b/tcg/perf.c
index 4e8d2c1bee7..f30c5b489d1 100644
--- a/tcg/perf.c
+++ b/tcg/perf.c
@@ -154,7 +154,7 @@ struct debug_entry {
     uint64_t addr;
     int lineno;
     int discrim;
-    const char name[];
+    char name[];
 };
 
 struct jr_code_debug_info {
-- 
2.49.0