[PATCH 2/8] python: update pylint ignores

John Snow posted 8 patches 6 months ago
Maintainers: John Snow <jsnow@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Cleber Rosa <crosa@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Maksim Davydov <davydov-max@yandex-team.ru>, Manos Pitsidianakis <manos.pitsidianakis@linaro.org>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Ani Sinha <anisinha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
There is a newer version of this series
[PATCH 2/8] python: update pylint ignores
Posted by John Snow 6 months ago
The next patch will synchronize the qemu.qmp library with the external,
standalone version. That synchronization will require a few extra
ignores for pylint, so do that now.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/setup.cfg | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/python/setup.cfg b/python/setup.cfg
index d7f5dc7bafe..02cc076eaea 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -140,11 +140,12 @@ ignore_missing_imports = True
 # --disable=W".
 disable=consider-using-f-string,
         consider-using-with,
+        no-member,  # mypy also handles this better.
         too-many-arguments,
-        too-many-positional-arguments,
         too-many-function-args,  # mypy handles this with less false positives.
         too-many-instance-attributes,
-        no-member,  # mypy also handles this better.
+        too-many-positional-arguments,
+        unknown-option-value,
 
 [pylint.basic]
 # Good variable names which should always be accepted, separated by a comma.
-- 
2.48.1
Re: [PATCH 2/8] python: update pylint ignores
Posted by Markus Armbruster 5 months, 4 weeks ago
John Snow <jsnow@redhat.com> writes:

> The next patch will synchronize the qemu.qmp library with the external,
> standalone version. That synchronization will require a few extra
> ignores for pylint, so do that now.

Just one, unless I'm cross-eyed again.

> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/setup.cfg | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/python/setup.cfg b/python/setup.cfg
> index d7f5dc7bafe..02cc076eaea 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -140,11 +140,12 @@ ignore_missing_imports = True
>  # --disable=W".
>  disable=consider-using-f-string,
>          consider-using-with,
> +        no-member,  # mypy also handles this better.
>          too-many-arguments,
> -        too-many-positional-arguments,
>          too-many-function-args,  # mypy handles this with less false positives.
>          too-many-instance-attributes,
> -        no-member,  # mypy also handles this better.
> +        too-many-positional-arguments,

Up to here, just a reorder, which I appreciate.

> +        unknown-option-value,

This is the new one.

>  
>  [pylint.basic]
>  # Good variable names which should always be accepted, separated by a comma.
Re: [PATCH 2/8] python: update pylint ignores
Posted by John Snow 5 months, 3 weeks ago
On Tue, May 20, 2025 at 3:42 AM Markus Armbruster <armbru@redhat.com> wrote:

> John Snow <jsnow@redhat.com> writes:
>
> > The next patch will synchronize the qemu.qmp library with the external,
> > standalone version. That synchronization will require a few extra
> > ignores for pylint, so do that now.
>
> Just one, unless I'm cross-eyed again.
>

Nope. changed the commit message. Just doing things in weird orders as is
my usual...


>
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >  python/setup.cfg | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/python/setup.cfg b/python/setup.cfg
> > index d7f5dc7bafe..02cc076eaea 100644
> > --- a/python/setup.cfg
> > +++ b/python/setup.cfg
> > @@ -140,11 +140,12 @@ ignore_missing_imports = True
> >  # --disable=W".
> >  disable=consider-using-f-string,
> >          consider-using-with,
> > +        no-member,  # mypy also handles this better.
> >          too-many-arguments,
> > -        too-many-positional-arguments,
> >          too-many-function-args,  # mypy handles this with less false
> positives.
> >          too-many-instance-attributes,
> > -        no-member,  # mypy also handles this better.
> > +        too-many-positional-arguments,
>
> Up to here, just a reorder, which I appreciate.
>
> > +        unknown-option-value,
>
> This is the new one.
>
> >
> >  [pylint.basic]
> >  # Good variable names which should always be accepted, separated by a
> comma.
>
>