[v2] migration: Some fix and enhancements to HMP "info migrate"

[PATCH v2 0/2] migration: Some fix and enhancements to HMP "info migrate"

Posted by Peter Xu 7 months ago

v2:
- Dropped patch 2, dump globals only if "-a" in the last patch [Dave]
- Keep using "Throughput" for dumping ->mbps [Juraj]
- Rearranged some more, e.g. put xbzrle/globals under -a too, added indents
  for the global dump, etc.

Patch 1 was a bug I found set capabilities, so it's pretty separate issue.

Patch 2 was an attempt that I made the HMP "info migrate" looks slightly
easier to read.  A new option "-a" is added to request a full dump,
otherwise only the important info will be dumped.

Comments welcomed, thanks.

Peter Xu (2):
  migration: Allow caps to be set when preempt or multifd cap enabled
  migration/hmp: Add "info migrate -a", reorg the dump

 migration/migration-hmp-cmds.c | 186 +++++++++++++++++----------------
 migration/options.c            |   4 +-
 hmp-commands-info.hx           |   6 +-
 3 files changed, 101 insertions(+), 95 deletions(-)

-- 
2.49.0

Re: [PATCH v2 0/2] migration: Some fix and enhancements to HMP "info migrate"

Posted by Mario Casquero 7 months ago

This series has been successfully tested. Now the HMP info migrate
command is more compact and readable. With the -a option the values of
the globals are displayed as well.

(qemu) info migrate
Status: active
Time (ms): total=4029, setup=36, exp_down=300
RAM info:
  Throughput (mbps): 938.03
  Sizes (KB): psize=4, total=16798280
    transferred=426629, remain=6121884,
    precopy=426752, multifd=0, postcopy=0
  Pages: normal=105457, zero=466489, rate_per_sec=28728
  Others: dirty_syncs=1

Tested-by: Mario Casquero <mcasquer@redhat.com>


On Wed, May 14, 2025 at 10:03 PM Peter Xu <peterx@redhat.com> wrote:
>
> v2:
> - Dropped patch 2, dump globals only if "-a" in the last patch [Dave]
> - Keep using "Throughput" for dumping ->mbps [Juraj]
> - Rearranged some more, e.g. put xbzrle/globals under -a too, added indents
>   for the global dump, etc.
>
> Patch 1 was a bug I found set capabilities, so it's pretty separate issue.
>
> Patch 2 was an attempt that I made the HMP "info migrate" looks slightly
> easier to read.  A new option "-a" is added to request a full dump,
> otherwise only the important info will be dumped.
>
> Comments welcomed, thanks.
>
> Peter Xu (2):
>   migration: Allow caps to be set when preempt or multifd cap enabled
>   migration/hmp: Add "info migrate -a", reorg the dump
>
>  migration/migration-hmp-cmds.c | 186 +++++++++++++++++----------------
>  migration/options.c            |   4 +-
>  hmp-commands-info.hx           |   6 +-
>  3 files changed, 101 insertions(+), 95 deletions(-)
>
> --
> 2.49.0
>
>

Re: [PATCH v2 0/2] migration: Some fix and enhancements to HMP "info migrate"

Posted by Peter Xu 6 months, 4 weeks ago

On Mon, May 19, 2025 at 01:27:35PM +0200, Mario Casquero wrote:
> This series has been successfully tested. Now the HMP info migrate
> command is more compact and readable. With the -a option the values of
> the globals are displayed as well.
> 
> (qemu) info migrate
> Status: active
> Time (ms): total=4029, setup=36, exp_down=300
> RAM info:
>   Throughput (mbps): 938.03
>   Sizes (KB): psize=4, total=16798280

I just noticed there's the comma missing at the end of this line.. I'll add
it.

>     transferred=426629, remain=6121884,
>     precopy=426752, multifd=0, postcopy=0
>   Pages: normal=105457, zero=466489, rate_per_sec=28728
>   Others: dirty_syncs=1
> 
> Tested-by: Mario Casquero <mcasquer@redhat.com>

Thanks Mario.  I'll queue this series with the touch up.

-- 
Peter Xu