This fixes some edge cases in endian handling in the VNC server. These
bugs are rarely going to be visible by default, since most servers will
negotiate encoding formats / framebuffer formats that avoid hitting
the problem scenarios.

In v2:

 - Rename 'client_bo' to 'client_endian' for reviewer clarity
 - Rename 'native' to 'native_endian' for code consistency

Daniel P. Berrangé (3):
  ui/vnc.c: replace big endian flag with byte order value
  ui/vnc: take account of client byte order in pixman format
  ui/vnc: fix tight palette pixel encoding for 8/16-bpp formats

 include/ui/qemu-pixman.h |  4 ++--
 ui/qemu-pixman.c         | 15 ++++++++-------
 ui/vnc-enc-tight.c       | 16 ++++++++++------
 ui/vnc-enc-zrle.c        |  2 +-
 ui/vnc-jobs.c            |  2 +-
 ui/vnc.c                 |  9 +++++----
 ui/vnc.h                 |  2 +-
 7 files changed, 28 insertions(+), 22 deletions(-)

-- 
2.49.0

On 14.05.2025 14:19, Daniel P. Berrangé wrote:
> This fixes some edge cases in endian handling in the VNC server. These
> bugs are rarely going to be visible by default, since most servers will
> negotiate encoding formats / framebuffer formats that avoid hitting
> the problem scenarios.
> 
> In v2:
> 
>   - Rename 'client_bo' to 'client_endian' for reviewer clarity
>   - Rename 'native' to 'native_endian' for code consistency
> 
> Daniel P. Berrangé (3):
>    ui/vnc.c: replace big endian flag with byte order value
>    ui/vnc: take account of client byte order in pixman format
>    ui/vnc: fix tight palette pixel encoding for 8/16-bpp formats

Hi!

Is there anything in there which is relevant for qemu-stable?

Thanks,

/mjt

On Sat, May 24, 2025 at 01:32:45PM +0300, Michael Tokarev wrote:
> On 14.05.2025 14:19, Daniel P. Berrangé wrote:
> > This fixes some edge cases in endian handling in the VNC server. These
> > bugs are rarely going to be visible by default, since most servers will
> > negotiate encoding formats / framebuffer formats that avoid hitting
> > the problem scenarios.
> > 
> > In v2:
> > 
> >   - Rename 'client_bo' to 'client_endian' for reviewer clarity
> >   - Rename 'native' to 'native_endian' for code consistency
> > 
> > Daniel P. Berrangé (3):
> >    ui/vnc.c: replace big endian flag with byte order value
> >    ui/vnc: take account of client byte order in pixman format
> >    ui/vnc: fix tight palette pixel encoding for 8/16-bpp formats
> 
> Hi!
> 
> Is there anything in there which is relevant for qemu-stable?

I've not seen anyone raise these issues, since basically every serious
VNC client supports 'tight' encoding and it is very rare to run anything
other than true colour mode these days.

None the less these are clear bug fixes, so valid to pull all three
patches into stable if desired.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|