qom: Consolidate OBJECT_{DEFINE|DECLARE}_SIMPLE_TYPE*

[PATCH 0/9] qom: Consolidate OBJECT_{DEFINE|DECLARE}_SIMPLE_TYPE*

Zhao Liu posted 9 patches 6 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250514084957.2221975-1-zhao1.liu@intel.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Magnus Damm <magnus.damm@gmail.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>, Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Peter Maydell <peter.maydell@linaro.org>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Thomas Huth <thuth@redhat.com>

docs/devel/qom.rst               | 11 +----------
hw/acpi/pci.c                    | 24 ++++++++----------------
hw/char/sh_serial.c              |  4 +---
hw/hyperv/hv-balloon.c           |  8 ++------
hw/ppc/pef.c                     | 17 ++++++-----------
include/hw/core/resetcontainer.h |  2 +-
include/qom/object.h             |  5 +++--
target/s390x/kvm/pv.c            | 18 ++++++------------
ui/console-vc.c                  | 14 ++++++++------
9 files changed, 36 insertions(+), 67 deletions(-)

Expand all Fold all

[PATCH 0/9] qom: Consolidate OBJECT_{DEFINE|DECLARE}_SIMPLE_TYPE*

Posted by Zhao Liu 6 months ago

Hi,

When I read the qom doc (qom.rst) about OBJECT_DECLARE_SIMPLE_TYPE, I
found there's the wrong example. So I tried to fix the doc and cleaned
up the relevant code case to correctly show that for simple type, the
class definition is not needed.

This series tries to:

 * fix & improve the documentation of OBJECT_{DEFINE|DECLARE}_SIMPLE_TYPE*,

 * and clean up several cases that could have used simple type macros
   (mainly by dropping unneeded class definitions).

Thanks and Best Regards,
Zhao
---
Zhao Liu (9):
  qom/object: Improve the doc of macros related with simple type
  docs/devel/qom: Fix the doc about OBJECT_DECLARE_SIMPLE_TYPE
  hw/acpi/pci: Consolidate OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES
  hw/char/sh_serial: Consolidate
    OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES
  hw/hyperv/hv-balloon: Consolidate
    OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES
  hw/ppc/pef: Consolidate OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES
  hw/core/resetcontainer: Consolidate OBJECT_DECLARE_SIMPLE_TYPE
  target/s390x/kvm/pv: Consolidate
    OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES
  ui/console-vc: Consolidate OBJECT_DEFINE_SIMPLE_TYPE

 docs/devel/qom.rst               | 11 +----------
 hw/acpi/pci.c                    | 24 ++++++++----------------
 hw/char/sh_serial.c              |  4 +---
 hw/hyperv/hv-balloon.c           |  8 ++------
 hw/ppc/pef.c                     | 17 ++++++-----------
 include/hw/core/resetcontainer.h |  2 +-
 include/qom/object.h             |  5 +++--
 target/s390x/kvm/pv.c            | 18 ++++++------------
 ui/console-vc.c                  | 14 ++++++++------
 9 files changed, 36 insertions(+), 67 deletions(-)

-- 
2.34.1

Re: [PATCH 0/9] qom: Consolidate OBJECT_{DEFINE|DECLARE}_SIMPLE_TYPE*

Posted by Michael Tokarev 5 months, 2 weeks ago

On 14.05.2025 11:49, Zhao Liu wrote:
> Hi,
> 
> When I read the qom doc (qom.rst) about OBJECT_DECLARE_SIMPLE_TYPE, I
> found there's the wrong example. So I tried to fix the doc and cleaned
> up the relevant code case to correctly show that for simple type, the
> class definition is not needed.
> 
> This series tries to:
> 
>   * fix & improve the documentation of OBJECT_{DEFINE|DECLARE}_SIMPLE_TYPE*,
> 
>   * and clean up several cases that could have used simple type macros
>     (mainly by dropping unneeded class definitions).

What's the status of this series?  It looks like it needs a respin?

Thanks,

/mjt