[v2] qcow2: queue discards when discard-no-unref enabled

[PATCH v2 0/2] qcow2: queue discards when discard-no-unref enabled

Posted by Jean-Louis Dupond 6 months ago

Partially based on the proposal of Andrey in
https://patchew.org/QEMU/20240913163942.423050-1-andrey.drobyshev@virtuozzo.com/
Split up this from the rest might get it merged a bit quicker hopefully :)

Since the implementation of discard-no-unref, we did not queue the discards correctly
when discard-no-unref was enabled.

Jean-Louis Dupond (2):
  qcow2: rename update_refcount_discard to queue_discard
  qcow2: put discards in discard queue when discard-no-unref is enabled

 block/qcow2-cluster.c  | 16 ++++++----------
 block/qcow2-refcount.c | 25 +++++++++++++++++++++----
 block/qcow2.h          |  4 ++++
 3 files changed, 31 insertions(+), 14 deletions(-)

-- 
2.49.0

Re: [PATCH v2 0/2] qcow2: queue discards when discard-no-unref enabled

Posted by Kevin Wolf 1 week, 4 days ago

Am 13.05.2025 um 15:26 hat Jean-Louis Dupond geschrieben:
> Partially based on the proposal of Andrey in
> https://patchew.org/QEMU/20240913163942.423050-1-andrey.drobyshev@virtuozzo.com/
> Split up this from the rest might get it merged a bit quicker hopefully :)
> 
> Since the implementation of discard-no-unref, we did not queue the
> discards correctly when discard-no-unref was enabled.

Thanks, applied to the block branch.

Kevin

Re: [PATCH v2 0/2] qcow2: queue discards when discard-no-unref enabled

Posted by Jean-Louis Dupond 2 months, 2 weeks ago

On 13/05/2025 15:26, Jean-Louis Dupond wrote:
> Partially based on the proposal of Andrey in
> https://patchew.org/QEMU/20240913163942.423050-1-andrey.drobyshev@virtuozzo.com/
> Split up this from the rest might get it merged a bit quicker hopefully :)
>
> Since the implementation of discard-no-unref, we did not queue the discards correctly
> when discard-no-unref was enabled.
>
> Jean-Louis Dupond (2):
>    qcow2: rename update_refcount_discard to queue_discard
>    qcow2: put discards in discard queue when discard-no-unref is enabled
>
>   block/qcow2-cluster.c  | 16 ++++++----------
>   block/qcow2-refcount.c | 25 +++++++++++++++++++++----
>   block/qcow2.h          |  4 ++++
>   3 files changed, 31 insertions(+), 14 deletions(-)
>
This was already reviewed.
Reviewed-by: Eric Blake <eblake@redhat.com>

Any chance on getting this merged?

Thanks
Jean-Louis

Re: [PATCH v2 0/2] qcow2: queue discards when discard-no-unref enabled

Posted by Jean-Louis Dupond 1 week, 4 days ago

On 29/08/2025 11:43, Jean-Louis Dupond wrote:
> On 13/05/2025 15:26, Jean-Louis Dupond wrote:
>> Partially based on the proposal of Andrey in
>> https://patchew.org/QEMU/20240913163942.423050-1-andrey.drobyshev@virtuozzo.com/ 
>>
>> Split up this from the rest might get it merged a bit quicker 
>> hopefully :)
>>
>> Since the implementation of discard-no-unref, we did not queue the 
>> discards correctly
>> when discard-no-unref was enabled.
>>
>> Jean-Louis Dupond (2):
>>    qcow2: rename update_refcount_discard to queue_discard
>>    qcow2: put discards in discard queue when discard-no-unref is enabled
>>
>>   block/qcow2-cluster.c  | 16 ++++++----------
>>   block/qcow2-refcount.c | 25 +++++++++++++++++++++----
>>   block/qcow2.h          |  4 ++++
>>   3 files changed, 31 insertions(+), 14 deletions(-)
>>
> This was already reviewed.
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Any chance on getting this merged?
Kind reminder :)
>
> Thanks
> Jean-Louis
>