tests/qtest/aspeed_smc-test: Fix memory leaks

[PATCH v1] tests/qtest/aspeed_smc-test: Fix memory leaks

Jamin Lin via posted 1 patch 6 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250513080806.1005996-1-jamin._5Flin@aspeedtech.com

Maintainers: "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

tests/qtest/aspeed_smc-test.c | 5 +++++
1 file changed, 5 insertions(+)

Expand all Fold all

[PATCH v1] tests/qtest/aspeed_smc-test: Fix memory leaks

Posted by Jamin Lin via 6 months ago

Link: https://patchwork.kernel.org/project/qemu-devel/patch/20250509175047.26066-1-farosas@suse.de/

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 tests/qtest/aspeed_smc-test.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c
index 4e1389385d..52a00e6f0a 100644
--- a/tests/qtest/aspeed_smc-test.c
+++ b/tests/qtest/aspeed_smc-test.c
@@ -228,5 +228,10 @@ int main(int argc, char **argv)
     unlink(ast2500_evb_data.tmp_path);
     unlink(ast2600_evb_data.tmp_path);
     unlink(ast1030_evb_data.tmp_path);
+    g_free(palmetto_data.tmp_path);
+    g_free(ast2500_evb_data.tmp_path);
+    g_free(ast2600_evb_data.tmp_path);
+    g_free(ast1030_evb_data.tmp_path);
+
     return ret;
 }
-- 
2.43.0

Re: [PATCH v1] tests/qtest/aspeed_smc-test: Fix memory leaks

Posted by Cédric Le Goater 6 months ago

On 5/13/25 10:08, Jamin Lin wrote:
> Link: https://patchwork.kernel.org/project/qemu-devel/patch/20250509175047.26066-1-farosas@suse.de/
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   tests/qtest/aspeed_smc-test.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c
> index 4e1389385d..52a00e6f0a 100644
> --- a/tests/qtest/aspeed_smc-test.c
> +++ b/tests/qtest/aspeed_smc-test.c
> @@ -228,5 +228,10 @@ int main(int argc, char **argv)
>       unlink(ast2500_evb_data.tmp_path);
>       unlink(ast2600_evb_data.tmp_path);
>       unlink(ast1030_evb_data.tmp_path);
> +    g_free(palmetto_data.tmp_path);
> +    g_free(ast2500_evb_data.tmp_path);
> +    g_free(ast2600_evb_data.tmp_path);
> +    g_free(ast1030_evb_data.tmp_path);
> +
>       return ret;
>   }


Applied to aspeed-next.

Thanks,

C.

Re: [PATCH v1] tests/qtest/aspeed_smc-test: Fix memory leaks

Posted by Laurent Vivier 6 months ago

On 13/05/2025 10:08, Jamin Lin wrote:
> Link: https://patchwork.kernel.org/project/qemu-devel/patch/20250509175047.26066-1-farosas@suse.de/
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   tests/qtest/aspeed_smc-test.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c
> index 4e1389385d..52a00e6f0a 100644
> --- a/tests/qtest/aspeed_smc-test.c
> +++ b/tests/qtest/aspeed_smc-test.c
> @@ -228,5 +228,10 @@ int main(int argc, char **argv)
>       unlink(ast2500_evb_data.tmp_path);
>       unlink(ast2600_evb_data.tmp_path);
>       unlink(ast1030_evb_data.tmp_path);
> +    g_free(palmetto_data.tmp_path);
> +    g_free(ast2500_evb_data.tmp_path);
> +    g_free(ast2600_evb_data.tmp_path);
> +    g_free(ast1030_evb_data.tmp_path);
> +
>       return ret;
>   }

Reviewed-by: Laurent Vivier <lvivier@redhat.com>