migration/multifd-nocomp.c | 3 +- migration/multifd-zero-page.c | 22 +++++++++- migration/multifd.c | 7 ++++ migration/options.c | 5 --- migration/ram.c | 5 +-- tests/qtest/migration/compression-tests.c | 18 ++++++++ tests/qtest/migration/postcopy-tests.c | 27 ++++++++++++ tests/qtest/migration/precopy-tests.c | 28 ++++++++++++- tests/qtest/migration/tls-tests.c | 50 +++++++++++++++++++++++ 9 files changed, 152 insertions(+), 13 deletions(-)
From: Prasad Pandit <pjp@fedoraproject.org>
Hello,
* This series (v11) fixes spelling and capitalisations glitches and
does some refactoring and reordering changes as suggested in the
review of v10.
===
67/67 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK 196.69s 81 subtests passed
===
v10: https://lore.kernel.org/qemu-devel/20250508122849.207213-2-ppandit@redhat.com/T/#t
* This series (v10) fixes the migration hang issue caused by optimised
writing of the zero pages during multifd phase. It also fixes the qtest
failure caused by missing 'env->has_uffd' check before running a postcopy
test.
Some of the patches from v9 series were pulled upstream. This series
has the remaining few patches.
===
67/67 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK 191.80s 81 subtests passed
===
v9: https://lore.kernel.org/qemu-devel/20250411114534.3370816-1-ppandit@redhat.com/T/#t
* This series (v9) does minor refactoring and reordering changes as
suggested in the review of earlier series (v8). Also tried to
reproduce/debug a qtest hang issue, but it could not be reproduced.
From the shared stack traces it looked like Postcopy thread was
preparing to finish before migrating all the pages.
===
67/67 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK 170.50s 81 subtests passed
===
v8: https://lore.kernel.org/qemu-devel/20250318123846.1370312-1-ppandit@redhat.com/T/#t
* This series (v8) splits earlier patch-2 which enabled multifd and
postcopy options together into two separate patches. One modifies
the channel discovery in migration_ioc_process_incoming() function,
and second one enables the multifd and postcopy migration together.
It also adds the 'save_postcopy_prepare' savevm_state handler to
enable different sections to take an action just before the Postcopy
phase starts. Thank you Peter for these patches.
===
67/67 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK 152.66s 81 subtests passed
===
v7: https://lore.kernel.org/qemu-devel/20250228121749.553184-1-ppandit@redhat.com/T/#t
* This series (v7) adds 'MULTIFD_RECV_SYNC' migration command. It is used
to notify the destination migration thread to synchronise with the Multifd
threads. This allows Multifd ('mig/dst/recv_x') threads on the destination
to receive all their data, before they are shutdown.
This series also updates the channel discovery function and qtests as
suggested in the previous review comments.
===
67/67 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK 147.84s 81 subtests passed
===
v6: https://lore.kernel.org/qemu-devel/20250215123119.814345-1-ppandit@redhat.com/T/#t
* This series (v6) shuts down Multifd threads before starting Postcopy
migration. It helps to avoid an issue of multifd pages arriving late
at the destination during Postcopy phase and corrupting the vCPU
state. It also reorders the qtest patches and does some refactoring
changes as suggested in previous review.
===
67/67 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK 161.35s 73 subtests passed
===
v5: https://lore.kernel.org/qemu-devel/20250205122712.229151-1-ppandit@redhat.com/T/#t
* This series (v5) consolidates migration capabilities setting in one
'set_migration_capabilities()' function, thus simplifying test sources.
It passes all migration tests.
===
66/66 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK 143.66s 71 subtests passed
===
v4: https://lore.kernel.org/qemu-devel/20250127120823.144949-1-ppandit@redhat.com/T/#t
* This series (v4) adds more 'multifd+postcopy' qtests which test
Precopy migration with 'postcopy-ram' attribute set. And run
Postcopy migrations with 'multifd' channels enabled.
===
$ ../qtest/migration-test --tap -k -r '/x86_64/migration/multifd+postcopy' | grep -i 'slow test'
# slow test /x86_64/migration/multifd+postcopy/plain executed in 1.29 secs
# slow test /x86_64/migration/multifd+postcopy/recovery/tls/psk executed in 2.48 secs
# slow test /x86_64/migration/multifd+postcopy/preempt/plain executed in 1.49 secs
# slow test /x86_64/migration/multifd+postcopy/preempt/recovery/tls/psk executed in 2.52 secs
# slow test /x86_64/migration/multifd+postcopy/tcp/tls/psk/match executed in 3.62 secs
# slow test /x86_64/migration/multifd+postcopy/tcp/plain/zstd executed in 1.34 secs
# slow test /x86_64/migration/multifd+postcopy/tcp/plain/cancel executed in 2.24 secs
...
66/66 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK 148.41s 71 subtests passed
===
v3: https://lore.kernel.org/qemu-devel/20250121131032.1611245-1-ppandit@redhat.com/T/#t
* This series (v3) passes all existing 'tests/qtest/migration/*' tests
and adds a new one to enable multifd channels with postcopy migration.
v2: https://lore.kernel.org/qemu-devel/20241129122256.96778-1-ppandit@redhat.com/T/#u
* This series (v2) further refactors the 'ram_save_target_page'
function to make it independent of the multifd & postcopy change.
v1: https://lore.kernel.org/qemu-devel/20241126115748.118683-1-ppandit@redhat.com/T/#u
* This series removes magic value (4-bytes) introduced in the
previous series for the Postcopy channel.
v0: https://lore.kernel.org/qemu-devel/20241029150908.1136894-1-ppandit@redhat.com/T/#u
* Currently Multifd and Postcopy migration can not be used together.
QEMU shows "Postcopy is not yet compatible with multifd" message.
When migrating guests with large (100's GB) RAM, Multifd threads
help to accelerate migration, but inability to use it with the
Postcopy mode delays guest start up on the destination side.
* This patch series allows to enable both Multifd and Postcopy
migration together. Precopy and Multifd threads work during
the initial guest (RAM) transfer. When migration moves to the
Postcopy phase, Multifd threads are restrained and the Postcopy
threads start to request pages from the source side.
* This series introduces magic value (4-bytes) to be sent on the
Postcopy channel. It helps to differentiate channels and properly
setup incoming connections on the destination side.
Thank you.
---
Prasad Pandit (3):
migration: write zero pages when postcopy enabled
migration: enable multifd and postcopy together
tests/qtest/migration: add postcopy tests with multifd
migration/multifd-nocomp.c | 3 +-
migration/multifd-zero-page.c | 22 +++++++++-
migration/multifd.c | 7 ++++
migration/options.c | 5 ---
migration/ram.c | 5 +--
tests/qtest/migration/compression-tests.c | 18 ++++++++
tests/qtest/migration/postcopy-tests.c | 27 ++++++++++++
tests/qtest/migration/precopy-tests.c | 28 ++++++++++++-
tests/qtest/migration/tls-tests.c | 50 +++++++++++++++++++++++
9 files changed, 152 insertions(+), 13 deletions(-)
--
2.49.0
On Mon, May 12, 2025 at 06:21:21PM +0530, Prasad Pandit wrote:
> From: Prasad Pandit <pjp@fedoraproject.org>
>
> Hello,
>
> * This series (v11) fixes spelling and capitalisations glitches and
> does some refactoring and reordering changes as suggested in the
> review of v10.
> ===
> 67/67 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test OK 196.69s 81 subtests passed
> ===
I queued it with some renames in the last test file, the fixup attached,
please let me know if anyone sees any issues.
In general, I put all the new tests under /migration/multifd+postcopy/,
rather than using different path.
Thanks,
===8<===
From 89c22f1c5fbb4afdf5bf3f3b0ef2dae162094488 Mon Sep 17 00:00:00 2001
From: Peter Xu <peterx@redhat.com>
Date: Tue, 13 May 2025 17:46:24 -0400
Subject: [PATCH] fixup! tests/qtest/migration: add postcopy tests with multifd
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qtest/migration/postcopy-tests.c | 4 ++--
tests/qtest/migration/tls-tests.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/migration/postcopy-tests.c b/tests/qtest/migration/postcopy-tests.c
index eb637f94f7..3773525843 100644
--- a/tests/qtest/migration/postcopy-tests.c
+++ b/tests/qtest/migration/postcopy-tests.c
@@ -137,9 +137,9 @@ void migration_test_add_postcopy(MigrationTestEnv *env)
"/migration/postcopy/recovery/double-failures/reconnect",
test_postcopy_recovery_fail_reconnect);
- migration_test_add("/migration/postcopy/multifd/plain",
+ migration_test_add("/migration/multifd+postcopy/plain",
test_multifd_postcopy);
- migration_test_add("/migration/postcopy/multifd/preempt/plain",
+ migration_test_add("/migration/multifd+postcopy/preempt/plain",
test_multifd_postcopy_preempt);
if (env->is_x86) {
migration_test_add("/migration/postcopy/suspend",
diff --git a/tests/qtest/migration/tls-tests.c b/tests/qtest/migration/tls-tests.c
index 50a07a1c0f..46b48ef78c 100644
--- a/tests/qtest/migration/tls-tests.c
+++ b/tests/qtest/migration/tls-tests.c
@@ -816,9 +816,9 @@ void migration_test_add_tls(MigrationTestEnv *env)
test_postcopy_preempt_tls_psk);
migration_test_add("/migration/postcopy/preempt/recovery/tls/psk",
test_postcopy_preempt_all);
- migration_test_add("/migration/postcopy/multifd/recovery/tls/psk",
+ migration_test_add("/migration/multifd+postcopy/recovery/tls/psk",
test_multifd_postcopy_recovery_tls_psk);
- migration_test_add("/migration/postcopy/multifd/preempt/recovery/tls/psk",
+ migration_test_add("/migration/multifd+postcopy/preempt/recovery/tls/psk",
test_multifd_postcopy_preempt_recovery_tls_psk);
}
#ifdef CONFIG_TASN1
--
2.49.0
--
Peter Xu
© 2016 - 2025 Red Hat, Inc.