[v1] aspeed queue

[PULL 00/23] aspeed queue

Posted by Cédric Le Goater 7 months, 2 weeks ago

The following changes since commit e578dcc7e1590b20a84036afe5bdfa8d23a6048e:

  pc-bios: Add AST27x0 vBootrom (2025-05-02 09:47:14 +0200)

are available in the Git repository at:

  https://github.com/legoater/qemu/ tags/pull-aspeed-20250505

for you to fetch changes up to f32ef57f7de98ec36da52b0a13bd5d18ac4bd583:

  docs: Add support for ast2700fc machine (2025-05-05 09:42:16 +0200)

----------------------------------------------------------------
aspeed queue:

* Fixed AST2700 SPI model issues
* Updated SDK images
* Added FW support to the AST2700 EVB machines
* Introduced an AST27x0 multi-SoC machine

----------------------------------------------------------------
Jamin Lin (12):
      tests/functional/aspeed: Update test ASPEED SDK v09.06 for AST2500
      tests/functional/aspeed: Update test ASPEED SDK v09.06 for AST2600
      tests/functional/aspeed: Update test ASPEED SDK v03.00 for AST1030
      hw/arm/aspeed_ast27x0: Rename variable sram_name to name in ast2700 realize
      tests/functional/aspeed: Move I2C test into shared helper for AST2700 reuse
      tests/functional/aspeed: Update test ASPEED SDK v09.06
      tests/functional/aspeed: extract boot and login sequence into helper function
      hw/arm/aspeed_ast27x0 Introduce vbootrom memory region
      hw/arm/aspeed: Add support for loading vbootrom image via "-bios"
      tests/functional/aspeed: Add to test vbootrom for AST2700
      docs/system/arm/aspeed: move AST2700 content to new section
      docs/system/arm/aspeed: Support vbootrom for AST2700

Joe Komlodi (1):
      hw/ssi/aspeed_smc: Allow 64-bit wide flash accesses

Steven Lee (9):
      aspeed: ast27x0: Map unimplemented devices in SoC memory
      aspeed: ast27x0: Correct hex notation for device addresses
      hw/intc/aspeed: Add support for AST2700 SSP INTC
      hw/intc/aspeed: Add support for AST2700 TSP INTC
      hw/arm/aspeed_ast27x0-ssp: Introduce AST27x0 A1 SSP SoC
      hw/arm/aspeed_ast27x0-tsp: Introduce AST27x0 A1 TSP SoC
      hw/arm: Introduce ASPEED AST2700 A1 full core machine
      tests/function/aspeed: Add functional test for ast2700fc
      docs: Add support for ast2700fc machine

Troy Lee (1):
      hw/arm: ast27x0: Wire up EHCI controllers

 docs/system/arm/aspeed.rst                         | 164 +++++++-
 include/hw/arm/aspeed.h                            |   1 +
 include/hw/arm/aspeed_soc.h                        |  38 +-
 include/hw/intc/aspeed_intc.h                      |   5 +
 hw/arm/aspeed.c                                    |  36 ++
 hw/arm/aspeed_ast27x0-fc.c                         | 192 ++++++++++
 hw/arm/aspeed_ast27x0-ssp.c                        | 294 +++++++++++++++
 hw/arm/aspeed_ast27x0-tsp.c                        | 294 +++++++++++++++
 hw/arm/aspeed_ast27x0.c                            | 125 +++++--
 hw/intc/aspeed_intc.c                              | 416 +++++++++++++++++++++
 hw/ssi/aspeed_smc.c                                |   4 +-
 hw/arm/meson.build                                 |   6 +-
 tests/functional/meson.build                       |   6 +-
 ...64_aspeed.py => test_aarch64_aspeed_ast2700.py} |  82 ++--
 tests/functional/test_aarch64_aspeed_ast2700fc.py  | 135 +++++++
 tests/functional/test_arm_aspeed_ast1030.py        |  10 +-
 tests/functional/test_arm_aspeed_ast2500.py        |   8 +-
 tests/functional/test_arm_aspeed_ast2600.py        |  15 +-
 18 files changed, 1749 insertions(+), 82 deletions(-)
 create mode 100644 hw/arm/aspeed_ast27x0-fc.c
 create mode 100644 hw/arm/aspeed_ast27x0-ssp.c
 create mode 100644 hw/arm/aspeed_ast27x0-tsp.c
 rename tests/functional/{test_aarch64_aspeed.py => test_aarch64_aspeed_ast2700.py} (64%)
 create mode 100755 tests/functional/test_aarch64_aspeed_ast2700fc.py

Re: [PULL 00/23] aspeed queue

Posted by Philippe Mathieu-Daudé 7 months, 2 weeks ago

Hi Cédric,

On 5/5/25 11:06, Cédric Le Goater wrote:
> The following changes since commit e578dcc7e1590b20a84036afe5bdfa8d23a6048e:
> 
>    pc-bios: Add AST27x0 vBootrom (2025-05-02 09:47:14 +0200)
> 
> are available in the Git repository at:
> 
>    https://github.com/legoater/qemu/ tags/pull-aspeed-20250505
> 
> for you to fetch changes up to f32ef57f7de98ec36da52b0a13bd5d18ac4bd583:
> 
>    docs: Add support for ast2700fc machine (2025-05-05 09:42:16 +0200)
> 
> ----------------------------------------------------------------
> aspeed queue:
> 
> * Fixed AST2700 SPI model issues
> * Updated SDK images
> * Added FW support to the AST2700 EVB machines
> * Introduced an AST27x0 multi-SoC machine
> 
> ----------------------------------------------------------------
> Jamin Lin (12):
>        tests/functional/aspeed: Update test ASPEED SDK v09.06 for AST2500
>        tests/functional/aspeed: Update test ASPEED SDK v09.06 for AST2600
>        tests/functional/aspeed: Update test ASPEED SDK v03.00 for AST1030
>        hw/arm/aspeed_ast27x0: Rename variable sram_name to name in ast2700 realize
>        tests/functional/aspeed: Move I2C test into shared helper for AST2700 reuse
>        tests/functional/aspeed: Update test ASPEED SDK v09.06
>        tests/functional/aspeed: extract boot and login sequence into helper function
>        hw/arm/aspeed_ast27x0 Introduce vbootrom memory region
>        hw/arm/aspeed: Add support for loading vbootrom image via "-bios"
>        tests/functional/aspeed: Add to test vbootrom for AST2700
>        docs/system/arm/aspeed: move AST2700 content to new section
>        docs/system/arm/aspeed: Support vbootrom for AST2700
> 
> Joe Komlodi (1):
>        hw/ssi/aspeed_smc: Allow 64-bit wide flash accesses
> 
> Steven Lee (9):
>        aspeed: ast27x0: Map unimplemented devices in SoC memory
>        aspeed: ast27x0: Correct hex notation for device addresses
>        hw/intc/aspeed: Add support for AST2700 SSP INTC
>        hw/intc/aspeed: Add support for AST2700 TSP INTC
>        hw/arm/aspeed_ast27x0-ssp: Introduce AST27x0 A1 SSP SoC
>        hw/arm/aspeed_ast27x0-tsp: Introduce AST27x0 A1 TSP SoC
>        hw/arm: Introduce ASPEED AST2700 A1 full core machine
>        tests/function/aspeed: Add functional test for ast2700fc
>        docs: Add support for ast2700fc machine
> 
> Troy Lee (1):
>        hw/arm: ast27x0: Wire up EHCI controllers

If you ever have to send a v2, please remove the 'Change-Id:' tags.

Re: [PULL 00/23] aspeed queue

Posted by Cédric Le Goater 7 months, 2 weeks ago

On 5/5/25 11:35, Philippe Mathieu-Daudé wrote:
> Hi Cédric,
> 
> On 5/5/25 11:06, Cédric Le Goater wrote:
>> The following changes since commit e578dcc7e1590b20a84036afe5bdfa8d23a6048e:
>>
>>    pc-bios: Add AST27x0 vBootrom (2025-05-02 09:47:14 +0200)
>>
>> are available in the Git repository at:
>>
>>    https://github.com/legoater/qemu/ tags/pull-aspeed-20250505
>>
>> for you to fetch changes up to f32ef57f7de98ec36da52b0a13bd5d18ac4bd583:
>>
>>    docs: Add support for ast2700fc machine (2025-05-05 09:42:16 +0200)
>>
>> ----------------------------------------------------------------
>> aspeed queue:
>>
>> * Fixed AST2700 SPI model issues
>> * Updated SDK images
>> * Added FW support to the AST2700 EVB machines
>> * Introduced an AST27x0 multi-SoC machine
>>
>> ----------------------------------------------------------------
>> Jamin Lin (12):
>>        tests/functional/aspeed: Update test ASPEED SDK v09.06 for AST2500
>>        tests/functional/aspeed: Update test ASPEED SDK v09.06 for AST2600
>>        tests/functional/aspeed: Update test ASPEED SDK v03.00 for AST1030
>>        hw/arm/aspeed_ast27x0: Rename variable sram_name to name in ast2700 realize
>>        tests/functional/aspeed: Move I2C test into shared helper for AST2700 reuse
>>        tests/functional/aspeed: Update test ASPEED SDK v09.06
>>        tests/functional/aspeed: extract boot and login sequence into helper function
>>        hw/arm/aspeed_ast27x0 Introduce vbootrom memory region
>>        hw/arm/aspeed: Add support for loading vbootrom image via "-bios"
>>        tests/functional/aspeed: Add to test vbootrom for AST2700
>>        docs/system/arm/aspeed: move AST2700 content to new section
>>        docs/system/arm/aspeed: Support vbootrom for AST2700
>>
>> Joe Komlodi (1):
>>        hw/ssi/aspeed_smc: Allow 64-bit wide flash accesses
>>
>> Steven Lee (9):
>>        aspeed: ast27x0: Map unimplemented devices in SoC memory
>>        aspeed: ast27x0: Correct hex notation for device addresses
>>        hw/intc/aspeed: Add support for AST2700 SSP INTC
>>        hw/intc/aspeed: Add support for AST2700 TSP INTC
>>        hw/arm/aspeed_ast27x0-ssp: Introduce AST27x0 A1 SSP SoC
>>        hw/arm/aspeed_ast27x0-tsp: Introduce AST27x0 A1 TSP SoC
>>        hw/arm: Introduce ASPEED AST2700 A1 full core machine
>>        tests/function/aspeed: Add functional test for ast2700fc
>>        docs: Add support for ast2700fc machine
>>
>> Troy Lee (1):
>>        hw/arm: ast27x0: Wire up EHCI controllers
> 
> If you ever have to send a v2, please remove the 'Change-Id:' tags.
> 

This is a Gerrit trailer AFAICT.

Why ? is it breaking some tool ? Can't we keep such reference ? If so,
I'd rather fix checkpatch.pl.

Thanks,

C.