hw/net/e1000: Remove stray empty comment in header

[PATCH] hw/net/e1000: Remove stray empty comment in header

Gustavo Romero posted 1 patch 7 months, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250504215639.54860-4-gustavo.romero@linaro.org

Maintainers: Dmitry Fleytman <dmitry.fleytman@gmail.com>, Akihiko Odaki <akihiko.odaki@daynix.com>, Jason Wang <jasowang@redhat.com>

hw/net/e1000x_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] hw/net/e1000: Remove stray empty comment in header

Posted by Gustavo Romero 7 months, 2 weeks ago

In the header file, remove a stray empty comment in the Offload Context
Descriptor struct.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
---
 hw/net/e1000x_regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/e1000x_regs.h b/hw/net/e1000x_regs.h
index cd896fc0ca..e9a74de6f4 100644
--- a/hw/net/e1000x_regs.h
+++ b/hw/net/e1000x_regs.h
@@ -900,7 +900,7 @@ struct e1000_context_desc {
             uint16_t tucse;     /* TCP checksum end */
         } tcp_fields;
     } upper_setup;
-    uint32_t cmd_and_length;    /* */
+    uint32_t cmd_and_length;
     union {
         uint32_t data;
         struct {
-- 
2.34.1

Re: [PATCH] hw/net/e1000: Remove stray empty comment in header

Posted by Thomas Huth 7 months, 2 weeks ago

On 04/05/2025 23.56, Gustavo Romero wrote:
> In the header file, remove a stray empty comment in the Offload Context
> Descriptor struct.
> 
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> ---
>   hw/net/e1000x_regs.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/e1000x_regs.h b/hw/net/e1000x_regs.h
> index cd896fc0ca..e9a74de6f4 100644
> --- a/hw/net/e1000x_regs.h
> +++ b/hw/net/e1000x_regs.h
> @@ -900,7 +900,7 @@ struct e1000_context_desc {
>               uint16_t tucse;     /* TCP checksum end */
>           } tcp_fields;
>       } upper_setup;
> -    uint32_t cmd_and_length;    /* */
> +    uint32_t cmd_and_length;
>       union {
>           uint32_t data;
>           struct {

There is another one in hw/net/eepro100.c ...

Anyway,
Reviewed-by: Thomas Huth <thuth@redhat.com>