[v3] hw/e1000e|igb: interrupts and qtests fixes

[PATCH v3 07/12] igb: Add a note about re-loading timers breaking deterministic replay

Nicholas Piggin posted 12 patches 6 months, 2 weeks ago

Diff against v1 v2
Download mbox

Maintainers: Dmitry Fleytman <dmitry.fleytman@gmail.com>, Akihiko Odaki <akihiko.odaki@daynix.com>, Jason Wang <jasowang@redhat.com>, Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Expand all Fold all

[PATCH v3 07/12] igb: Add a note about re-loading timers breaking deterministic replay

Posted by Nicholas Piggin 6 months, 2 weeks ago

Add a note about the problem re-loading timers with default values.
Deterministic replay requires the timers be migrated with the same
value.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 hw/net/igb_core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index eedc341f298..3ae3e53530b 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -4589,7 +4589,9 @@ igb_core_post_load(IGBCore *core)
 
     /*
      * we need to restart intrmgr timers, as an older version of
-     * QEMU can have stopped them before migration
+     * QEMU can have stopped them before migration.
+     * XXX: re-setting timers with fresh values breaks deterministic
+     * replay.
      */
     igb_intrmgr_resume(core);
     igb_autoneg_resume(core);
-- 
2.47.1