[PULL v2 0/8] block-job patches 2025-04-29

Vladimir Sementsov-Ogievskiy posted 8 patches 9 months, 1 week ago
Only 1 patches received!
There is a newer version of this series
block/backup.c                                  |   3 +-
block/commit.c                                  | 118 +++++++++++++++++-------
block/copy-before-write.c                       |   2 +
block/copy-before-write.h                       |   1 +
block/replication.c                             |   4 +-
blockdev.c                                      |   6 ++
docs/about/deprecated.rst                       |  31 +++++++
include/block/block_int-global-state.h          |   2 +
qapi/block-core.json                            |  95 ++++++++++++++-----
qapi/job.json                                   |  30 +++++-
tests/qemu-iotests/tests/commit-zero-blocks     |  96 +++++++++++++++++++
tests/qemu-iotests/tests/commit-zero-blocks.out |  54 +++++++++++
tests/qemu-iotests/tests/copy-before-write      |  90 ++++++++++++++++++
tests/qemu-iotests/tests/copy-before-write.out  |   4 +-
14 files changed, 471 insertions(+), 65 deletions(-)
create mode 100755 tests/qemu-iotests/tests/commit-zero-blocks
create mode 100644 tests/qemu-iotests/tests/commit-zero-blocks.out
[PULL v2 0/8] block-job patches 2025-04-29
Posted by Vladimir Sementsov-Ogievskiy 9 months, 1 week ago
The following changes since commit 73d29ea2417b58ca55fba1aa468ba38e3607b583:

  Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2025-04-27 12:47:23 -0400)

are available in the Git repository at:

  https://gitlab.com/vsementsov/qemu.git tags/pull-block-jobs-2025-04-29-v2

for you to fetch changes up to 35655b2d1b1015e3a6fa99ef9c2afc1826a765ba:

  blockdev-backup: Add error handling option for copy-before-write jobs (2025-05-01 12:12:19 +0300)

----------------------------------------------------------------
block-job patches

- deprecate some old block-job- APIs
- on-cbw-error option for backup
- more efficient zero handling in block commit

v2:
[03]: move variable declaration to function top, to silence clang and to
      follow QEMU coding style

----------------------------------------------------------------
Raman Dzehtsiar (1):
      blockdev-backup: Add error handling option for copy-before-write jobs

Vincent Vanlaer (5):
      block: get type of block allocation in commit_run
      block: move commit_run loop to separate function
      block: refactor error handling of commit_iteration
      block: allow commit to unmap zero blocks
      block: add test non-active commit with zeroed data

Vladimir Sementsov-Ogievskiy (2):
      qapi: synchronize jobs and block-jobs documentation
      qapi/block-core: deprecate some block-job- APIs

 block/backup.c                                  |   3 +-
 block/commit.c                                  | 118 +++++++++++++++++-------
 block/copy-before-write.c                       |   2 +
 block/copy-before-write.h                       |   1 +
 block/replication.c                             |   4 +-
 blockdev.c                                      |   6 ++
 docs/about/deprecated.rst                       |  31 +++++++
 include/block/block_int-global-state.h          |   2 +
 qapi/block-core.json                            |  95 ++++++++++++++-----
 qapi/job.json                                   |  30 +++++-
 tests/qemu-iotests/tests/commit-zero-blocks     |  96 +++++++++++++++++++
 tests/qemu-iotests/tests/commit-zero-blocks.out |  54 +++++++++++
 tests/qemu-iotests/tests/copy-before-write      |  90 ++++++++++++++++++
 tests/qemu-iotests/tests/copy-before-write.out  |   4 +-
 14 files changed, 471 insertions(+), 65 deletions(-)
 create mode 100755 tests/qemu-iotests/tests/commit-zero-blocks
 create mode 100644 tests/qemu-iotests/tests/commit-zero-blocks.out

-- 
2.48.1
Re: [PULL v2 0/8] block-job patches 2025-04-29
Posted by Stefan Hajnoczi 9 months, 1 week ago
On Thu, May 1, 2025 at 5:25 AM Vladimir Sementsov-Ogievskiy
<vsementsov@yandex-team.ru> wrote:
>
> The following changes since commit 73d29ea2417b58ca55fba1aa468ba38e3607b583:
>
>   Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2025-04-27 12:47:23 -0400)
>
> are available in the Git repository at:
>
>   https://gitlab.com/vsementsov/qemu.git tags/pull-block-jobs-2025-04-29-v2
>
> for you to fetch changes up to 35655b2d1b1015e3a6fa99ef9c2afc1826a765ba:
>
>   blockdev-backup: Add error handling option for copy-before-write jobs (2025-05-01 12:12:19 +0300)
>
> ----------------------------------------------------------------
> block-job patches
>
> - deprecate some old block-job- APIs
> - on-cbw-error option for backup
> - more efficient zero handling in block commit
>
> v2:
> [03]: move variable declaration to function top, to silence clang and to
>       follow QEMU coding style
>
> ----------------------------------------------------------------
> Raman Dzehtsiar (1):
>       blockdev-backup: Add error handling option for copy-before-write jobs

iotests-pylint is failing:

Log file "stdout" content for test "03-tests/iotests-pylint.sh" (FAIL):
************* Module tests.copy-before-write
tests/copy-before-write:151:0: C0301: Line too long (94/79) (line-too-long)

https://gitlab.com/qemu-project/qemu/-/jobs/9931080975#L656

>
> Vincent Vanlaer (5):
>       block: get type of block allocation in commit_run
>       block: move commit_run loop to separate function
>       block: refactor error handling of commit_iteration
>       block: allow commit to unmap zero blocks
>       block: add test non-active commit with zeroed data
>
> Vladimir Sementsov-Ogievskiy (2):
>       qapi: synchronize jobs and block-jobs documentation
>       qapi/block-core: deprecate some block-job- APIs
>
>  block/backup.c                                  |   3 +-
>  block/commit.c                                  | 118 +++++++++++++++++-------
>  block/copy-before-write.c                       |   2 +
>  block/copy-before-write.h                       |   1 +
>  block/replication.c                             |   4 +-
>  blockdev.c                                      |   6 ++
>  docs/about/deprecated.rst                       |  31 +++++++
>  include/block/block_int-global-state.h          |   2 +
>  qapi/block-core.json                            |  95 ++++++++++++++-----
>  qapi/job.json                                   |  30 +++++-
>  tests/qemu-iotests/tests/commit-zero-blocks     |  96 +++++++++++++++++++
>  tests/qemu-iotests/tests/commit-zero-blocks.out |  54 +++++++++++
>  tests/qemu-iotests/tests/copy-before-write      |  90 ++++++++++++++++++
>  tests/qemu-iotests/tests/copy-before-write.out  |   4 +-
>  14 files changed, 471 insertions(+), 65 deletions(-)
>  create mode 100755 tests/qemu-iotests/tests/commit-zero-blocks
>  create mode 100644 tests/qemu-iotests/tests/commit-zero-blocks.out
>
> --
> 2.48.1
>