[v5] GT64120 PCI endianness fixes and cleanup

[PATCH v5 0/2] GT64120 PCI endianness fixes and cleanup

Rakesh Jeyasingh posted 2 patches 6 months, 2 weeks ago

Diff against v3 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250429170354.150581-1-rakeshjb010@gmail.com

Maintainers: "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Richard Henderson <richard.henderson@linaro.org>, Helge Deller <deller@gmx.de>

hw/pci-host/gt64120.c      | 82 ++++++++++++++++++++++----------------
hw/pci/pci_host.c          |  6 ---
include/hw/pci-host/dino.h |  4 --
include/hw/pci/pci_host.h  |  1 -
4 files changed, 48 insertions(+), 45 deletions(-)

Expand all Fold all

[PATCH v5 0/2] GT64120 PCI endianness fixes and cleanup

Posted by Rakesh Jeyasingh 6 months, 2 weeks ago

Changes since v4:
1.Introduced needs_bswap() helper for clean endianness logic
2.use the existing pci_host_data_le_ops.read/write from hw/pci/pci_host.c

v4:https://patchew.org/QEMU/20250331184820.34673-1-rakeshjb010@gmail.com/

Rakesh Jeyasingh (2):
  hw/pci-host/gt64120: Fix endianness handling
  hw/pci-host: Remove unused pci_host_data_be_ops

 hw/pci-host/gt64120.c      | 82 ++++++++++++++++++++++----------------
 hw/pci/pci_host.c          |  6 ---
 include/hw/pci-host/dino.h |  4 --
 include/hw/pci/pci_host.h  |  1 -
 4 files changed, 48 insertions(+), 45 deletions(-)

-- 
2.43.0

Re: [PATCH v5 0/2] GT64120 PCI endianness fixes and cleanup

Posted by Thomas Huth 6 months ago

On 29/04/2025 19.03, Rakesh Jeyasingh wrote:
> Changes since v4:
> 1.Introduced needs_bswap() helper for clean endianness logic
> 2.use the existing pci_host_data_le_ops.read/write from hw/pci/pci_host.c
> 
> v4:https://patchew.org/QEMU/20250331184820.34673-1-rakeshjb010@gmail.com/
> 
> Rakesh Jeyasingh (2):
>    hw/pci-host/gt64120: Fix endianness handling
>    hw/pci-host: Remove unused pci_host_data_be_ops
> 
>   hw/pci-host/gt64120.c      | 82 ++++++++++++++++++++++----------------
>   hw/pci/pci_host.c          |  6 ---
>   include/hw/pci-host/dino.h |  4 --
>   include/hw/pci/pci_host.h  |  1 -
>   4 files changed, 48 insertions(+), 45 deletions(-)

Thanks for tackling this ... I gave it a try on both, little and big endian 
host and it seems to work as expected now.

Series
Tested-by: Thomas Huth <thuth@redhat.com>