[PATCH 3/6] qdev: make release_tpm() idempotent

marcandre.lureau@redhat.com posted 6 patches 6 months, 2 weeks ago
Maintainers: Stefan Berger <stefanb@linux.vnet.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>
[PATCH 3/6] qdev: make release_tpm() idempotent
Posted by marcandre.lureau@redhat.com 6 months, 2 weeks ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

So it can eventually be called multiple times safely.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 backends/tpm/tpm_util.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/backends/tpm/tpm_util.c b/backends/tpm/tpm_util.c
index f2d1739e33..16eab82cd2 100644
--- a/backends/tpm/tpm_util.c
+++ b/backends/tpm/tpm_util.c
@@ -72,6 +72,7 @@ static void release_tpm(Object *obj, const char *name, void *opaque)
 
     if (*be) {
         tpm_backend_reset(*be);
+        *be = NULL;
     }
 }
 
-- 
2.49.0


Re: [PATCH 3/6] qdev: make release_tpm() idempotent
Posted by Stefan Berger 6 months, 2 weeks ago

On 4/29/25 10:03 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> So it can eventually be called multiple times safely.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   backends/tpm/tpm_util.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/backends/tpm/tpm_util.c b/backends/tpm/tpm_util.c
> index f2d1739e33..16eab82cd2 100644
> --- a/backends/tpm/tpm_util.c
> +++ b/backends/tpm/tpm_util.c
> @@ -72,6 +72,7 @@ static void release_tpm(Object *obj, const char *name, void *opaque)
> 
>       if (*be) {
>           tpm_backend_reset(*be);
> +        *be = NULL;
>       }
>   }
> 

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>