APCI PCI Hotplug support on ARM

[RFC 02/24] hw/acpi/ged: Fix wrong identation

Posted by Eric Auger 6 months, 3 weeks ago

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 hw/acpi/generic_event_device.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
index c85d97ca37..7b2d582fff 100644
--- a/hw/acpi/generic_event_device.c
+++ b/hw/acpi/generic_event_device.c
@@ -458,11 +458,11 @@ static void acpi_ged_initfn(Object *obj)
      * container for memory hotplug IO and expose it as GED sysbus
      * MMIO so that boards can map it separately.
      */
-     memory_region_init(&s->container_memhp, OBJECT(dev), "memhp container",
-                        MEMORY_HOTPLUG_IO_LEN);
-     sysbus_init_mmio(sbd, &s->container_memhp);
-     acpi_memory_hotplug_init(&s->container_memhp, OBJECT(dev),
-                              &s->memhp_state, 0);
+    memory_region_init(&s->container_memhp, OBJECT(dev), "memhp container",
+                       MEMORY_HOTPLUG_IO_LEN);
+    sysbus_init_mmio(sbd, &s->container_memhp);
+    acpi_memory_hotplug_init(&s->container_memhp, OBJECT(dev),
+                             &s->memhp_state, 0);
 
     memory_region_init_io(&ged_st->regs, obj, &ged_regs_ops, ged_st,
                           TYPE_ACPI_GED "-regs", ACPI_GED_REG_COUNT);
-- 
2.49.0

Re: [RFC 02/24] hw/acpi/ged: Fix wrong identation

Posted by Gustavo Romero 6 months, 1 week ago

Hi Eric,

On 4/28/25 07:25, Eric Auger wrote:
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
>   hw/acpi/generic_event_device.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> index c85d97ca37..7b2d582fff 100644
> --- a/hw/acpi/generic_event_device.c
> +++ b/hw/acpi/generic_event_device.c
> @@ -458,11 +458,11 @@ static void acpi_ged_initfn(Object *obj)
>        * container for memory hotplug IO and expose it as GED sysbus
>        * MMIO so that boards can map it separately.
>        */
> -     memory_region_init(&s->container_memhp, OBJECT(dev), "memhp container",
> -                        MEMORY_HOTPLUG_IO_LEN);
> -     sysbus_init_mmio(sbd, &s->container_memhp);
> -     acpi_memory_hotplug_init(&s->container_memhp, OBJECT(dev),
> -                              &s->memhp_state, 0);
> +    memory_region_init(&s->container_memhp, OBJECT(dev), "memhp container",
> +                       MEMORY_HOTPLUG_IO_LEN);
> +    sysbus_init_mmio(sbd, &s->container_memhp);
> +    acpi_memory_hotplug_init(&s->container_memhp, OBJECT(dev),
> +                             &s->memhp_state, 0);
>   
>       memory_region_init_io(&ged_st->regs, obj, &ged_regs_ops, ged_st,
>                             TYPE_ACPI_GED "-regs", ACPI_GED_REG_COUNT);

Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org>


Cheers,
Gustavo