APCI PCI Hotplug support on ARM

[RFC 01/24] hw/pci/pcie_port: Fix pcie_slot_is_hotpluggbale_bus typo

Posted by Eric Auger 6 months, 3 weeks ago

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 hw/pci/pcie_port.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
index c73db30e98..072500ed34 100644
--- a/hw/pci/pcie_port.c
+++ b/hw/pci/pcie_port.c
@@ -188,7 +188,7 @@ int pcie_count_ds_ports(PCIBus *bus)
     return dsp_count;
 }
 
-static bool pcie_slot_is_hotpluggbale_bus(HotplugHandler *plug_handler,
+static bool pcie_slot_is_hotpluggable_bus(HotplugHandler *plug_handler,
                                           BusState *bus)
 {
     PCIESlot *s = PCIE_SLOT(bus->parent);
@@ -221,7 +221,7 @@ static void pcie_slot_class_init(ObjectClass *oc, void *data)
     hc->plug = pcie_cap_slot_plug_cb;
     hc->unplug = pcie_cap_slot_unplug_cb;
     hc->unplug_request = pcie_cap_slot_unplug_request_cb;
-    hc->is_hotpluggable_bus = pcie_slot_is_hotpluggbale_bus;
+    hc->is_hotpluggable_bus = pcie_slot_is_hotpluggable_bus;
 }
 
 static const TypeInfo pcie_slot_type_info = {
-- 
2.49.0

Re: [RFC 01/24] hw/pci/pcie_port: Fix pcie_slot_is_hotpluggbale_bus typo

Posted by Gustavo Romero 6 months, 1 week ago

Hi Eric,

On 4/28/25 07:25, Eric Auger wrote:
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
>   hw/pci/pcie_port.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
> index c73db30e98..072500ed34 100644
> --- a/hw/pci/pcie_port.c
> +++ b/hw/pci/pcie_port.c
> @@ -188,7 +188,7 @@ int pcie_count_ds_ports(PCIBus *bus)
>       return dsp_count;
>   }
>   
> -static bool pcie_slot_is_hotpluggbale_bus(HotplugHandler *plug_handler,
> +static bool pcie_slot_is_hotpluggable_bus(HotplugHandler *plug_handler,
>                                             BusState *bus)
>   {
>       PCIESlot *s = PCIE_SLOT(bus->parent);
> @@ -221,7 +221,7 @@ static void pcie_slot_class_init(ObjectClass *oc, void *data)
>       hc->plug = pcie_cap_slot_plug_cb;
>       hc->unplug = pcie_cap_slot_unplug_cb;
>       hc->unplug_request = pcie_cap_slot_unplug_request_cb;
> -    hc->is_hotpluggable_bus = pcie_slot_is_hotpluggbale_bus;
> +    hc->is_hotpluggable_bus = pcie_slot_is_hotpluggable_bus;
>   }
>   
>   static const TypeInfo pcie_slot_type_info = {

Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org>


Cheers,
Gustavo