[PATCH v7 0/6] Report vfio-ap configuration changes

Rorie Reyes posted 6 patches 7 months, 3 weeks ago
Failed in applying to current master (apply log)
There is a newer version of this series
MAINTAINERS                                   |   1 +
hw/vfio/ap-stub.c                             |  23 ++++
hw/vfio/ap.c                                  |  82 +++++++++++
hw/vfio/meson.build                           |   1 +
include/hw/s390x/ap-bridge.h                  |  22 +++
include/standard-headers/asm-x86/setup_data.h |   4 +-
include/standard-headers/drm/drm_fourcc.h     |  41 ++++++
include/standard-headers/linux/const.h        |   2 +-
include/standard-headers/linux/ethtool.h      |  22 +++
include/standard-headers/linux/fuse.h         |  12 +-
include/standard-headers/linux/pci_regs.h     |  13 +-
include/standard-headers/linux/virtio_net.h   |  13 ++
include/standard-headers/linux/virtio_snd.h   |   2 +-
linux-headers/asm-arm64/kvm.h                 |  11 ++
linux-headers/asm-arm64/unistd_64.h           |   1 +
linux-headers/asm-generic/mman-common.h       |   1 +
linux-headers/asm-generic/unistd.h            |   4 +-
linux-headers/asm-loongarch/unistd_64.h       |   1 +
linux-headers/asm-mips/unistd_n32.h           |   1 +
linux-headers/asm-mips/unistd_n64.h           |   1 +
linux-headers/asm-mips/unistd_o32.h           |   1 +
linux-headers/asm-powerpc/unistd_32.h         |   1 +
linux-headers/asm-powerpc/unistd_64.h         |   1 +
linux-headers/asm-riscv/kvm.h                 |   2 +
linux-headers/asm-riscv/unistd_32.h           |   1 +
linux-headers/asm-riscv/unistd_64.h           |   1 +
linux-headers/asm-s390/unistd_32.h            |   1 +
linux-headers/asm-s390/unistd_64.h            |   1 +
linux-headers/asm-x86/kvm.h                   |   3 +
linux-headers/asm-x86/unistd_32.h             |   1 +
linux-headers/asm-x86/unistd_64.h             |   1 +
linux-headers/asm-x86/unistd_x32.h            |   1 +
linux-headers/linux/bits.h                    |   8 +-
linux-headers/linux/const.h                   |   2 +-
linux-headers/linux/iommufd.h                 | 129 +++++++++++++++++-
linux-headers/linux/kvm.h                     |   1 +
linux-headers/linux/psp-sev.h                 |  21 ++-
linux-headers/linux/stddef.h                  |   2 +
linux-headers/linux/vfio.h                    |  30 ++--
scripts/update-linux-headers.sh               |   2 +-
target/s390x/ioinst.c                         |  11 +-
41 files changed, 440 insertions(+), 39 deletions(-)
create mode 100644 hw/vfio/ap-stub.c
[PATCH v7 0/6] Report vfio-ap configuration changes
Posted by Rorie Reyes 7 months, 3 weeks ago
Changelog:
v7:
- Dropped initial commit for linux-header file vfio.h since I created two new commits
to address the changes made in v6
- Moved patches 6 and 7 to the beginning of the series after dropping the first patch
   - Because I dropped the initial commit for linux-header file vfio.h, I had to add 
VFIO_AP_CFG_CHG_IRQ_INDEX
- Resyncing latest to v6.15-rc3
- Still need Thomas Huth's review of v5 changes for patch 6/6

v6:
- Updating the update-linux-headers script to address kernel commit change 8a14
- Update headers to retrieve uapi information for vfio-ap for update to Linux v6.15-rc1
- Still need Thomas Huth's review of v5 changes for patch 7/7 (see below)

v5:
- configuring using the '-without-default-devices' fails when building the code
- created a stub file for functions ap_chsc_sei_nt0_get_event and ap_chsc_sei_nt0_have_event
- add if_false for 'CONFIG_VFIO_AP' use ap-stub.c in meson.build
- add the use of the stub file to MAINTAINERS since it's a new file

v4:
- allocating cfg_chg_event before inserting into the queue
- calling nt0_have_event in if loop to check if there are any
elemenets in the queue, then calling QTAILQ_FIRST when the check
passes
- moving memset() after the check

v3:
- changes that were made to patch 3/5 should have been made in
patch 2/5

v2:
- removed warnings that weren't needed
- added unregister function
- removed whitelines
- changed variable names for consistency
- removed rc variable and returning 1 or 0 outright
- reversed logics for if statements
- using g_free() instead of free()
- replaced hardcoded numeric values by defining them with #define
in the header

--------------------------------------------------------------------------
This patch series creates and registers a handler that is called when
userspace is notified by the kernel that a guest's AP configuration has
changed. The handler in turn notifies the guest that its AP configuration
has changed. This allows the guest to immediately respond to AP
configuration changes rather than relying on polling or some other
inefficient mechanism for detecting config changes.

Rorie Reyes (6):
  linux-header: update-linux-header script changes
  linux-headers: Update to Linux v6.15-rc3
  hw/vfio/ap: notification handler for AP config changed event
  hw/vfio/ap: store object indicating AP config changed in a queue
  hw/vfio/ap: Storing event information for an AP configuration change
    event
  s390: implementing CHSC SEI for AP config change

 MAINTAINERS                                   |   1 +
 hw/vfio/ap-stub.c                             |  23 ++++
 hw/vfio/ap.c                                  |  82 +++++++++++
 hw/vfio/meson.build                           |   1 +
 include/hw/s390x/ap-bridge.h                  |  22 +++
 include/standard-headers/asm-x86/setup_data.h |   4 +-
 include/standard-headers/drm/drm_fourcc.h     |  41 ++++++
 include/standard-headers/linux/const.h        |   2 +-
 include/standard-headers/linux/ethtool.h      |  22 +++
 include/standard-headers/linux/fuse.h         |  12 +-
 include/standard-headers/linux/pci_regs.h     |  13 +-
 include/standard-headers/linux/virtio_net.h   |  13 ++
 include/standard-headers/linux/virtio_snd.h   |   2 +-
 linux-headers/asm-arm64/kvm.h                 |  11 ++
 linux-headers/asm-arm64/unistd_64.h           |   1 +
 linux-headers/asm-generic/mman-common.h       |   1 +
 linux-headers/asm-generic/unistd.h            |   4 +-
 linux-headers/asm-loongarch/unistd_64.h       |   1 +
 linux-headers/asm-mips/unistd_n32.h           |   1 +
 linux-headers/asm-mips/unistd_n64.h           |   1 +
 linux-headers/asm-mips/unistd_o32.h           |   1 +
 linux-headers/asm-powerpc/unistd_32.h         |   1 +
 linux-headers/asm-powerpc/unistd_64.h         |   1 +
 linux-headers/asm-riscv/kvm.h                 |   2 +
 linux-headers/asm-riscv/unistd_32.h           |   1 +
 linux-headers/asm-riscv/unistd_64.h           |   1 +
 linux-headers/asm-s390/unistd_32.h            |   1 +
 linux-headers/asm-s390/unistd_64.h            |   1 +
 linux-headers/asm-x86/kvm.h                   |   3 +
 linux-headers/asm-x86/unistd_32.h             |   1 +
 linux-headers/asm-x86/unistd_64.h             |   1 +
 linux-headers/asm-x86/unistd_x32.h            |   1 +
 linux-headers/linux/bits.h                    |   8 +-
 linux-headers/linux/const.h                   |   2 +-
 linux-headers/linux/iommufd.h                 | 129 +++++++++++++++++-
 linux-headers/linux/kvm.h                     |   1 +
 linux-headers/linux/psp-sev.h                 |  21 ++-
 linux-headers/linux/stddef.h                  |   2 +
 linux-headers/linux/vfio.h                    |  30 ++--
 scripts/update-linux-headers.sh               |   2 +-
 target/s390x/ioinst.c                         |  11 +-
 41 files changed, 440 insertions(+), 39 deletions(-)
 create mode 100644 hw/vfio/ap-stub.c

-- 
2.48.1
Re: [PATCH v7 0/6] Report vfio-ap configuration changes
Posted by Cédric Le Goater 7 months, 3 weeks ago
On 4/25/25 07:23, Rorie Reyes wrote:
> Changelog:
> v7:
> - Dropped initial commit for linux-header file vfio.h since I created two new commits
> to address the changes made in v6
> - Moved patches 6 and 7 to the beginning of the series after dropping the first patch
>     - Because I dropped the initial commit for linux-header file vfio.h, I had to add
> VFIO_AP_CFG_CHG_IRQ_INDEX
> - Resyncing latest to v6.15-rc3
> - Still need Thomas Huth's review of v5 changes for patch 6/6

I checked the build without default devices.

Applied to vfio-next.

Thanks,

C.
Re: [PATCH v7 0/6] Report vfio-ap configuration changes
Posted by Cédric Le Goater 7 months, 2 weeks ago
On 4/28/25 23:29, Cédric Le Goater wrote:
> On 4/25/25 07:23, Rorie Reyes wrote:
>> Changelog:
>> v7:
>> - Dropped initial commit for linux-header file vfio.h since I created two new commits
>> to address the changes made in v6
>> - Moved patches 6 and 7 to the beginning of the series after dropping the first patch
>>     - Because I dropped the initial commit for linux-header file vfio.h, I had to add
>> VFIO_AP_CFG_CHG_IRQ_INDEX
>> - Resyncing latest to v6.15-rc3
>> - Still need Thomas Huth's review of v5 changes for patch 6/6
> 
> I checked the build without default devices.
> 
> Applied to vfio-next.

I kept patch 1,2 in vfio-next and dropped 3-6 because of the build break.

C.


Re: [PATCH v7 0/6] Report vfio-ap configuration changes
Posted by Rorie Reyes 7 months, 2 weeks ago
On 5/6/25 3:00 AM, Cédric Le Goater wrote:
> On 4/28/25 23:29, Cédric Le Goater wrote:
>> On 4/25/25 07:23, Rorie Reyes wrote:
>>> Changelog:
>>> v7:
>>> - Dropped initial commit for linux-header file vfio.h since I 
>>> created two new commits
>>> to address the changes made in v6
>>> - Moved patches 6 and 7 to the beginning of the series after 
>>> dropping the first patch
>>>     - Because I dropped the initial commit for linux-header file 
>>> vfio.h, I had to add
>>> VFIO_AP_CFG_CHG_IRQ_INDEX
>>> - Resyncing latest to v6.15-rc3
>>> - Still need Thomas Huth's review of v5 changes for patch 6/6
>>
>> I checked the build without default devices.
>>
>> Applied to vfio-next.
>
> I kept patch 1,2 in vfio-next and dropped 3-6 because of the build break.
>
> C.
>
No problem. I'm currently working on a fix for the windows build fail

Re: [PATCH v7 0/6] Report vfio-ap configuration changes
Posted by Rorie Reyes 7 months, 3 weeks ago
On 4/28/25 5:29 PM, Cédric Le Goater wrote:
> On 4/25/25 07:23, Rorie Reyes wrote:
>> Changelog:
>> v7:
>> - Dropped initial commit for linux-header file vfio.h since I created 
>> two new commits
>> to address the changes made in v6
>> - Moved patches 6 and 7 to the beginning of the series after dropping 
>> the first patch
>>     - Because I dropped the initial commit for linux-header file 
>> vfio.h, I had to add
>> VFIO_AP_CFG_CHG_IRQ_INDEX
>> - Resyncing latest to v6.15-rc3
>> - Still need Thomas Huth's review of v5 changes for patch 6/6
>
> I checked the build without default devices.
>
> Applied to vfio-next.
>
> Thanks,
>
> C.
>
>
Hey Cedric, are my QEMU patches considered good for this series?

Re: [PATCH v7 0/6] Report vfio-ap configuration changes
Posted by Cédric Le Goater 7 months, 2 weeks ago
On 4/30/25 22:55, Rorie Reyes wrote:
> 
> On 4/28/25 5:29 PM, Cédric Le Goater wrote:
>> On 4/25/25 07:23, Rorie Reyes wrote:
>>> Changelog:
>>> v7:
>>> - Dropped initial commit for linux-header file vfio.h since I created two new commits
>>> to address the changes made in v6
>>> - Moved patches 6 and 7 to the beginning of the series after dropping the first patch
>>>     - Because I dropped the initial commit for linux-header file vfio.h, I had to add
>>> VFIO_AP_CFG_CHG_IRQ_INDEX
>>> - Resyncing latest to v6.15-rc3
>>> - Still need Thomas Huth's review of v5 changes for patch 6/6
>>
>> I checked the build without default devices.
>>
>> Applied to vfio-next.
>>
>> Thanks,
>>
>> C.
>>
>>
> Hey Cedric, are my QEMU patches considered good for this series?

AFAICT, yes. They are reviewed and they build correctly.

I will let you address the downstream process.

Thanks,

C.




  


Re: [PATCH v7 0/6] Report vfio-ap configuration changes
Posted by Cédric Le Goater 7 months, 2 weeks ago
On 5/1/25 09:40, Cédric Le Goater wrote:
> On 4/30/25 22:55, Rorie Reyes wrote:
>>
>> On 4/28/25 5:29 PM, Cédric Le Goater wrote:
>>> On 4/25/25 07:23, Rorie Reyes wrote:
>>>> Changelog:
>>>> v7:
>>>> - Dropped initial commit for linux-header file vfio.h since I created two new commits
>>>> to address the changes made in v6
>>>> - Moved patches 6 and 7 to the beginning of the series after dropping the first patch
>>>>     - Because I dropped the initial commit for linux-header file vfio.h, I had to add
>>>> VFIO_AP_CFG_CHG_IRQ_INDEX
>>>> - Resyncing latest to v6.15-rc3
>>>> - Still need Thomas Huth's review of v5 changes for patch 6/6
>>>
>>> I checked the build without default devices.
>>>
>>> Applied to vfio-next.
>>>
>>> Thanks,
>>>
>>> C.
>>>
>>>
>> Hey Cedric, are my QEMU patches considered good for this series?
> 
> AFAICT, yes. They are reviewed and they build correctly.

Nope. The windows build fails. See :

   https://gitlab.com/legoater/qemu/-/jobs/9927170034

Please fix in v8.

Thanks,

C.