[v2] include: Remove "exec/exec-all.h"

[PATCH v2 08/13] target/hexagon: Include missing 'accel/tcg/getpc.h'

Posted by Philippe Mathieu-Daudé 6 months, 3 weeks ago

Since the macros.h headers call GETPC(), they need to
include "accel/tcg/getpc.h", which defines it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/hexagon/macros.h       | 1 +
 target/hexagon/mmvec/macros.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
index ee3d4c88e7b..6f82277a415 100644
--- a/target/hexagon/macros.h
+++ b/target/hexagon/macros.h
@@ -21,6 +21,7 @@
 #include "cpu.h"
 #include "hex_regs.h"
 #include "reg_fields.h"
+#include "accel/tcg/getpc.h"
 
 #define GET_FIELD(FIELD, REGIN) \
     fEXTRACTU_BITS(REGIN, reg_field_info[FIELD].width, \
diff --git a/target/hexagon/mmvec/macros.h b/target/hexagon/mmvec/macros.h
index bcd4a1e8973..c1a88392c05 100644
--- a/target/hexagon/mmvec/macros.h
+++ b/target/hexagon/mmvec/macros.h
@@ -21,6 +21,7 @@
 #include "qemu/host-utils.h"
 #include "arch.h"
 #include "mmvec/system_ext_mmvec.h"
+#include "accel/tcg/getpc.h"
 
 #ifndef QEMU_GENERATE
 #define VdV      (*(MMVector *restrict)(VdV_void))
-- 
2.47.1

Re: [PATCH v2 08/13] target/hexagon: Include missing 'accel/tcg/getpc.h'

Posted by Brian Cain 6 months, 3 weeks ago

On 4/24/2025 4:46 AM, Philippe Mathieu-Daudé wrote:
> Since the macros.h headers call GETPC(), they need to
> include "accel/tcg/getpc.h", which defines it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---


Reviewed-by: Brian Cain <brian.cain@oss.qualcomm.com>


>   target/hexagon/macros.h       | 1 +
>   target/hexagon/mmvec/macros.h | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
> index ee3d4c88e7b..6f82277a415 100644
> --- a/target/hexagon/macros.h
> +++ b/target/hexagon/macros.h
> @@ -21,6 +21,7 @@
>   #include "cpu.h"
>   #include "hex_regs.h"
>   #include "reg_fields.h"
> +#include "accel/tcg/getpc.h"
>   
>   #define GET_FIELD(FIELD, REGIN) \
>       fEXTRACTU_BITS(REGIN, reg_field_info[FIELD].width, \
> diff --git a/target/hexagon/mmvec/macros.h b/target/hexagon/mmvec/macros.h
> index bcd4a1e8973..c1a88392c05 100644
> --- a/target/hexagon/mmvec/macros.h
> +++ b/target/hexagon/mmvec/macros.h
> @@ -21,6 +21,7 @@
>   #include "qemu/host-utils.h"
>   #include "arch.h"
>   #include "mmvec/system_ext_mmvec.h"
> +#include "accel/tcg/getpc.h"
>   
>   #ifndef QEMU_GENERATE
>   #define VdV      (*(MMVector *restrict)(VdV_void))

Re: [PATCH v2 08/13] target/hexagon: Include missing 'accel/tcg/getpc.h'

Posted by Mark Cave-Ayland 6 months, 3 weeks ago

On 24/04/2025 10:46, Philippe Mathieu-Daudé wrote:

> Since the macros.h headers call GETPC(), they need to
> include "accel/tcg/getpc.h", which defines it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/hexagon/macros.h       | 1 +
>   target/hexagon/mmvec/macros.h | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
> index ee3d4c88e7b..6f82277a415 100644
> --- a/target/hexagon/macros.h
> +++ b/target/hexagon/macros.h
> @@ -21,6 +21,7 @@
>   #include "cpu.h"
>   #include "hex_regs.h"
>   #include "reg_fields.h"
> +#include "accel/tcg/getpc.h"
>   
>   #define GET_FIELD(FIELD, REGIN) \
>       fEXTRACTU_BITS(REGIN, reg_field_info[FIELD].width, \
> diff --git a/target/hexagon/mmvec/macros.h b/target/hexagon/mmvec/macros.h
> index bcd4a1e8973..c1a88392c05 100644
> --- a/target/hexagon/mmvec/macros.h
> +++ b/target/hexagon/mmvec/macros.h
> @@ -21,6 +21,7 @@
>   #include "qemu/host-utils.h"
>   #include "arch.h"
>   #include "mmvec/system_ext_mmvec.h"
> +#include "accel/tcg/getpc.h"
>   
>   #ifndef QEMU_GENERATE
>   #define VdV      (*(MMVector *restrict)(VdV_void))

Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>


ATB,

Mark.