tests/functional/test_ppc64_pseries: Skip test_ppc64_linux_smt_boot if necessary

[PATCH] tests/functional/test_ppc64_pseries: Skip test_ppc64_linux_smt_boot if necessary

Thomas Huth posted 1 patch 6 months, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250424085426.663377-1-thuth@redhat.com

Maintainers: Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>

tests/functional/test_ppc64_pseries.py | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] tests/functional/test_ppc64_pseries: Skip test_ppc64_linux_smt_boot if necessary

Posted by Thomas Huth 6 months, 3 weeks ago

From: Thomas Huth <thuth@redhat.com>

The test_ppc64_linux_smt_boot function lacks the set_machine('pseries'),
so this test is currently failing in case the 'pseries' machine has not
been compiled into the binary. Add the check now to fix it.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/test_ppc64_pseries.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/functional/test_ppc64_pseries.py b/tests/functional/test_ppc64_pseries.py
index fdc404ed033..67057934e8d 100755
--- a/tests/functional/test_ppc64_pseries.py
+++ b/tests/functional/test_ppc64_pseries.py
@@ -63,6 +63,7 @@ def test_ppc64_linux_hpt_smp_boot(self):
         wait_for_console_pattern(self, self.good_message, self.panic_message)
 
     def test_ppc64_linux_smt_boot(self):
+        self.set_machine('pseries')
         self.vm.add_args('-smp', '4,threads=4')
         self.do_test_ppc64_linux_boot()
         console_pattern = 'CPU maps initialized for 4 threads per core'
-- 
2.49.0

Re: [PATCH] tests/functional/test_ppc64_pseries: Skip test_ppc64_linux_smt_boot if necessary

Posted by Harsh Prateek Bora 6 months, 3 weeks ago


On 4/24/25 14:24, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> The test_ppc64_linux_smt_boot function lacks the set_machine('pseries'),
> so this test is currently failing in case the 'pseries' machine has not
> been compiled into the binary. Add the check now to fix it.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

> ---
>   tests/functional/test_ppc64_pseries.py | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/functional/test_ppc64_pseries.py b/tests/functional/test_ppc64_pseries.py
> index fdc404ed033..67057934e8d 100755
> --- a/tests/functional/test_ppc64_pseries.py
> +++ b/tests/functional/test_ppc64_pseries.py
> @@ -63,6 +63,7 @@ def test_ppc64_linux_hpt_smp_boot(self):
>           wait_for_console_pattern(self, self.good_message, self.panic_message)
>   
>       def test_ppc64_linux_smt_boot(self):
> +        self.set_machine('pseries')
>           self.vm.add_args('-smp', '4,threads=4')
>           self.do_test_ppc64_linux_boot()
>           console_pattern = 'CPU maps initialized for 4 threads per core'