hw/intc/i8259: Remove unused DEBUG_PIC define

[PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define

Posted by BALATON Zoltan 6 months, 3 weeks ago

The debug printfs were converted to traces so this define is now unused.

Fixes: 0880a87300 (i8259: convert DPRINTFs into trace)
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/intc/i8259.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
index d88b20f40b..6a204f7d21 100644
--- a/hw/intc/i8259.c
+++ b/hw/intc/i8259.c
@@ -32,10 +32,7 @@
 #include "trace.h"
 #include "qom/object.h"
 
-/* debug PIC */
-//#define DEBUG_PIC
-
-//#define DEBUG_IRQ_LATENCY
+/*#define DEBUG_IRQ_LATENCY*/
 
 #define TYPE_I8259 "isa-i8259"
 typedef struct PICClass PICClass;
-- 
2.41.3

Re: [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define

Posted by Philippe Mathieu-Daudé 6 months, 3 weeks ago

On 23/4/25 12:11, BALATON Zoltan wrote:
> The debug printfs were converted to traces so this define is now unused.
> 
> Fixes: 0880a87300 (i8259: convert DPRINTFs into trace)
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/intc/i8259.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Patch queued, thanks.

Re: [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define

Posted by Philippe Mathieu-Daudé 6 months, 3 weeks ago

On 23/4/25 12:11, BALATON Zoltan wrote:
> The debug printfs were converted to traces so this define is now unused.
> 
> Fixes: 0880a87300 (i8259: convert DPRINTFs into trace)
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/intc/i8259.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

and queued, thanks!

Re: [PATCH] hw/intc/i8259: Remove unused DEBUG_PIC define

Posted by Mark Cave-Ayland 6 months, 3 weeks ago

On 23/04/2025 11:11, BALATON Zoltan wrote:

> The debug printfs were converted to traces so this define is now unused.
> 
> Fixes: 0880a87300 (i8259: convert DPRINTFs into trace)
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/intc/i8259.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
> index d88b20f40b..6a204f7d21 100644
> --- a/hw/intc/i8259.c
> +++ b/hw/intc/i8259.c
> @@ -32,10 +32,7 @@
>   #include "trace.h"
>   #include "qom/object.h"
>   
> -/* debug PIC */
> -//#define DEBUG_PIC
> -
> -//#define DEBUG_IRQ_LATENCY
> +/*#define DEBUG_IRQ_LATENCY*/
>   
>   #define TYPE_I8259 "isa-i8259"
>   typedef struct PICClass PICClass;

Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>


ATB,

Mark.