1. Patchew
  2. QEMU
  3. [PATCH v5 00/11] Support vbootrom for AST2700
  4. View patch

[PATCH v5 03/11] hw/arm/aspeed: Add vbootrom support on AST2700 EVB machines

Jamin Lin via posted 11 patches 6 months, 3 weeks ago
There is a newer version of this series
[PATCH v5 03/11] hw/arm/aspeed: Add vbootrom support on AST2700 EVB machines
Posted by Jamin Lin via 6 months, 3 weeks ago 
Introduce a new "vbootrom" field in the AspeedMachineClass to indicate whether
a machine supports the virtual boot ROM region.

Set this field to true by default for the AST2700-A0 and AST2700-A1 EVB
machines.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Nabih Estefan <nabihestefan@google.com>
Tested-by: Nabih Estefan <nabihestefan@google.com>
---
 include/hw/arm/aspeed.h | 1 +
 hw/arm/aspeed.c         | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
index 9cae45a1c9..973277bea6 100644
--- a/include/hw/arm/aspeed.h
+++ b/include/hw/arm/aspeed.h
@@ -40,6 +40,7 @@ struct AspeedMachineClass {
     void (*i2c_init)(AspeedMachineState *bmc);
     uint32_t uart_default;
     bool sdhci_wp_inverted;
+    bool vbootrom;
 };
 
 
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 82f42582fa..e852bbc4cb 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -1689,6 +1689,7 @@ static void aspeed_machine_ast2700a0_evb_class_init(ObjectClass *oc, void *data)
     amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON | ASPEED_MAC2_ON;
     amc->uart_default = ASPEED_DEV_UART12;
     amc->i2c_init  = ast2700_evb_i2c_init;
+    amc->vbootrom = true;
     mc->auto_create_sdcard = true;
     mc->default_ram_size = 1 * GiB;
     aspeed_machine_class_init_cpus_defaults(mc);
@@ -1709,6 +1710,7 @@ static void aspeed_machine_ast2700a1_evb_class_init(ObjectClass *oc, void *data)
     amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON | ASPEED_MAC2_ON;
     amc->uart_default = ASPEED_DEV_UART12;
     amc->i2c_init  = ast2700_evb_i2c_init;
+    amc->vbootrom = true;
     mc->auto_create_sdcard = true;
     mc->default_ram_size = 1 * GiB;
     aspeed_machine_class_init_cpus_defaults(mc);
-- 
2.43.0
Re: [PATCH v5 03/11] hw/arm/aspeed: Add vbootrom support on AST2700 EVB machines
Posted by Cédric Le Goater 6 months, 3 weeks ago 
On 4/23/25 09:23, Jamin Lin wrote:
> Introduce a new "vbootrom" field in the AspeedMachineClass to indicate whether
> a machine supports the virtual boot ROM region.
> 
> Set this field to true by default for the AST2700-A0 and AST2700-A1 EVB
> machines.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> Reviewed-by: Nabih Estefan <nabihestefan@google.com>
> Tested-by: Nabih Estefan <nabihestefan@google.com>


I would merge this patch in patch 6.


Thanks,

C.



> ---
>   include/hw/arm/aspeed.h | 1 +
>   hw/arm/aspeed.c         | 2 ++
>   2 files changed, 3 insertions(+)
> 
> diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
> index 9cae45a1c9..973277bea6 100644
> --- a/include/hw/arm/aspeed.h
> +++ b/include/hw/arm/aspeed.h
> @@ -40,6 +40,7 @@ struct AspeedMachineClass {
>       void (*i2c_init)(AspeedMachineState *bmc);
>       uint32_t uart_default;
>       bool sdhci_wp_inverted;
> +    bool vbootrom;
>   };
>   
>   
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 82f42582fa..e852bbc4cb 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -1689,6 +1689,7 @@ static void aspeed_machine_ast2700a0_evb_class_init(ObjectClass *oc, void *data)
>       amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON | ASPEED_MAC2_ON;
>       amc->uart_default = ASPEED_DEV_UART12;
>       amc->i2c_init  = ast2700_evb_i2c_init;
> +    amc->vbootrom = true;
>       mc->auto_create_sdcard = true;
>       mc->default_ram_size = 1 * GiB;
>       aspeed_machine_class_init_cpus_defaults(mc);
> @@ -1709,6 +1710,7 @@ static void aspeed_machine_ast2700a1_evb_class_init(ObjectClass *oc, void *data)
>       amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON | ASPEED_MAC2_ON;
>       amc->uart_default = ASPEED_DEV_UART12;
>       amc->i2c_init  = ast2700_evb_i2c_init;
> +    amc->vbootrom = true;
>       mc->auto_create_sdcard = true;
>       mc->default_ram_size = 1 * GiB;
>       aspeed_machine_class_init_cpus_defaults(mc);
RE: [PATCH v5 03/11] hw/arm/aspeed: Add vbootrom support on AST2700 EVB machines
Posted by Jamin Lin 6 months, 3 weeks ago 
Hi Cedric,

> Subject: Re: [PATCH v5 03/11] hw/arm/aspeed: Add vbootrom support on
> AST2700 EVB machines
> 
> On 4/23/25 09:23, Jamin Lin wrote:
> > Introduce a new "vbootrom" field in the AspeedMachineClass to indicate
> > whether a machine supports the virtual boot ROM region.
> >
> > Set this field to true by default for the AST2700-A0 and AST2700-A1
> > EVB machines.
> >
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > Reviewed-by: Nabih Estefan <nabihestefan@google.com>
> > Tested-by: Nabih Estefan <nabihestefan@google.com>
> 
> 
> I would merge this patch in patch 6.
> 
Thanks for suggestion.
Will merge this in patch 6
Jamin
> 
> Thanks,
> 
> C.
> 
> 
> 
> > ---
> >   include/hw/arm/aspeed.h | 1 +
> >   hw/arm/aspeed.c         | 2 ++
> >   2 files changed, 3 insertions(+)
> >
> > diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h index
> > 9cae45a1c9..973277bea6 100644
> > --- a/include/hw/arm/aspeed.h
> > +++ b/include/hw/arm/aspeed.h
> > @@ -40,6 +40,7 @@ struct AspeedMachineClass {
> >       void (*i2c_init)(AspeedMachineState *bmc);
> >       uint32_t uart_default;
> >       bool sdhci_wp_inverted;
> > +    bool vbootrom;
> >   };
> >
> >
> > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index
> > 82f42582fa..e852bbc4cb 100644
> > --- a/hw/arm/aspeed.c
> > +++ b/hw/arm/aspeed.c
> > @@ -1689,6 +1689,7 @@ static void
> aspeed_machine_ast2700a0_evb_class_init(ObjectClass *oc, void *data)
> >       amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON |
> ASPEED_MAC2_ON;
> >       amc->uart_default = ASPEED_DEV_UART12;
> >       amc->i2c_init  = ast2700_evb_i2c_init;
> > +    amc->vbootrom = true;
> >       mc->auto_create_sdcard = true;
> >       mc->default_ram_size = 1 * GiB;
> >       aspeed_machine_class_init_cpus_defaults(mc);
> > @@ -1709,6 +1710,7 @@ static void
> aspeed_machine_ast2700a1_evb_class_init(ObjectClass *oc, void *data)
> >       amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON |
> ASPEED_MAC2_ON;
> >       amc->uart_default = ASPEED_DEV_UART12;
> >       amc->i2c_init  = ast2700_evb_i2c_init;
> > +    amc->vbootrom = true;
> >       mc->auto_create_sdcard = true;
> >       mc->default_ram_size = 1 * GiB;
> >       aspeed_machine_class_init_cpus_defaults(mc);

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.