1. Patchew
  2. QEMU
  3. [PATCH v1 0/3] Update to test new ASPEED SDK version
  4. View patch

[PATCH v1 3/3] tests/functional/aspeed: Update test ASPEED SDK v03.00 for AST1030

Jamin Lin via posted 3 patches 6 months, 3 weeks ago
There is a newer version of this series
[PATCH v1 3/3] tests/functional/aspeed: Update test ASPEED SDK v03.00 for AST1030
Posted by Jamin Lin via 6 months, 3 weeks ago 
Updated test to target SDK version v03.00.
Removed redundant test case to simplify validation.
Cleaned up unsupported shell commands.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 tests/functional/test_arm_aspeed_ast1030.py | 40 ++++-----------------
 1 file changed, 7 insertions(+), 33 deletions(-)

diff --git a/tests/functional/test_arm_aspeed_ast1030.py b/tests/functional/test_arm_aspeed_ast1030.py
index d45d9f7c1c..dafa1d24cb 100755
--- a/tests/functional/test_arm_aspeed_ast1030.py
+++ b/tests/functional/test_arm_aspeed_ast1030.py
@@ -12,36 +12,17 @@
 
 class AST1030Machine(LinuxKernelTest):
 
-    ASSET_ZEPHYR_1_04 = Asset(
+    ASSET_ZEPHYR_3_00 = Asset(
         ('https://github.com/AspeedTech-BMC'
-         '/zephyr/releases/download/v00.01.04/ast1030-evb-demo.zip'),
-        '4ac6210adcbc61294927918707c6762483fd844dde5e07f3ba834ad1f91434d3')
+         '/zephyr/releases/download/v00.03.00/ast1030-evb-demo.zip'),
+        '37fe3ecd4a1b9d620971a15b96492a81093435396eeac69b6f3e384262ff555f')
 
-    def test_ast1030_zephyros_1_04(self):
-        self.set_machine('ast1030-evb')
-
-        kernel_name = "ast1030-evb-demo/zephyr.elf"
-        kernel_file = self.archive_extract(
-            self.ASSET_ZEPHYR_1_04, member=kernel_name)
-
-        self.vm.set_console()
-        self.vm.add_args('-kernel', kernel_file, '-nographic')
-        self.vm.launch()
-        self.wait_for_console_pattern("Booting Zephyr OS")
-        exec_command_and_wait_for_pattern(self, "help",
-                                          "Available commands")
-
-    ASSET_ZEPHYR_1_07 = Asset(
-        ('https://github.com/AspeedTech-BMC'
-         '/zephyr/releases/download/v00.01.07/ast1030-evb-demo.zip'),
-        'ad52e27959746988afaed8429bf4e12ab988c05c4d07c9d90e13ec6f7be4574c')
-
-    def test_ast1030_zephyros_1_07(self):
+    def test_ast1030_zephyros_3_00(self):
         self.set_machine('ast1030-evb')
 
         kernel_name = "ast1030-evb-demo/zephyr.bin"
         kernel_file = self.archive_extract(
-            self.ASSET_ZEPHYR_1_07, member=kernel_name)
+            self.ASSET_ZEPHYR_3_00, member=kernel_name)
 
         self.vm.set_console()
         self.vm.add_args('-kernel', kernel_file, '-nographic')
@@ -49,17 +30,10 @@ def test_ast1030_zephyros_1_07(self):
         self.wait_for_console_pattern("Booting Zephyr OS")
         for shell_cmd in [
                 'kernel stacks',
-                'otp info conf',
-                'otp info scu',
                 'hwinfo devid',
                 'crypto aes256_cbc_vault',
-                'random get',
-                'jtag JTAG1 sw_xfer high TMS',
-                'adc ADC0 resolution 12',
-                'adc ADC0 read 42',
-                'adc ADC1 read 69',
-                'i2c scan I2C_0',
-                'i3c attach I3C_0',
+                'jtag jtag@7e6e4100 sw_xfer high TMS',
+                'iic scan i2c@7e7b0080',
                 'hash test',
                 'kernel uptime',
                 'kernel reboot warm',
-- 
2.43.0
Re: [PATCH v1 3/3] tests/functional/aspeed: Update test ASPEED SDK v03.00 for AST1030
Posted by Cédric Le Goater 6 months, 3 weeks ago 
On 4/22/25 11:15, Jamin Lin wrote:
> Updated test to target SDK version v03.00.
> Removed redundant test case to simplify validation.
> Cleaned up unsupported shell commands.

Were some commands removed from SDK v03.00 ? Testing different
zephyr versions might be interesting in that case, like it would
be for Linux too.

Thanks,

C.




> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   tests/functional/test_arm_aspeed_ast1030.py | 40 ++++-----------------
>   1 file changed, 7 insertions(+), 33 deletions(-)
> 
> diff --git a/tests/functional/test_arm_aspeed_ast1030.py b/tests/functional/test_arm_aspeed_ast1030.py
> index d45d9f7c1c..dafa1d24cb 100755
> --- a/tests/functional/test_arm_aspeed_ast1030.py
> +++ b/tests/functional/test_arm_aspeed_ast1030.py
> @@ -12,36 +12,17 @@
>   
>   class AST1030Machine(LinuxKernelTest):
>   
> -    ASSET_ZEPHYR_1_04 = Asset(
> +    ASSET_ZEPHYR_3_00 = Asset(
>           ('https://github.com/AspeedTech-BMC'
> -         '/zephyr/releases/download/v00.01.04/ast1030-evb-demo.zip'),
> -        '4ac6210adcbc61294927918707c6762483fd844dde5e07f3ba834ad1f91434d3')
> +         '/zephyr/releases/download/v00.03.00/ast1030-evb-demo.zip'),
> +        '37fe3ecd4a1b9d620971a15b96492a81093435396eeac69b6f3e384262ff555f')
>   
> -    def test_ast1030_zephyros_1_04(self):
> -        self.set_machine('ast1030-evb')
> -
> -        kernel_name = "ast1030-evb-demo/zephyr.elf"
> -        kernel_file = self.archive_extract(
> -            self.ASSET_ZEPHYR_1_04, member=kernel_name)
> -
> -        self.vm.set_console()
> -        self.vm.add_args('-kernel', kernel_file, '-nographic')
> -        self.vm.launch()
> -        self.wait_for_console_pattern("Booting Zephyr OS")
> -        exec_command_and_wait_for_pattern(self, "help",
> -                                          "Available commands")
> -
> -    ASSET_ZEPHYR_1_07 = Asset(
> -        ('https://github.com/AspeedTech-BMC'
> -         '/zephyr/releases/download/v00.01.07/ast1030-evb-demo.zip'),
> -        'ad52e27959746988afaed8429bf4e12ab988c05c4d07c9d90e13ec6f7be4574c')
> -
> -    def test_ast1030_zephyros_1_07(self):
> +    def test_ast1030_zephyros_3_00(self):
>           self.set_machine('ast1030-evb')
>   
>           kernel_name = "ast1030-evb-demo/zephyr.bin"
>           kernel_file = self.archive_extract(
> -            self.ASSET_ZEPHYR_1_07, member=kernel_name)
> +            self.ASSET_ZEPHYR_3_00, member=kernel_name)
>   
>           self.vm.set_console()
>           self.vm.add_args('-kernel', kernel_file, '-nographic')
> @@ -49,17 +30,10 @@ def test_ast1030_zephyros_1_07(self):
>           self.wait_for_console_pattern("Booting Zephyr OS")
>           for shell_cmd in [
>                   'kernel stacks',
> -                'otp info conf',
> -                'otp info scu',
>                   'hwinfo devid',
>                   'crypto aes256_cbc_vault',
> -                'random get',
> -                'jtag JTAG1 sw_xfer high TMS',
> -                'adc ADC0 resolution 12',
> -                'adc ADC0 read 42',
> -                'adc ADC1 read 69',
> -                'i2c scan I2C_0',
> -                'i3c attach I3C_0',
> +                'jtag jtag@7e6e4100 sw_xfer high TMS',
> +                'iic scan i2c@7e7b0080',
>                   'hash test',
>                   'kernel uptime',
>                   'kernel reboot warm',
RE: [PATCH v1 3/3] tests/functional/aspeed: Update test ASPEED SDK v03.00 for AST1030
Posted by Jamin Lin 6 months, 3 weeks ago 
Hi Philip, Cedric, 

> 
> On 4/22/25 11:15, Jamin Lin wrote:
> > Updated test to target SDK version v03.00.
> > Removed redundant test case to simplify validation.
> > Cleaned up unsupported shell commands.
> 
> Were some commands removed from SDK v03.00 ? Testing different zephyr

Thanks for review and suggestion.
Yes, some commands have been removed in the pre-built image of SDK v03.00.
The changes in v1 reduce the overall test coverage.
I will send a v2 patch to retain the test_ast1030_zephyros_1_07 test case and 
update test_ast1030_zephyros_1_04 to use SDK v03.00.

Thanks-Jamin

> versions might be interesting in that case, like it would be for Linux too.
> 
> Thanks,
> 
> C.
> 
> 
> 
> 
> >
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > ---
> >   tests/functional/test_arm_aspeed_ast1030.py | 40 ++++-----------------
> >   1 file changed, 7 insertions(+), 33 deletions(-)
> >
> > diff --git a/tests/functional/test_arm_aspeed_ast1030.py
> > b/tests/functional/test_arm_aspeed_ast1030.py
> > index d45d9f7c1c..dafa1d24cb 100755
> > --- a/tests/functional/test_arm_aspeed_ast1030.py
> > +++ b/tests/functional/test_arm_aspeed_ast1030.py
> > @@ -12,36 +12,17 @@
> >
> >   class AST1030Machine(LinuxKernelTest):
> >
> > -    ASSET_ZEPHYR_1_04 = Asset(
> > +    ASSET_ZEPHYR_3_00 = Asset(
> >           ('https://github.com/AspeedTech-BMC'
> > -         '/zephyr/releases/download/v00.01.04/ast1030-evb-demo.zip'),
> > -
> '4ac6210adcbc61294927918707c6762483fd844dde5e07f3ba834ad1f91434d3')
> > +         '/zephyr/releases/download/v00.03.00/ast1030-evb-demo.zip'),
> > +
> > +
> '37fe3ecd4a1b9d620971a15b96492a81093435396eeac69b6f3e384262ff555f')
> >
> > -    def test_ast1030_zephyros_1_04(self):
> > -        self.set_machine('ast1030-evb')
> > -
> > -        kernel_name = "ast1030-evb-demo/zephyr.elf"
> > -        kernel_file = self.archive_extract(
> > -            self.ASSET_ZEPHYR_1_04, member=kernel_name)
> > -
> > -        self.vm.set_console()
> > -        self.vm.add_args('-kernel', kernel_file, '-nographic')
> > -        self.vm.launch()
> > -        self.wait_for_console_pattern("Booting Zephyr OS")
> > -        exec_command_and_wait_for_pattern(self, "help",
> > -                                          "Available commands")
> > -
> > -    ASSET_ZEPHYR_1_07 = Asset(
> > -        ('https://github.com/AspeedTech-BMC'
> > -         '/zephyr/releases/download/v00.01.07/ast1030-evb-demo.zip'),
> > -
> 'ad52e27959746988afaed8429bf4e12ab988c05c4d07c9d90e13ec6f7be4574c')
> > -
> > -    def test_ast1030_zephyros_1_07(self):
> > +    def test_ast1030_zephyros_3_00(self):
> >           self.set_machine('ast1030-evb')
> >
> >           kernel_name = "ast1030-evb-demo/zephyr.bin"
> >           kernel_file = self.archive_extract(
> > -            self.ASSET_ZEPHYR_1_07, member=kernel_name)
> > +            self.ASSET_ZEPHYR_3_00, member=kernel_name)
> >
> >           self.vm.set_console()
> >           self.vm.add_args('-kernel', kernel_file, '-nographic') @@
> > -49,17 +30,10 @@ def test_ast1030_zephyros_1_07(self):
> >           self.wait_for_console_pattern("Booting Zephyr OS")
> >           for shell_cmd in [
> >                   'kernel stacks',
> > -                'otp info conf',
> > -                'otp info scu',
> >                   'hwinfo devid',
> >                   'crypto aes256_cbc_vault',
> > -                'random get',
> > -                'jtag JTAG1 sw_xfer high TMS',
> > -                'adc ADC0 resolution 12',
> > -                'adc ADC0 read 42',
> > -                'adc ADC1 read 69',
> > -                'i2c scan I2C_0',
> > -                'i3c attach I3C_0',
> > +                'jtag jtag@7e6e4100 sw_xfer high TMS',
> > +                'iic scan i2c@7e7b0080',
> >                   'hash test',
> >                   'kernel uptime',
> >                   'kernel reboot warm',
Re: [PATCH v1 3/3] tests/functional/aspeed: Update test ASPEED SDK v03.00 for AST1030
Posted by Philippe Mathieu-Daudé 6 months, 3 weeks ago 
Hi Jamin,

On 22/4/25 11:15, Jamin Lin via wrote:
> Updated test to target SDK version v03.00.
> Removed redundant test case to simplify validation.

> Cleaned up unsupported shell commands.

Does that mean coverage is reduced?

> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   tests/functional/test_arm_aspeed_ast1030.py | 40 ++++-----------------
>   1 file changed, 7 insertions(+), 33 deletions(-)


> @@ -49,17 +30,10 @@ def test_ast1030_zephyros_1_07(self):
>           self.wait_for_console_pattern("Booting Zephyr OS")
>           for shell_cmd in [
>                   'kernel stacks',
> -                'otp info conf',
> -                'otp info scu',
>                   'hwinfo devid',
>                   'crypto aes256_cbc_vault',
> -                'random get',
> -                'jtag JTAG1 sw_xfer high TMS',
> -                'adc ADC0 resolution 12',
> -                'adc ADC0 read 42',
> -                'adc ADC1 read 69',
> -                'i2c scan I2C_0',
> -                'i3c attach I3C_0',
> +                'jtag jtag@7e6e4100 sw_xfer high TMS',
> +                'iic scan i2c@7e7b0080',
>                   'hash test',
>                   'kernel uptime',
>                   'kernel reboot warm',

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.