[v4] Support vbootrom for AST2700

[PATCH v4 09/10] tests/functional/aspeed: Add to test vbootrom for AST2700

Posted by Jamin Lin via 7 months ago

Add the AST2700 functional test to boot using the vbootrom image
instead of manually loading boot components with -device loader.
The boot ROM binary is now passed via the
-bios option, using the image located in pc-bios/ast27x0_bootrom.bin.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 tests/functional/test_aarch64_aspeed.py | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/tests/functional/test_aarch64_aspeed.py b/tests/functional/test_aarch64_aspeed.py
index 337d701917..85789c1b1d 100755
--- a/tests/functional/test_aarch64_aspeed.py
+++ b/tests/functional/test_aarch64_aspeed.py
@@ -94,6 +94,14 @@ def start_ast2700_test(self, name):
         exec_command_and_wait_for_pattern(self, 'root', 'Password:')
         exec_command_and_wait_for_pattern(self, '0penBmc', f'root@{name}:~#')
 
+    def start_ast2700_test_vbootrom(self, name):
+        self.vm.add_args('-bios', 'ast27x0_bootrom.bin')
+        self.do_test_aarch64_aspeed_sdk_start(
+                self.scratch_file(name, 'image-bmc'))
+        wait_for_console_pattern(self, f'{name} login:')
+        exec_command_and_wait_for_pattern(self, 'root', 'Password:')
+        exec_command_and_wait_for_pattern(self, '0penBmc', f'root@{name}:~#')
+
     def test_aarch64_ast2700_evb_sdk_v09_06(self):
         self.set_machine('ast2700-evb')
 
@@ -108,5 +116,12 @@ def test_aarch64_ast2700a1_evb_sdk_v09_06(self):
         self.start_ast2700_test('ast2700-default')
         self.do_ast2700_i2c_test()
 
+    def test_aarch64_ast2700a1_evb_sdk_vboottom_v09_06(self):
+        self.set_machine('ast2700a1-evb')
+
+        self.archive_extract(self.ASSET_SDK_V906_AST2700A1)
+        self.start_ast2700_test_vbootrom('ast2700-default')
+        self.do_ast2700_i2c_test()
+
 if __name__ == '__main__':
     QemuSystemTest.main()
-- 
2.43.0

Re: [PATCH v4 09/10] tests/functional/aspeed: Add to test vbootrom for AST2700

Posted by Cédric Le Goater 6 months, 4 weeks ago

On 4/17/25 05:12, Jamin Lin wrote:
> Add the AST2700 functional test to boot using the vbootrom image
> instead of manually loading boot components with -device loader.
> The boot ROM binary is now passed via the
> -bios option, using the image located in pc-bios/ast27x0_bootrom.bin.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   tests/functional/test_aarch64_aspeed.py | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/tests/functional/test_aarch64_aspeed.py b/tests/functional/test_aarch64_aspeed.py
> index 337d701917..85789c1b1d 100755
> --- a/tests/functional/test_aarch64_aspeed.py
> +++ b/tests/functional/test_aarch64_aspeed.py
> @@ -94,6 +94,14 @@ def start_ast2700_test(self, name):
>           exec_command_and_wait_for_pattern(self, 'root', 'Password:')
>           exec_command_and_wait_for_pattern(self, '0penBmc', f'root@{name}:~#')
>   
> +    def start_ast2700_test_vbootrom(self, name):
> +        self.vm.add_args('-bios', 'ast27x0_bootrom.bin')
> +        self.do_test_aarch64_aspeed_sdk_start(
> +                self.scratch_file(name, 'image-bmc'))
> +        wait_for_console_pattern(self, f'{name} login:')
> +        exec_command_and_wait_for_pattern(self, 'root', 'Password:')
> +        exec_command_and_wait_for_pattern(self, '0penBmc', f'root@{name}:~#')
> +
>       def test_aarch64_ast2700_evb_sdk_v09_06(self):
>           self.set_machine('ast2700-evb')
>   
> @@ -108,5 +116,12 @@ def test_aarch64_ast2700a1_evb_sdk_v09_06(self):
>           self.start_ast2700_test('ast2700-default')
>           self.do_ast2700_i2c_test()
>   
> +    def test_aarch64_ast2700a1_evb_sdk_vboottom_v09_06(self):

vboottom -> vbootrom

> +        self.set_machine('ast2700a1-evb')
> +
> +        self.archive_extract(self.ASSET_SDK_V906_AST2700A1)
> +        self.start_ast2700_test_vbootrom('ast2700-default')
> +        self.do_ast2700_i2c_test()
> +
>   if __name__ == '__main__':
>       QemuSystemTest.main()

I think we should add some patterns to catch the vbootrom output. See
below.


Thanks,

C.



  _    ______  ____  ____  __________  ____  __  ___      ___   ______________  ______  ______
| |  / / __ )/ __ \/ __ \/_  __/ __ \/ __ \/  |/  /     /   | / ___/_  __/__ \/__  / |/ / __ \
| | / / __  / / / / / / / / / / /_/ / / / / /|_/ /_____/ /| | \__ \ / /  __/ /  / /|   / / / /
| |/ / /_/ / /_/ / /_/ / / / / _, _/ /_/ / /  / /_____/ ___ |___/ // /  / __/  / //   / /_/ /
|___/_____/\____/\____/ /_/ /_/ |_|\____/_/  /_/     /_/  |_/____//_/  /____/ /_//_/|_\____/

Version:1.0.0

Found valid FIT image at 0x100100000 (size: 0x15908b bytes)
[uboot] load address: 0x80000000
[uboot] load end address: 0x800b39a0
[uboot] data: 735648 bytes @ offset 0x11c
[uboot] loading 735648 bytes to 0x400000000 ... done
[fdt] load: property not found
[fdt] no load addr, fallback to u-boot end: 0x800b39a0
[fdt] data: 25752 bytes @ offset 0xb3b5c
[fdt] loading 25752 bytes to 0x4000b39a0 ... done
[tee] load address: 0xb0080000
[tee] data: 433304 bytes @ offset 0xba070
[tee] loading 433304 bytes to 0x430080000 ... done
[atf] load address: 0xb0000000
[atf] data: 28777 bytes @ offset 0x123da8
[atf] loading 28777 bytes to 0x430000000 ... done
[sspfw] load address: 0xac000000
[sspfw] data: 67260 bytes @ offset 0x12aecc
[sspfw] loading 67260 bytes to 0x42c000000 ... done
[tspfw] load address: 0xae000000
[tspfw] data: 67392 bytes @ offset 0x13b630
[tspfw] loading 67392 bytes to 0x42e000000 ... done
[ibexfw] load address: 0x14ba8000
[ibexfw] data: 52460 bytes @ offset 0x14be18
[ibexfw] loading 52460 bytes to 0x14ba8000 ... done

Jumping to BL31 (Trusted Firmware-A) at 0x430000000

RE: [PATCH v4 09/10] tests/functional/aspeed: Add to test vbootrom for AST2700

Posted by Jamin Lin 6 months, 3 weeks ago

Hi Cedric,

> Subject: Re: [PATCH v4 09/10] tests/functional/aspeed: Add to test vbootrom
> for AST2700
> 
> On 4/17/25 05:12, Jamin Lin wrote:
> > Add the AST2700 functional test to boot using the vbootrom image
> > instead of manually loading boot components with -device loader.
> > The boot ROM binary is now passed via the -bios option, using the
> > image located in pc-bios/ast27x0_bootrom.bin.
> >
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > ---
> >   tests/functional/test_aarch64_aspeed.py | 15 +++++++++++++++
> >   1 file changed, 15 insertions(+)
> >
> > diff --git a/tests/functional/test_aarch64_aspeed.py
> > b/tests/functional/test_aarch64_aspeed.py
> > index 337d701917..85789c1b1d 100755
> > --- a/tests/functional/test_aarch64_aspeed.py
> > +++ b/tests/functional/test_aarch64_aspeed.py
> > @@ -94,6 +94,14 @@ def start_ast2700_test(self, name):
> >           exec_command_and_wait_for_pattern(self, 'root', 'Password:')
> >           exec_command_and_wait_for_pattern(self, '0penBmc',
> > f'root@{name}:~#')
> >
> > +    def start_ast2700_test_vbootrom(self, name):
> > +        self.vm.add_args('-bios', 'ast27x0_bootrom.bin')
> > +        self.do_test_aarch64_aspeed_sdk_start(
> > +                self.scratch_file(name, 'image-bmc'))
> > +        wait_for_console_pattern(self, f'{name} login:')
> > +        exec_command_and_wait_for_pattern(self, 'root', 'Password:')
> > +        exec_command_and_wait_for_pattern(self, '0penBmc',
> > + f'root@{name}:~#')
> > +
> >       def test_aarch64_ast2700_evb_sdk_v09_06(self):
> >           self.set_machine('ast2700-evb')
> >
> > @@ -108,5 +116,12 @@ def test_aarch64_ast2700a1_evb_sdk_v09_06(self):
> >           self.start_ast2700_test('ast2700-default')
> >           self.do_ast2700_i2c_test()
> >
> > +    def test_aarch64_ast2700a1_evb_sdk_vboottom_v09_06(self):
> 
> vboottom -> vbootrom
> 
> > +        self.set_machine('ast2700a1-evb')
> > +
> > +        self.archive_extract(self.ASSET_SDK_V906_AST2700A1)
> > +        self.start_ast2700_test_vbootrom('ast2700-default')
> > +        self.do_ast2700_i2c_test()
> > +
> >   if __name__ == '__main__':
> >       QemuSystemTest.main()
> 
> I think we should add some patterns to catch the vbootrom output. See below.
> 
Thanks for your suggestion and review.
Will add
Thanks-Jamin
> 
> Thanks,
> 
> C.
> 
> 
> 
>   _    ______  ____  ____  __________  ____  __  ___      ___
> ______________  ______  ______
> | |  / / __ )/ __ \/ __ \/_  __/ __ \/ __ \/  |/  /     /   | / ___/_  __/__
> \/__  / |/ / __ \
> | | / / __  / / / / / / / / / / /_/ / / / / /|_/ /_____/ /| | \__ \ / /  __/ /  / /|
> / / / /
> | |/ / /_/ / /_/ / /_/ / / / / _, _/ /_/ / /  / /_____/ ___ |___/ // /  / __/  / //
> / /_/ /
> |___/_____/\____/\____/ /_/ /_/ |_|\____/_/  /_/     /_/  |_/____//_/
> /____/ /_//_/|_\____/
> 
> Version:1.0.0
> 
> Found valid FIT image at 0x100100000 (size: 0x15908b bytes) [uboot] load
> address: 0x80000000 [uboot] load end address: 0x800b39a0 [uboot] data:
> 735648 bytes @ offset 0x11c [uboot] loading 735648 bytes to 0x400000000 ...
> done [fdt] load: property not found [fdt] no load addr, fallback to u-boot end:
> 0x800b39a0 [fdt] data: 25752 bytes @ offset 0xb3b5c [fdt] loading 25752 bytes
> to 0x4000b39a0 ... done [tee] load address: 0xb0080000 [tee] data: 433304
> bytes @ offset 0xba070 [tee] loading 433304 bytes to 0x430080000 ... done
> [atf] load address: 0xb0000000 [atf] data: 28777 bytes @ offset 0x123da8 [atf]
> loading 28777 bytes to 0x430000000 ... done [sspfw] load address: 0xac000000
> [sspfw] data: 67260 bytes @ offset 0x12aecc [sspfw] loading 67260 bytes to
> 0x42c000000 ... done [tspfw] load address: 0xae000000 [tspfw] data: 67392
> bytes @ offset 0x13b630 [tspfw] loading 67392 bytes to 0x42e000000 ... done
> [ibexfw] load address: 0x14ba8000 [ibexfw] data: 52460 bytes @ offset
> 0x14be18 [ibexfw] loading 52460 bytes to 0x14ba8000 ... done
> 
> Jumping to BL31 (Trusted Firmware-A) at 0x430000000
>

Re: [PATCH v4 09/10] tests/functional/aspeed: Add to test vbootrom for AST2700

Posted by Nabih Estefan 6 months, 4 weeks ago

On Wed, Apr 16, 2025 at 8:12 PM Jamin Lin <jamin_lin@aspeedtech.com> wrote:
>
> Add the AST2700 functional test to boot using the vbootrom image
> instead of manually loading boot components with -device loader.
> The boot ROM binary is now passed via the
> -bios option, using the image located in pc-bios/ast27x0_bootrom.bin.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Nabih Estefan <nabihestefan@google.com>
> ---
>  tests/functional/test_aarch64_aspeed.py | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/tests/functional/test_aarch64_aspeed.py b/tests/functional/test_aarch64_aspeed.py
> index 337d701917..85789c1b1d 100755
> --- a/tests/functional/test_aarch64_aspeed.py
> +++ b/tests/functional/test_aarch64_aspeed.py
> @@ -94,6 +94,14 @@ def start_ast2700_test(self, name):
>          exec_command_and_wait_for_pattern(self, 'root', 'Password:')
>          exec_command_and_wait_for_pattern(self, '0penBmc', f'root@{name}:~#')
>
> +    def start_ast2700_test_vbootrom(self, name):
> +        self.vm.add_args('-bios', 'ast27x0_bootrom.bin')
> +        self.do_test_aarch64_aspeed_sdk_start(
> +                self.scratch_file(name, 'image-bmc'))
> +        wait_for_console_pattern(self, f'{name} login:')
> +        exec_command_and_wait_for_pattern(self, 'root', 'Password:')
> +        exec_command_and_wait_for_pattern(self, '0penBmc', f'root@{name}:~#')
> +
>      def test_aarch64_ast2700_evb_sdk_v09_06(self):
>          self.set_machine('ast2700-evb')
>
> @@ -108,5 +116,12 @@ def test_aarch64_ast2700a1_evb_sdk_v09_06(self):
>          self.start_ast2700_test('ast2700-default')
>          self.do_ast2700_i2c_test()
>
> +    def test_aarch64_ast2700a1_evb_sdk_vboottom_v09_06(self):
> +        self.set_machine('ast2700a1-evb')
> +
> +        self.archive_extract(self.ASSET_SDK_V906_AST2700A1)
> +        self.start_ast2700_test_vbootrom('ast2700-default')
> +        self.do_ast2700_i2c_test()
> +
>  if __name__ == '__main__':
>      QemuSystemTest.main()
> --
> 2.43.0
>