tests/functional/test_vnc: skip test if no crypto backend available

[PATCH] tests/functional/test_vnc: skip test if no crypto backend available

Cornelia Huck posted 1 patch 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250414093732.220498-1-cohuck@redhat.com

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>

tests/functional/test_vnc.py | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] tests/functional/test_vnc: skip test if no crypto backend available

Posted by Cornelia Huck 10 months ago

The test_change_password test will fail if no cryptographic backend is
available (e.g. if QEMU was built on a system with no cryptographic
library development packages installed); just skip the test in that
case.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 tests/functional/test_vnc.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/functional/test_vnc.py b/tests/functional/test_vnc.py
index 8c9953bdb001..d4e9dd0279ea 100755
--- a/tests/functional/test_vnc.py
+++ b/tests/functional/test_vnc.py
@@ -55,6 +55,8 @@ def launch_guarded(self):
         except VMLaunchFailure as excp:
             if "-vnc: invalid option" in excp.output:
                 self.skipTest("VNC support not available")
+            elif "Cipher backend does not support DES algorithm" in excp.output:
+                self.skipTest("No cryptographic backend available")
             else:
                 self.log.info("unhandled launch failure: %s", excp.output)
                 raise excp
-- 
2.49.0

Re: [PATCH] tests/functional/test_vnc: skip test if no crypto backend available

Posted by Thomas Huth 10 months ago

On 14/04/2025 11.37, Cornelia Huck wrote:
> The test_change_password test will fail if no cryptographic backend is
> available (e.g. if QEMU was built on a system with no cryptographic
> library development packages installed); just skip the test in that
> case.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>   tests/functional/test_vnc.py | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/functional/test_vnc.py b/tests/functional/test_vnc.py
> index 8c9953bdb001..d4e9dd0279ea 100755
> --- a/tests/functional/test_vnc.py
> +++ b/tests/functional/test_vnc.py
> @@ -55,6 +55,8 @@ def launch_guarded(self):
>           except VMLaunchFailure as excp:
>               if "-vnc: invalid option" in excp.output:
>                   self.skipTest("VNC support not available")
> +            elif "Cipher backend does not support DES algorithm" in excp.output:
> +                self.skipTest("No cryptographic backend available")
>               else:
>                   self.log.info("unhandled launch failure: %s", excp.output)
>                   raise excp

Reviewed-by: Thomas Huth <thuth@redhat.com>