[v1] target/loongarch: Code cleanup with function loongarch_map_address

[PATCH 0/5] target/loongarch: Code cleanup with function loongarch_map_address

Bibo Mao posted 5 patches 4 weeks ago

Diff against v2 v3 v4
Download series mbox

Failed in applying to current master (apply log)

There is a newer version of this series

target/loongarch/cpu_helper.c     | 173 ++-----
target/loongarch/helper.h         | 720 +----------------------------
target/loongarch/internals.h      |  14 +-
target/loongarch/tcg/helper.h     | 722 ++++++++++++++++++++++++++++++
target/loongarch/tcg/tlb_helper.c | 172 +++++--
5 files changed, 913 insertions(+), 888 deletions(-)
create mode 100644 target/loongarch/tcg/helper.h

Expand all Fold all

[PATCH 0/5] target/loongarch: Code cleanup with function loongarch_map_address

Posted by Bibo Mao 4 weeks ago

Get physical address from virtual address is important for qmp command to
dump memory content. In TCG mode, it searches TLB tables firstly and
then do page table walker. In KVM mode, there is no TLB tables and page
table walker is used directly.

Here TLB tables searching is moved to directory tcg, and code about page
table walker is put in common part so that it can be used in KVM mode
also.

Bibo Mao (5):
  target/loongarch: Move header file helper.h to directory tcg
  target/loongarch: Add function loongarch_get_addr_from_tlb
  target/loongarch: Move function get_dir_base_width to common directory
  target/loongarch: Set function loongarch_map_address() with common
    code
  target/loongarch: Move function loongarch_tlb_search to directory tcg

 target/loongarch/cpu_helper.c     | 173 ++-----
 target/loongarch/helper.h         | 720 +----------------------------
 target/loongarch/internals.h      |  14 +-
 target/loongarch/tcg/helper.h     | 722 ++++++++++++++++++++++++++++++
 target/loongarch/tcg/tlb_helper.c | 172 +++++--
 5 files changed, 913 insertions(+), 888 deletions(-)
 create mode 100644 target/loongarch/tcg/helper.h


base-commit: 56c6e249b6988c1b6edc2dd34ebb0f1e570a1365
-- 
2.39.3

Re: [PATCH 0/5] target/loongarch: Code cleanup with function loongarch_map_address

Posted by Philippe Mathieu-Daudé 4 weeks ago

Hi Bibo,

On 14/4/25 03:25, Bibo Mao wrote:
> Get physical address from virtual address is important for qmp command to
> dump memory content. In TCG mode, it searches TLB tables firstly and
> then do page table walker. In KVM mode, there is no TLB tables and page
> table walker is used directly.
> 
> Here TLB tables searching is moved to directory tcg, and code about page
> table walker is put in common part so that it can be used in KVM mode
> also.
> 
> Bibo Mao (5):
>    target/loongarch: Move header file helper.h to directory tcg
>    target/loongarch: Add function loongarch_get_addr_from_tlb
>    target/loongarch: Move function get_dir_base_width to common directory
>    target/loongarch: Set function loongarch_map_address() with common
>      code
>    target/loongarch: Move function loongarch_tlb_search to directory tcg

Please check if changes in patches 4 & 5 need adjustment.
Otherwise for the series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>