fix record/replay on MacOS

[PATCH 0/2] fix record/replay on MacOS

Posted by Pierrick Bouvier 7 months, 1 week ago

Recently, it was found that rr tests fail on MacOS, with a replay_mutex_unlock()
assertion. This is a recent regression, related to running qemu main event loop
in a separate thread, like first commit explain.

We first fix the regression, by handling the qemu replay mutex in the same way
we deal with BQL.
Then, we reenable the disabled test.

Pierrick Bouvier (2):
  system/main: transfer replay mutex ownership from main thread to main
    loop thread
  tests/functional/test_aarch64_replay: reenable on macos

 system/main.c                           | 4 ++++
 tests/functional/test_aarch64_replay.py | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
2.39.5

Re: [PATCH 0/2] fix record/replay on MacOS

Posted by Stefan Hajnoczi 7 months ago

On Thu, Apr 10, 2025 at 03:55:48PM -0700, Pierrick Bouvier wrote:
> Recently, it was found that rr tests fail on MacOS, with a replay_mutex_unlock()
> assertion. This is a recent regression, related to running qemu main event loop
> in a separate thread, like first commit explain.
> 
> We first fix the regression, by handling the qemu replay mutex in the same way
> we deal with BQL.
> Then, we reenable the disabled test.
> 
> Pierrick Bouvier (2):
>   system/main: transfer replay mutex ownership from main thread to main
>     loop thread
>   tests/functional/test_aarch64_replay: reenable on macos
> 
>  system/main.c                           | 4 ++++
>  tests/functional/test_aarch64_replay.py | 2 --
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> -- 
> 2.39.5
> 

Thanks, applied to my staging tree:
https://gitlab.com/stefanha/qemu/commits/staging

Stefan

Re: [PATCH 0/2] fix record/replay on MacOS

Posted by Pierrick Bouvier 7 months ago

On 4/14/25 08:14, Stefan Hajnoczi wrote:
> On Thu, Apr 10, 2025 at 03:55:48PM -0700, Pierrick Bouvier wrote:
>> Recently, it was found that rr tests fail on MacOS, with a replay_mutex_unlock()
>> assertion. This is a recent regression, related to running qemu main event loop
>> in a separate thread, like first commit explain.
>>
>> We first fix the regression, by handling the qemu replay mutex in the same way
>> we deal with BQL.
>> Then, we reenable the disabled test.
>>
>> Pierrick Bouvier (2):
>>    system/main: transfer replay mutex ownership from main thread to main
>>      loop thread
>>    tests/functional/test_aarch64_replay: reenable on macos
>>
>>   system/main.c                           | 4 ++++
>>   tests/functional/test_aarch64_replay.py | 2 --
>>   2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> -- 
>> 2.39.5
>>
> 
> Thanks, applied to my staging tree:
> https://gitlab.com/stefanha/qemu/commits/staging
>

Thank you Stefan.

> Stefan

Re: [PATCH 0/2] fix record/replay on MacOS

Posted by Philippe Mathieu-Daudé 7 months, 1 week ago

On 11/4/25 00:55, Pierrick Bouvier wrote:

> Pierrick Bouvier (2):
>    system/main: transfer replay mutex ownership from main thread to main
>      loop thread
>    tests/functional/test_aarch64_replay: reenable on macos

Series:
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>