scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword

[PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword

Posted by Zhao Liu 7 months, 1 week ago

Fix the typo in the error message to help `grep` the example:

ERROR: New file '***' requires 'SPDX-License-Identifer'

Fixes: fa4d79c64dae ("scripts: mandate that new files have SPDX-License-Identifier")
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 scripts/checkpatch.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6ae9d7febee8..365892de0428 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1688,11 +1688,11 @@ sub process {
 			    /\.(c|h|py|pl|sh|json|inc|Makefile)$/) {
 			    # source code files MUST have SPDX license declared
 			    ERROR("New file '$expect_spdx_file' requires " .
-				  "'SPDX-License-Identifer'");
+				  "'SPDX-License-Identifier'");
 			} else {
 			    # Other files MAY have SPDX license if appropriate
 			    WARN("Does new file '$expect_spdx_file' need " .
-				 "'SPDX-License-Identifer'?");
+				 "'SPDX-License-Identifier'?");
 			}
 		    }
 		    $expect_spdx = 1;
-- 
2.34.1

Re: [PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword

Posted by Philippe Mathieu-Daudé 7 months, 1 week ago

On 8/4/25 18:27, Zhao Liu wrote:
> Fix the typo in the error message to help `grep` the example:
> 
> ERROR: New file '***' requires 'SPDX-License-Identifer'
> 
> Fixes: fa4d79c64dae ("scripts: mandate that new files have SPDX-License-Identifier")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   scripts/checkpatch.pl | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Patch queued, thanks!

Re: [PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword

Posted by Alex Bennée 7 months, 1 week ago

Zhao Liu <zhao1.liu@intel.com> writes:

> Fix the typo in the error message to help `grep` the example:
>
> ERROR: New file '***' requires 'SPDX-License-Identifer'
>
> Fixes: fa4d79c64dae ("scripts: mandate that new files have SPDX-License-Identifier")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro