migration: Fix latent bug in migrate_params_test_apply()

[PATCH] migration: Fix latent bug in migrate_params_test_apply()

Markus Armbruster posted 1 patch 8 months, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250407072833.2118928-1-armbru@redhat.com

Maintainers: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>

migration/options.c | 5 +++++
1 file changed, 5 insertions(+)

Expand all Fold all

[PATCH] migration: Fix latent bug in migrate_params_test_apply()

Posted by Markus Armbruster 8 months, 2 weeks ago

migrate_params_test_apply() neglects to apply tls_authz.  Currently
harmless, because migrate_params_check() doesn't care.  Fix it anyway.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 migration/options.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/migration/options.c b/migration/options.c
index b0ac2ea408..cb8eec218f 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -1193,6 +1193,11 @@ static void migrate_params_test_apply(MigrateSetParameters *params,
         dest->tls_hostname = params->tls_hostname->u.s;
     }
 
+    if (params->tls_authz) {
+        assert(params->tls_authz->type == QTYPE_QSTRING);
+        dest->tls_authz = params->tls_authz->u.s;
+    }
+
     if (params->has_max_bandwidth) {
         dest->max_bandwidth = params->max_bandwidth;
     }
-- 
2.48.1

Re: [PATCH] migration: Fix latent bug in migrate_params_test_apply()

Posted by Fabiano Rosas 8 months, 2 weeks ago

Markus Armbruster <armbru@redhat.com> writes:

> migrate_params_test_apply() neglects to apply tls_authz.  Currently
> harmless, because migrate_params_check() doesn't care.  Fix it anyway.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  migration/options.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/migration/options.c b/migration/options.c
> index b0ac2ea408..cb8eec218f 100644
> --- a/migration/options.c
> +++ b/migration/options.c
> @@ -1193,6 +1193,11 @@ static void migrate_params_test_apply(MigrateSetParameters *params,
>          dest->tls_hostname = params->tls_hostname->u.s;
>      }
>  
> +    if (params->tls_authz) {
> +        assert(params->tls_authz->type == QTYPE_QSTRING);
> +        dest->tls_authz = params->tls_authz->u.s;
> +    }
> +
>      if (params->has_max_bandwidth) {
>          dest->max_bandwidth = params->max_bandwidth;
>      }

Reviewed-by: Fabiano Rosas <farosas@suse.de>