On 4/4/25 15:35, Philippe Mathieu-Daudé wrote:
> Some headers are indirectly pulled in. Make their inclusion
> explicit, otherwise next commit triggers:
>
> target/arm/tcg/mte_helper.c:188:26: error: call to undeclared function 'GETPC' [-Wimplicit-function-declaration]
> 188 | do_stg(env, ptr, xt, GETPC(), store_tag1);
> | ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/arm/tcg/mte_helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/arm/tcg/mte_helper.c b/target/arm/tcg/mte_helper.c
> index 7dc5fb776b3..9dcdc1d91c1 100644
> --- a/target/arm/tcg/mte_helper.c
> +++ b/target/arm/tcg/mte_helper.c
> @@ -22,7 +22,7 @@
> #include "cpu.h"
> #include "internals.h"
> #include "exec/exec-all.h"
> -#include "exec/page-protection.h"
> +#include "exec/target_page.h"
> #ifdef CONFIG_USER_ONLY
> #include "user/cpu_loop.h"
> #include "user/page-protection.h"
> @@ -33,6 +33,7 @@
> #include "exec/helper-proto.h"
> #include "exec/tlb-flags.h"
> #include "accel/tcg/cpu-ops.h"
> +#include "accel/tcg/getpc.h"
> #include "qapi/error.h"
> #include "qemu/guest-random.h"
> #include "mte_helper.h"
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~