cpus: Restrict SoftMMU mmu_index() to TCG

[PATCH-for-10.1 01/24] hw/core/cpu: Update CPUClass::mmu_index docstring

Posted by Philippe Mathieu-Daudé 7 months, 2 weeks ago

Since commits 32a8ea12fab..90b7022e698 (target: "Split out
TARGET_env_mmu_index"), target's memory_rw_debug() callbacks
use the target's TARGET_env_mmu_index(), not the generic
CPUClass::mmu_index() callback. Update the documentation.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/core/cpu.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index 84a71d8cf17..60b7abaf49b 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -104,8 +104,7 @@ struct SysemuCPUOps;
  *                 instantiatable CPU type.
  * @parse_features: Callback to parse command line arguments.
  * @reset_dump_flags: #CPUDumpFlags to use for reset logging.
- * @mmu_index: Callback for choosing softmmu mmu index;
- *       may be used internally by memory_rw_debug without TCG.
+ * @mmu_index: Callback for choosing softmmu mmu index.
  * @memory_rw_debug: Callback for GDB memory access.
  * @dump_state: Callback for dumping state.
  * @query_cpu_fast:
-- 
2.47.1

Re: [PATCH-for-10.1 01/24] hw/core/cpu: Update CPUClass::mmu_index docstring

Posted by Richard Henderson 7 months, 2 weeks ago

On 4/1/25 01:09, Philippe Mathieu-Daudé wrote:
> Since commits 32a8ea12fab..90b7022e698 (target: "Split out
> TARGET_env_mmu_index"), target's memory_rw_debug() callbacks
> use the target's TARGET_env_mmu_index(), not the generic
> CPUClass::mmu_index() callback. Update the documentation.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   include/hw/core/cpu.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~