hw: Categorize few devices and add their descriptions

[PATCH-for-10.0 06/12] hw/i2c/pca954x: Categorize and add description

Posted by Philippe Mathieu-Daudé 1 week ago

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/i2c/i2c_mux_pca954x.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c
index 779cc4e66ed..100b8d86093 100644
--- a/hw/i2c/i2c_mux_pca954x.c
+++ b/hw/i2c/i2c_mux_pca954x.c
@@ -175,12 +175,18 @@ I2CBus *pca954x_i2c_get_bus(I2CSlave *mux, uint8_t channel)
 static void pca9546_class_init(ObjectClass *klass, void *data)
 {
     Pca954xClass *s = PCA954X_CLASS(klass);
+    DeviceClass *dc = DEVICE_CLASS(klass);
+
+    dc->desc = "PCA9546 I2C multiplexer";
     s->nchans = PCA9546_CHANNEL_COUNT;
 }
 
 static void pca9548_class_init(ObjectClass *klass, void *data)
 {
     Pca954xClass *s = PCA954X_CLASS(klass);
+    DeviceClass *dc = DEVICE_CLASS(klass);
+
+    dc->desc = "PCA9548 I2C multiplexer";
     s->nchans = PCA9548_CHANNEL_COUNT;
 }
 
@@ -226,13 +232,13 @@ static void pca954x_class_init(ObjectClass *klass, void *data)
 
     rc->phases.enter = pca954x_enter_reset;
 
-    dc->desc = "Pca954x i2c-mux";
     dc->realize = pca954x_realize;
 
     k->write_data = pca954x_write_data;
     k->receive_byte = pca954x_read_byte;
 
     device_class_set_props(dc, pca954x_props);
+    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
 }
 
 static const TypeInfo pca954x_info[] = {
-- 
2.47.1

Re: [PATCH-for-10.0 06/12] hw/i2c/pca954x: Categorize and add description

Posted by Thomas Huth 1 week ago

On 25/03/2025 23.43, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/i2c/i2c_mux_pca954x.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c
> index 779cc4e66ed..100b8d86093 100644
> --- a/hw/i2c/i2c_mux_pca954x.c
> +++ b/hw/i2c/i2c_mux_pca954x.c
> @@ -175,12 +175,18 @@ I2CBus *pca954x_i2c_get_bus(I2CSlave *mux, uint8_t channel)
>   static void pca9546_class_init(ObjectClass *klass, void *data)
>   {
>       Pca954xClass *s = PCA954X_CLASS(klass);
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +
> +    dc->desc = "PCA9546 I2C multiplexer";
>       s->nchans = PCA9546_CHANNEL_COUNT;
>   }
>   
>   static void pca9548_class_init(ObjectClass *klass, void *data)
>   {
>       Pca954xClass *s = PCA954X_CLASS(klass);
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +
> +    dc->desc = "PCA9548 I2C multiplexer";
>       s->nchans = PCA9548_CHANNEL_COUNT;
>   }
>   
> @@ -226,13 +232,13 @@ static void pca954x_class_init(ObjectClass *klass, void *data)
>   
>       rc->phases.enter = pca954x_enter_reset;
>   
> -    dc->desc = "Pca954x i2c-mux";
>       dc->realize = pca954x_realize;
>   
>       k->write_data = pca954x_write_data;
>       k->receive_byte = pca954x_read_byte;
>   
>       device_class_set_props(dc, pca954x_props);
> +    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);

Clear DEVICE_CATEGORY_MISC ?

  Thomas

Re: [PATCH-for-10.0 06/12] hw/i2c/pca954x: Categorize and add description

Posted by Corey Minyard 1 week ago

On Tue, Mar 25, 2025 at 11:43:04PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  hw/i2c/i2c_mux_pca954x.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Looks ok to me.

Acked-by: Corey Minyard <cminyard@mvista.com>

> 
> diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c
> index 779cc4e66ed..100b8d86093 100644
> --- a/hw/i2c/i2c_mux_pca954x.c
> +++ b/hw/i2c/i2c_mux_pca954x.c
> @@ -175,12 +175,18 @@ I2CBus *pca954x_i2c_get_bus(I2CSlave *mux, uint8_t channel)
>  static void pca9546_class_init(ObjectClass *klass, void *data)
>  {
>      Pca954xClass *s = PCA954X_CLASS(klass);
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +
> +    dc->desc = "PCA9546 I2C multiplexer";
>      s->nchans = PCA9546_CHANNEL_COUNT;
>  }
>  
>  static void pca9548_class_init(ObjectClass *klass, void *data)
>  {
>      Pca954xClass *s = PCA954X_CLASS(klass);
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +
> +    dc->desc = "PCA9548 I2C multiplexer";
>      s->nchans = PCA9548_CHANNEL_COUNT;
>  }
>  
> @@ -226,13 +232,13 @@ static void pca954x_class_init(ObjectClass *klass, void *data)
>  
>      rc->phases.enter = pca954x_enter_reset;
>  
> -    dc->desc = "Pca954x i2c-mux";
>      dc->realize = pca954x_realize;
>  
>      k->write_data = pca954x_write_data;
>      k->receive_byte = pca954x_read_byte;
>  
>      device_class_set_props(dc, pca954x_props);
> +    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
>  }
>  
>  static const TypeInfo pca954x_info[] = {
> -- 
> 2.47.1
> 
>