hw: Categorize few devices and add their descriptions

[PATCH-for-10.0 05/12] hw/gpio/pca9552: Categorize and add description

Philippe Mathieu-Daudé posted 12 patches 10 months, 2 weeks ago

Download mbox

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Alistair Francis <alistair@alistair23.me>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Samuel Tardieu <sam@rfc1149.net>, "Hervé Poussineau" <hpoussin@reactos.org>, Glenn Miles <milesg@linux.ibm.com>, Patrick Leis <venture@google.com>, Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Tyrone Ting <kfting@nuvoton.com>, Hao Wu <wuhaotsh@google.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, BALATON Zoltan <balaton@eik.bme.hu>, Bernhard Beschow <shentey@gmail.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>

Expand all Fold all

[PATCH-for-10.0 05/12] hw/gpio/pca9552: Categorize and add description

Posted by Philippe Mathieu-Daudé 10 months, 2 weeks ago

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/gpio/pca9552.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c
index 1ac0cf6c464..b152872f6c6 100644
--- a/hw/gpio/pca9552.c
+++ b/hw/gpio/pca9552.c
@@ -459,6 +459,8 @@ static void pca9552_class_init(ObjectClass *oc, void *data)
     DeviceClass *dc = DEVICE_CLASS(oc);
     PCA955xClass *pc = PCA955X_CLASS(oc);
 
+    dc->desc = "PCA9552 LED blinker";
+    set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
     device_class_set_legacy_reset(dc, pca9552_reset);
     dc->vmsd = &pca9552_vmstate;
     pc->max_reg = PCA9552_LS3;
-- 
2.47.1

Re: [PATCH-for-10.0 05/12] hw/gpio/pca9552: Categorize and add description

Posted by Thomas Huth 10 months, 2 weeks ago

On 25/03/2025 23.43, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/gpio/pca9552.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c
> index 1ac0cf6c464..b152872f6c6 100644
> --- a/hw/gpio/pca9552.c
> +++ b/hw/gpio/pca9552.c
> @@ -459,6 +459,8 @@ static void pca9552_class_init(ObjectClass *oc, void *data)
>       DeviceClass *dc = DEVICE_CLASS(oc);
>       PCA955xClass *pc = PCA955X_CLASS(oc);
>   
> +    dc->desc = "PCA9552 LED blinker";
> +    set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
>       device_class_set_legacy_reset(dc, pca9552_reset);
>       dc->vmsd = &pca9552_vmstate;
>       pc->max_reg = PCA9552_LS3;

I2C device - same problem as in patch 1 : Unset MISC category here?

  Thomas