Last uses of ldtul_be_p() were removed in commit 78920b4ff2b
("target/sparc: Use explicit big-endian LD/ST API"), and of
ldtul_le_p() in 39631d57d7c ("target/riscv: Use explicit
little-endian LD/ST API"). Remove these legacy macros.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/gdbstub/helpers.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h
index 6f7cc48adcb..26140ef1ac0 100644
--- a/include/gdbstub/helpers.h
+++ b/include/gdbstub/helpers.h
@@ -95,13 +95,9 @@ static inline uint8_t *gdb_get_reg_ptr(GByteArray *buf, int len)
 #if TARGET_LONG_BITS == 64
 #define gdb_get_regl(buf, val) gdb_get_reg64(buf, val)
 #define ldtul_p(addr) ldq_p(addr)
-#define ldtul_le_p(addr) ldq_le_p(addr)
-#define ldtul_be_p(addr) ldq_be_p(addr)
 #else
 #define gdb_get_regl(buf, val) gdb_get_reg32(buf, val)
 #define ldtul_p(addr) ldl_p(addr)
-#define ldtul_le_p(addr) ldl_le_p(addr)
-#define ldtul_be_p(addr) ldl_be_p(addr)
 #endif
 
 #endif /* _GDBSTUB_HELPERS_H_ */
-- 
2.47.1

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Last uses of ldtul_be_p() were removed in commit 78920b4ff2b
> ("target/sparc: Use explicit big-endian LD/ST API"), and of
> ldtul_le_p() in 39631d57d7c ("target/riscv: Use explicit
> little-endian LD/ST API"). Remove these legacy macros.

I'm guessing these are commits in your tree because I can't see them in
origin.


>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/gdbstub/helpers.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h
> index 6f7cc48adcb..26140ef1ac0 100644
> --- a/include/gdbstub/helpers.h
> +++ b/include/gdbstub/helpers.h
> @@ -95,13 +95,9 @@ static inline uint8_t *gdb_get_reg_ptr(GByteArray *buf, int len)
>  #if TARGET_LONG_BITS == 64
>  #define gdb_get_regl(buf, val) gdb_get_reg64(buf, val)
>  #define ldtul_p(addr) ldq_p(addr)
> -#define ldtul_le_p(addr) ldq_le_p(addr)
> -#define ldtul_be_p(addr) ldq_be_p(addr)
>  #else
>  #define gdb_get_regl(buf, val) gdb_get_reg32(buf, val)
>  #define ldtul_p(addr) ldl_p(addr)
> -#define ldtul_le_p(addr) ldl_le_p(addr)
> -#define ldtul_be_p(addr) ldl_be_p(addr)
>  #endif
>  
>  #endif /* _GDBSTUB_HELPERS_H_ */

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

On 26/3/25 13:59, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> 
>> Last uses of ldtul_be_p() were removed in commit 78920b4ff2b
>> ("target/sparc: Use explicit big-endian LD/ST API"), and of
>> ldtul_le_p() in 39631d57d7c ("target/riscv: Use explicit
>> little-endian LD/ST API"). Remove these legacy macros.
> 
> I'm guessing these are commits in your tree because I can't see them in
> origin.

Oops. I'll respin altogether as a single series.

> 
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   include/gdbstub/helpers.h | 4 ----
>>   1 file changed, 4 deletions(-)