[v2] hw/intc/loongarch_pch: Cleanup with memory region ops

[PATCH v2 06/16] hw/intc/loongarch_pch: Discard write operation with ISR register

Posted by Bibo Mao 10 months, 3 weeks ago

With the latest 7A1000 user manual, interrupt status register ISR is
read only. Here discard write operation with ISR register.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
 hw/intc/loongarch_pch_pic.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/hw/intc/loongarch_pch_pic.c b/hw/intc/loongarch_pch_pic.c
index 93f7ceb6b9..10b4231464 100644
--- a/hw/intc/loongarch_pch_pic.c
+++ b/hw/intc/loongarch_pch_pic.c
@@ -234,12 +234,6 @@ static void loongarch_pch_pic_high_writew(void *opaque, hwaddr addr,
     trace_loongarch_pch_pic_high_writew(size, addr, data);
 
     switch (addr) {
-    case PCH_PIC_INT_STATUS:
-        s->intisr = get_writew_val(s->intisr, data, 0);
-        break;
-    case PCH_PIC_INT_STATUS + 4:
-        s->intisr = get_writew_val(s->intisr, data, 1);
-        break;
     case PCH_PIC_INT_POL:
         s->int_polarity = get_writew_val(s->int_polarity, data, 0);
         break;
-- 
2.39.3

Re: [PATCH v2 06/16] hw/intc/loongarch_pch: Discard write operation with ISR register

Posted by gaosong 9 months, 2 weeks ago

在 2025/3/24 下午5:37, Bibo Mao 写道:
> With the latest 7A1000 user manual, interrupt status register ISR is
> read only. Here discard write operation with ISR register.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>   hw/intc/loongarch_pch_pic.c | 6 ------
>   1 file changed, 6 deletions(-)
Reviewed-by: Song Gao <gaosong@loongson.cn>
thanks.
Song Gao
> diff --git a/hw/intc/loongarch_pch_pic.c b/hw/intc/loongarch_pch_pic.c
> index 93f7ceb6b9..10b4231464 100644
> --- a/hw/intc/loongarch_pch_pic.c
> +++ b/hw/intc/loongarch_pch_pic.c
> @@ -234,12 +234,6 @@ static void loongarch_pch_pic_high_writew(void *opaque, hwaddr addr,
>       trace_loongarch_pch_pic_high_writew(size, addr, data);
>   
>       switch (addr) {
> -    case PCH_PIC_INT_STATUS:
> -        s->intisr = get_writew_val(s->intisr, data, 0);
> -        break;
> -    case PCH_PIC_INT_STATUS + 4:
> -        s->intisr = get_writew_val(s->intisr, data, 1);
> -        break;
>       case PCH_PIC_INT_POL:
>           s->int_polarity = get_writew_val(s->int_polarity, data, 0);
>           break;