target/hppa: Remove duplicated CPU_RESOLVING_TYPE definition

[PATCH] target/hppa: Remove duplicated CPU_RESOLVING_TYPE definition

Posted by Philippe Mathieu-Daudé 1 week, 1 day ago

The CPU_RESOLVING_TYPE definition was added in commit
0dacec874fa ("cpu: add CPU_RESOLVING_TYPE macro"), but
then added again in commit d3ae32d4d20. Remove the
duplication.

Fixes: d3ae32d4d20 ("target/hppa: Implement cpu_list")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/hppa/cpu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
index 7be4a1d3800..8b36642b591 100644
--- a/target/hppa/cpu.h
+++ b/target/hppa/cpu.h
@@ -391,6 +391,4 @@ void hppa_cpu_alarm_timer(void *);
 #endif
 G_NORETURN void hppa_dynamic_excp(CPUHPPAState *env, int excp, uintptr_t ra);
 
-#define CPU_RESOLVING_TYPE TYPE_HPPA_CPU
-
 #endif /* HPPA_CPU_H */
-- 
2.47.1

Re: [PATCH] target/hppa: Remove duplicated CPU_RESOLVING_TYPE definition

Posted by Richard Henderson 6 days, 10 hours ago

On 3/21/25 11:42, Philippe Mathieu-Daudé wrote:
> The CPU_RESOLVING_TYPE definition was added in commit
> 0dacec874fa ("cpu: add CPU_RESOLVING_TYPE macro"), but
> then added again in commit d3ae32d4d20. Remove the
> duplication.
> 
> Fixes: d3ae32d4d20 ("target/hppa: Implement cpu_list")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/hppa/cpu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
> index 7be4a1d3800..8b36642b591 100644
> --- a/target/hppa/cpu.h
> +++ b/target/hppa/cpu.h
> @@ -391,6 +391,4 @@ void hppa_cpu_alarm_timer(void *);
>   #endif
>   G_NORETURN void hppa_dynamic_excp(CPUHPPAState *env, int excp, uintptr_t ra);
>   
> -#define CPU_RESOLVING_TYPE TYPE_HPPA_CPU
> -
>   #endif /* HPPA_CPU_H */

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~