[v2] single-binary: start make hw/arm/ common

[PATCH v2 28/30] hw/arm/xlnx-zynqmp: prepare compilation unit to be common

Posted by Pierrick Bouvier 1 week, 5 days ago

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 hw/arm/xlnx-zynqmp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index d6022ff2d3d..ec2b3a41eda 100644
--- a/hw/arm/xlnx-zynqmp.c
+++ b/hw/arm/xlnx-zynqmp.c
@@ -22,9 +22,7 @@
 #include "hw/intc/arm_gic_common.h"
 #include "hw/misc/unimp.h"
 #include "hw/boards.h"
-#include "system/kvm.h"
 #include "system/system.h"
-#include "kvm_arm.h"
 #include "target/arm/cpu-qom.h"
 #include "target/arm/gtimer.h"
 
-- 
2.39.5

Re: [PATCH v2 28/30] hw/arm/xlnx-zynqmp: prepare compilation unit to be common

Posted by Richard Henderson 1 week, 2 days ago

On 3/20/25 15:30, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   hw/arm/xlnx-zynqmp.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
> index d6022ff2d3d..ec2b3a41eda 100644
> --- a/hw/arm/xlnx-zynqmp.c
> +++ b/hw/arm/xlnx-zynqmp.c
> @@ -22,9 +22,7 @@
>   #include "hw/intc/arm_gic_common.h"
>   #include "hw/misc/unimp.h"
>   #include "hw/boards.h"
> -#include "system/kvm.h"
>   #include "system/system.h"
> -#include "kvm_arm.h"
>   #include "target/arm/cpu-qom.h"
>   #include "target/arm/gtimer.h"
>   

Is a better description that these headers are unused?

Anyway,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

Re: [PATCH v2 28/30] hw/arm/xlnx-zynqmp: prepare compilation unit to be common

Posted by Pierrick Bouvier 1 week, 1 day ago

On 3/23/25 12:50, Richard Henderson wrote:
> On 3/20/25 15:30, Pierrick Bouvier wrote:
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> ---
>>    hw/arm/xlnx-zynqmp.c | 2 --
>>    1 file changed, 2 deletions(-)
>>
>> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
>> index d6022ff2d3d..ec2b3a41eda 100644
>> --- a/hw/arm/xlnx-zynqmp.c
>> +++ b/hw/arm/xlnx-zynqmp.c
>> @@ -22,9 +22,7 @@
>>    #include "hw/intc/arm_gic_common.h"
>>    #include "hw/misc/unimp.h"
>>    #include "hw/boards.h"
>> -#include "system/kvm.h"
>>    #include "system/system.h"
>> -#include "kvm_arm.h"
>>    #include "target/arm/cpu-qom.h"
>>    #include "target/arm/gtimer.h"
>>    
> 
> Is a better description that these headers are unused?
> 
> Anyway,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>

Yes, I'll add this to commit message.

> 
> r~