[v2] single-binary: start make hw/arm/ common

[PATCH v2 27/30] hw/arm/digic_boards: prepare compilation unit to be common

Posted by Pierrick Bouvier 1 week, 5 days ago

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 hw/arm/digic_boards.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c
index 2492fafeb85..466b8b84c0e 100644
--- a/hw/arm/digic_boards.c
+++ b/hw/arm/digic_boards.c
@@ -80,7 +80,7 @@ static void digic4_board_init(MachineState *machine, DigicBoard *board)
 static void digic_load_rom(DigicState *s, hwaddr addr,
                            hwaddr max_size, const char *filename)
 {
-    target_long rom_size;
+    ssize_t rom_size;
 
     if (qtest_enabled()) {
         /* qtest runs no code so don't attempt a ROM load which
-- 
2.39.5

Re: [PATCH v2 27/30] hw/arm/digic_boards: prepare compilation unit to be common

Posted by Richard Henderson 1 week, 2 days ago

On 3/20/25 15:29, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   hw/arm/digic_boards.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c
> index 2492fafeb85..466b8b84c0e 100644
> --- a/hw/arm/digic_boards.c
> +++ b/hw/arm/digic_boards.c
> @@ -80,7 +80,7 @@ static void digic4_board_init(MachineState *machine, DigicBoard *board)
>   static void digic_load_rom(DigicState *s, hwaddr addr,
>                              hwaddr max_size, const char *filename)
>   {
> -    target_long rom_size;
> +    ssize_t rom_size;
>   
>       if (qtest_enabled()) {
>           /* qtest runs no code so don't attempt a ROM load which

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~