[v2] accel/tcg, codebase: Build once patches

[PATCH v2 31/42] system: Move most files to libsystem_ss

Posted by Richard Henderson 2 weeks, 1 day ago

Some of the headers used require CONFIG_USER_ONLY.
Do not move vl.c, because it has other include dependencies
that are present in system_ss.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 system/meson.build | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/system/meson.build b/system/meson.build
index 063301c3ad..c2f0082766 100644
--- a/system/meson.build
+++ b/system/meson.build
@@ -4,6 +4,10 @@ specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_true: [files(
 )])
 
 system_ss.add(files(
+  'vl.c',
+), sdl, libpmem, libdaxctl)
+
+libsystem_ss.add(files(
   'balloon.c',
   'bootdevice.c',
   'cpus.c',
@@ -23,9 +27,8 @@ system_ss.add(files(
   'runstate-hmp-cmds.c',
   'runstate.c',
   'tpm-hmp-cmds.c',
-  'vl.c',
   'watchpoint.c',
-), sdl, libpmem, libdaxctl)
+))
 
 if have_tpm
   system_ss.add(files('tpm.c'))
-- 
2.43.0

Re: [PATCH v2 31/42] system: Move most files to libsystem_ss

Posted by Philippe Mathieu-Daudé 2 weeks, 1 day ago

On 18/3/25 22:31, Richard Henderson wrote:
> Some of the headers used require CONFIG_USER_ONLY.
> Do not move vl.c, because it has other include dependencies
> that are present in system_ss.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   system/meson.build | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH v2 31/42] system: Move most files to libsystem_ss

Posted by Pierrick Bouvier 2 weeks, 1 day ago

On 3/18/25 14:31, Richard Henderson wrote:
> Some of the headers used require CONFIG_USER_ONLY.
> Do not move vl.c, because it has other include dependencies
> that are present in system_ss.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   system/meson.build | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/system/meson.build b/system/meson.build
> index 063301c3ad..c2f0082766 100644
> --- a/system/meson.build
> +++ b/system/meson.build
> @@ -4,6 +4,10 @@ specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_true: [files(
>   )])
>   
>   system_ss.add(files(
> +  'vl.c',
> +), sdl, libpmem, libdaxctl)
> +
> +libsystem_ss.add(files(
>     'balloon.c',
>     'bootdevice.c',
>     'cpus.c',
> @@ -23,9 +27,8 @@ system_ss.add(files(
>     'runstate-hmp-cmds.c',
>     'runstate.c',
>     'tpm-hmp-cmds.c',
> -  'vl.c',
>     'watchpoint.c',
> -), sdl, libpmem, libdaxctl)
> +))
>   
>   if have_tpm
>     system_ss.add(files('tpm.c'))

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>