[v1] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine'

[PATCH] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine'

Posted by Niek Linnenbank 10 months, 4 weeks ago

The test class in this file contains all functional test cases
for testing the Orange Pi PC board. It should be given a name
matching the Qemu machine it covers.

This commit sets the test class name to 'OrangePiMachine'.

Signed-off-by: Niek Linnenbank <nieklinnenbank@gmail.com>
---
 tests/functional/test_arm_orangepi.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/functional/test_arm_orangepi.py b/tests/functional/test_arm_orangepi.py
index 18ee50216b..28919391e5 100755
--- a/tests/functional/test_arm_orangepi.py
+++ b/tests/functional/test_arm_orangepi.py
@@ -14,7 +14,7 @@
 from qemu_test.utils import image_pow2ceil_expand
 
 
-class BananaPiMachine(LinuxKernelTest):
+class OrangePiMachine(LinuxKernelTest):
 
     ASSET_DEB = Asset(
         ('https://apt.armbian.com/pool/main/l/linux-6.6.16/'
-- 
2.43.0

Re: [PATCH] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine'

Posted by Philippe Mathieu-Daudé 10 months, 4 weeks ago

On 16/3/25 22:02, Niek Linnenbank wrote:
> The test class in this file contains all functional test cases
> for testing the Orange Pi PC board. It should be given a name
> matching the Qemu machine it covers.
> 
> This commit sets the test class name to 'OrangePiMachine'.
> 
> Signed-off-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> ---
>   tests/functional/test_arm_orangepi.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine'

Posted by Thomas Huth 10 months, 4 weeks ago

On 16/03/2025 22.02, Niek Linnenbank wrote:
> The test class in this file contains all functional test cases
> for testing the Orange Pi PC board. It should be given a name
> matching the Qemu machine it covers.
> 
> This commit sets the test class name to 'OrangePiMachine'.
> 
> Signed-off-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> ---
>   tests/functional/test_arm_orangepi.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/functional/test_arm_orangepi.py b/tests/functional/test_arm_orangepi.py
> index 18ee50216b..28919391e5 100755
> --- a/tests/functional/test_arm_orangepi.py
> +++ b/tests/functional/test_arm_orangepi.py
> @@ -14,7 +14,7 @@
>   from qemu_test.utils import image_pow2ceil_expand
>   
>   
> -class BananaPiMachine(LinuxKernelTest):
> +class OrangePiMachine(LinuxKernelTest):

D'oh, copy-n-paste bug ...

Fixes: 380f7268b7b ("tests/functional: Convert the OrangePi tests to the 
functional framework")

Reviewed-by: Thomas Huth <thuth@redhat.com>