Add testcases for testing fadump with PSeries and PSeries+KVM
combinations
It tests if fadump is successfully detected and registered in the first
kernel boot. Then crashes the kernel, and verifies whether we have a
/proc/vmcore in the 2nd boot
Also introduce 'wait_for_regex_console_pattern' to check for cases where
there is a single success message, but can have multiple failure
messages.
This is particularly useful for cases such as fadump, where the
success message is
"Reserved 1024MB ... successfully"
But at the same point, it can fail with multiple errors such as
"Not supported" or "Allocation failed"
'wait_for_regex_console_pattern' also has a timeout, for cases when we
know the success/failure should appear in a short amount of time,
instead of waiting for the much longer test timeout, such as kernels
with support of fadump will print the success/failure in earlyboot of
the kernel, while kernel without support of fadump won't print anything
for long time, and without a timeout the testcase keeps waiting till
longer test timeout
Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
---
PowerNV also can be tested with this, will enable PowerNV tests after
MPIPL patches go in
---
---
tests/functional/meson.build | 2 +
tests/functional/qemu_test/linuxkernel.py | 59 +++++++
tests/functional/test_ppc64_fadump.py | 185 ++++++++++++++++++++++
3 files changed, 246 insertions(+)
create mode 100755 tests/functional/test_ppc64_fadump.py
diff --git a/tests/functional/meson.build b/tests/functional/meson.build
index 96d282892798..a1e8d7bf385a 100644
--- a/tests/functional/meson.build
+++ b/tests/functional/meson.build
@@ -47,6 +47,7 @@ test_timeouts = {
'ppc64_powernv' : 480,
'ppc64_pseries' : 480,
'ppc64_replay' : 210,
+ 'ppc64_fadump' : 480,
'ppc64_tuxrun' : 420,
'ppc64_mac99' : 120,
'riscv64_tuxrun' : 120,
@@ -231,6 +232,7 @@ tests_ppc64_system_thorough = [
'ppc64_replay',
'ppc64_tuxrun',
'ppc64_mac99',
+ 'ppc64_fadump',
]
tests_riscv32_system_quick = [
diff --git a/tests/functional/qemu_test/linuxkernel.py b/tests/functional/qemu_test/linuxkernel.py
index 2aca0ee3cd03..c4767527daf6 100644
--- a/tests/functional/qemu_test/linuxkernel.py
+++ b/tests/functional/qemu_test/linuxkernel.py
@@ -5,6 +5,9 @@
import hashlib
import urllib.request
+import logging
+import re
+import time
from .cmd import wait_for_console_pattern, exec_command_and_wait_for_pattern
from .testcase import QemuSystemTest
@@ -19,6 +22,62 @@ def wait_for_console_pattern(self, success_message, vm=None):
failure_message='Kernel panic - not syncing',
vm=vm)
+ def wait_for_regex_console_pattern(self, success_pattern,
+ failure_pattern=None,
+ timeout=None):
+ """
+ Similar to 'wait_for_console_pattern', but supports regex patterns,
+ hence multiple failure/success patterns can be detected at a time.
+
+ Args:
+ success_pattern (str | re.Pattern): A regex pattern that indicates
+ a successful event. If found, the method exits normally.
+ failure_pattern (str | re.Pattern, optional): A regex pattern that
+ indicates a failure event. If found, the test fails
+ timeout (int, optional): The maximum time (in seconds) to wait for
+ a match.
+ If exceeded, the test fails.
+ """
+
+ console = self.vm.console_file
+ console_logger = logging.getLogger('console')
+
+ self.log.debug(
+ f"Console interaction: success_msg='{success_pattern}' " +
+ f"failure_msg='{failure_pattern}' timeout='{timeout}s'")
+
+ # Only consume console output if waiting for something
+ if success_pattern is None and failure_pattern is None:
+ return
+
+ start_time = time.time()
+
+ while time.time() - start_time < timeout:
+ try:
+ msg = console.readline().decode().strip()
+ except UnicodeDecodeError:
+ msg = None
+ if not msg:
+ continue
+ console_logger.debug(msg)
+ if success_pattern is None or re.search(success_pattern, msg):
+ break
+ if failure_pattern:
+ # Find the matching error to print in log
+ match = re.search(failure_pattern, msg)
+ if not match:
+ continue
+
+ console.close()
+ fail = 'Failure message found in console: "%s".' \
+ ' Expected: "%s"' % \
+ (match.group(), success_pattern)
+ self.fail(fail)
+
+ if time.time() - start_time >= timeout:
+ fail = f"Timeout ({timeout}s) while trying to search pattern"
+ self.fail(fail)
+
def launch_kernel(self, kernel, initrd=None, dtb=None, console_index=0,
wait_for=None):
self.vm.set_console(console_index=console_index)
diff --git a/tests/functional/test_ppc64_fadump.py b/tests/functional/test_ppc64_fadump.py
new file mode 100755
index 000000000000..3d6d3734e243
--- /dev/null
+++ b/tests/functional/test_ppc64_fadump.py
@@ -0,0 +1,185 @@
+#!/usr/bin/env python3
+
+import logging
+import platform
+import os
+from unittest import skip, skipUnless
+from qemu_test import Asset
+from qemu_test import wait_for_console_pattern
+from qemu_test import LinuxKernelTest
+from qemu_test import exec_command, exec_command_and_wait_for_pattern
+
+class QEMUFadump(LinuxKernelTest):
+ """
+ Functional test to verify Fadump is working in following scenarios:
+
+ 1. test_fadump_pseries: PSeries
+ 2. test_fadump_pseries_kvm: PSeries + KVM
+ """
+
+ timeout = 90
+ KERNEL_COMMON_COMMAND_LINE = 'console=hvc0 fadump=on '
+ msg_panic = 'Kernel panic - not syncing'
+ msg_not_supported = 'Firmware-Assisted Dump is not supported on this hardware'
+ msg_registered_success = ''
+ msg_registered_failed = ''
+ msg_dump_active = ''
+
+ ASSET_EPAPR_KERNEL = Asset(
+ ('https://github.com/open-power/op-build/releases/download/v2.7/'
+ 'zImage.epapr'),
+ '0ab237df661727e5392cee97460e8674057a883c5f74381a128fa772588d45cd')
+
+ ASSET_VMLINUZ_KERNEL = Asset(
+ ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
+ 'releases/39/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
+ ('81e5541d243b50c8f9568906c6918dda22239744d637bb9a7b22d23c3d661226'
+ '8d5302beb2ca5c06f93bdbc9736c414ef5120756c8bf496ff488ad07d116d67f')
+ )
+
+ ASSET_FEDORA_INITRD = Asset(
+ ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
+ 'releases/39/Everything/ppc64le/os/ppc/ppc64/initrd.img'),
+ 'e7f24b44cb2aaa67d30e551db6ac8d29cc57c934b158dabca6b7f885f2cfdd9b')
+
+ def do_test_fadump(self, is_kvm=False, is_powernv=False):
+ """
+ Helper Function for Fadump tests below
+
+ It boots the VM with fadump enabled, checks if fadump is correctly
+ registered.
+ Then crashes the system causing a QEMU_SYSTEM_RESET, after which
+ dump should be available in the kernel.
+ Finally it checks the filesize of the exported /proc/vmcore in 2nd
+ kernel to verify it's same as the VM's memory size
+ """
+ if not is_kvm:
+ self.require_accelerator("tcg")
+
+ if is_powernv:
+ self.set_machine("powernv10")
+ else:
+ # SLOF takes upto >20s in startup time, use VOF
+ self.set_machine("pseries")
+ self.vm.add_args("-machine", "x-vof=on")
+ self.vm.add_args("-m", "6G")
+
+ self.vm.set_console()
+
+ kernel_path = None
+
+ if is_powernv:
+ kernel_path = self.ASSET_EPAPR_KERNEL.fetch()
+ else:
+ kernel_path = self.ASSET_VMLINUZ_KERNEL.fetch()
+
+ initrd_path = self.ASSET_FEDORA_INITRD.fetch()
+
+ self.vm.add_args('-kernel', kernel_path)
+ self.vm.add_args('-initrd', initrd_path)
+ self.vm.add_args('-append', "fadump=on"\
+ " -nodefaults -serial mon:stdio crashkernel=2G"\
+ " rdinit=/bin/sh ")
+
+ self.vm.launch()
+
+ # If kernel detects fadump support, and "fadump=on" is in command
+ # line which we add above, it will print something like:
+ #
+ # fadump: Reserved 1024MB of memory at 0x00000040000000 ...
+ #
+ # Else, if the kernel doesn't detect fadump support, it prints:
+ #
+ # fadump: Firmware-Assisted Dump is not supported on this hardware
+ #
+ # Timeout after 10s if kernel doesn't print any fadump logs, this
+ # can happen due to fadump being disabled in the kernel
+ self.wait_for_regex_console_pattern(
+ success_pattern="fadump: Reserved ",
+ failure_pattern=r"fadump: (Firmware-Assisted Dump is not"\
+ " supported on this hardware|Failed to find memory chunk for"\
+ " reservation!)",
+ timeout=10
+ )
+
+ # Ensure fadump is registered successfully, if registration
+ # succeeds, we get a log from rtas fadump:
+ #
+ # rtas fadump: Registration is successful!
+ self.wait_for_console_pattern(
+ "rtas fadump: Registration is successful!"
+ )
+
+ # Wait for the shell
+ self.wait_for_console_pattern("#")
+
+ # Mount /proc since not available in the initrd used
+ exec_command(self, command="mount -t proc proc /proc")
+
+ # Crash the kernel
+ exec_command(self, command="echo c > /proc/sysrq-trigger")
+
+ # Check for the kernel panic message, setting timeout to 10s as it
+ # should occur almost immediately after previous echo c
+ self.wait_for_regex_console_pattern(
+ success_pattern="Kernel panic - not syncing: sysrq" \
+ " triggered crash",
+ timeout=10
+ )
+
+ # Check if fadump is active
+ # If the kernel shows that fadump is active, that implies it's a
+ # crashkernel boot
+ # Else if the kernel shows "fadump: Reserved ..." then it's
+ # treating this as the first kernel boot, this is likely the case
+ # that qemu didn't pass the 'ibm,kernel-dump' device tree node
+ wait_for_console_pattern(
+ test=self,
+ success_message="rtas fadump: Firmware-assisted dump is active",
+ failure_message="fadump: Reserved "
+ )
+
+ # In a successful fadump boot, we get these logs:
+ #
+ # [ 0.000000] fadump: Firmware-assisted dump is active.
+ # [ 0.000000] fadump: Reserving <>MB of memory at <> for preserving crash data
+ #
+ # Check if these logs are present in the fadump boot
+ self.wait_for_console_pattern("preserving crash data")
+
+ # Wait for prompt
+ self.wait_for_console_pattern("sh-5.2#")
+
+ # Mount /proc since not available in the initrd used
+ exec_command_and_wait_for_pattern(self,
+ command="mount -t proc proc /proc",
+ success_message="#"
+ )
+
+ # Check if vmcore exists
+ exec_command_and_wait_for_pattern(self,
+ command="stat /proc/vmcore",
+ success_message="File: /proc/vmcore",
+ failure_message="No such file or directory"
+ )
+
+ def test_fadump_pseries(self):
+ return self.do_test_fadump(is_kvm=False, is_powernv=False)
+
+ @skip("PowerNV Fadump not supported yet")
+ def test_fadump_powernv(self):
+ return
+
+ @skipUnless(platform.machine().startswith("ppc64"),
+ "KVM tests require the same host and guest architecture")
+ def test_fadump_pseries_kvm(self):
+ """
+ Test Fadump in PSeries with KVM accel
+ """
+ self.do_test_fadump(is_kvm=True, is_powernv=False)
+
+if __name__ == '__main__':
+ if os.getenv("DEBUG"):
+ logging.basicConfig(level=logging.DEBUG)
+
+ QEMUFadump.main()
--
2.48.1 Hi!
On 15/03/2025 07.46, Aditya Gupta wrote:
> Add testcases for testing fadump with PSeries and PSeries+KVM
> combinations
...
> diff --git a/tests/functional/test_ppc64_fadump.py b/tests/functional/test_ppc64_fadump.py
> new file mode 100755
> index 000000000000..3d6d3734e243
> --- /dev/null
> +++ b/tests/functional/test_ppc64_fadump.py
> @@ -0,0 +1,185 @@
> +#!/usr/bin/env python3
scripts/checkpatch.pl recently got a check for SPDX license tags, so please
add a SPDX-License-Identifier here now to avoid a warning when the script is
run with your patch.
> +import logging
> +import platform
> +import os
> +from unittest import skip, skipUnless
> +from qemu_test import Asset
> +from qemu_test import wait_for_console_pattern
> +from qemu_test import LinuxKernelTest
> +from qemu_test import exec_command, exec_command_and_wait_for_pattern
> +
> +class QEMUFadump(LinuxKernelTest):
> + """
> + Functional test to verify Fadump is working in following scenarios:
> +
> + 1. test_fadump_pseries: PSeries
> + 2. test_fadump_pseries_kvm: PSeries + KVM
> + """
> +
> + timeout = 90
> + KERNEL_COMMON_COMMAND_LINE = 'console=hvc0 fadump=on '
> + msg_panic = 'Kernel panic - not syncing'
> + msg_not_supported = 'Firmware-Assisted Dump is not supported on this hardware'
> + msg_registered_success = ''
> + msg_registered_failed = ''
> + msg_dump_active = ''
> +
> + ASSET_EPAPR_KERNEL = Asset(
> + ('https://github.com/open-power/op-build/releases/download/v2.7/'
> + 'zImage.epapr'),
> + '0ab237df661727e5392cee97460e8674057a883c5f74381a128fa772588d45cd')
> +
> + ASSET_VMLINUZ_KERNEL = Asset(
> + ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
> + 'releases/39/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
> + ('81e5541d243b50c8f9568906c6918dda22239744d637bb9a7b22d23c3d661226'
> + '8d5302beb2ca5c06f93bdbc9736c414ef5120756c8bf496ff488ad07d116d67f')
> + )
> +
> + ASSET_FEDORA_INITRD = Asset(
> + ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
> + 'releases/39/Everything/ppc64le/os/ppc/ppc64/initrd.img'),
> + 'e7f24b44cb2aaa67d30e551db6ac8d29cc57c934b158dabca6b7f885f2cfdd9b')
> +
> + def do_test_fadump(self, is_kvm=False, is_powernv=False):
> + """
> + Helper Function for Fadump tests below
> +
> + It boots the VM with fadump enabled, checks if fadump is correctly
> + registered.
> + Then crashes the system causing a QEMU_SYSTEM_RESET, after which
> + dump should be available in the kernel.
> + Finally it checks the filesize of the exported /proc/vmcore in 2nd
> + kernel to verify it's same as the VM's memory size
> + """
> + if not is_kvm:
> + self.require_accelerator("tcg")
> +
> + if is_powernv:
> + self.set_machine("powernv10")
> + else:
> + # SLOF takes upto >20s in startup time, use VOF
> + self.set_machine("pseries")
> + self.vm.add_args("-machine", "x-vof=on")
> + self.vm.add_args("-m", "6G")
> +
> + self.vm.set_console()
> +
> + kernel_path = None
> +
> + if is_powernv:
> + kernel_path = self.ASSET_EPAPR_KERNEL.fetch()
> + else:
> + kernel_path = self.ASSET_VMLINUZ_KERNEL.fetch()
> +
> + initrd_path = self.ASSET_FEDORA_INITRD.fetch()
> +
> + self.vm.add_args('-kernel', kernel_path)
> + self.vm.add_args('-initrd', initrd_path)
> + self.vm.add_args('-append', "fadump=on"\
> + " -nodefaults -serial mon:stdio crashkernel=2G"\
> + " rdinit=/bin/sh ")
> +
> + self.vm.launch()
> +
> + # If kernel detects fadump support, and "fadump=on" is in command
> + # line which we add above, it will print something like:
> + #
> + # fadump: Reserved 1024MB of memory at 0x00000040000000 ...
> + #
> + # Else, if the kernel doesn't detect fadump support, it prints:
> + #
> + # fadump: Firmware-Assisted Dump is not supported on this hardware
> + #
> + # Timeout after 10s if kernel doesn't print any fadump logs, this
> + # can happen due to fadump being disabled in the kernel
> + self.wait_for_regex_console_pattern(
> + success_pattern="fadump: Reserved ",
> + failure_pattern=r"fadump: (Firmware-Assisted Dump is not"\
> + " supported on this hardware|Failed to find memory chunk for"\
> + " reservation!)",
> + timeout=10
> + )
> +
> + # Ensure fadump is registered successfully, if registration
> + # succeeds, we get a log from rtas fadump:
> + #
> + # rtas fadump: Registration is successful!
> + self.wait_for_console_pattern(
> + "rtas fadump: Registration is successful!"
> + )
> +
> + # Wait for the shell
> + self.wait_for_console_pattern("#")
> +
> + # Mount /proc since not available in the initrd used
> + exec_command(self, command="mount -t proc proc /proc")
> +
> + # Crash the kernel
> + exec_command(self, command="echo c > /proc/sysrq-trigger")
> +
> + # Check for the kernel panic message, setting timeout to 10s as it
> + # should occur almost immediately after previous echo c
> + self.wait_for_regex_console_pattern(
> + success_pattern="Kernel panic - not syncing: sysrq" \
> + " triggered crash",
> + timeout=10
> + )
> +
> + # Check if fadump is active
> + # If the kernel shows that fadump is active, that implies it's a
> + # crashkernel boot
> + # Else if the kernel shows "fadump: Reserved ..." then it's
> + # treating this as the first kernel boot, this is likely the case
> + # that qemu didn't pass the 'ibm,kernel-dump' device tree node
> + wait_for_console_pattern(
> + test=self,
> + success_message="rtas fadump: Firmware-assisted dump is active",
> + failure_message="fadump: Reserved "
> + )
> +
> + # In a successful fadump boot, we get these logs:
> + #
> + # [ 0.000000] fadump: Firmware-assisted dump is active.
> + # [ 0.000000] fadump: Reserving <>MB of memory at <> for preserving crash data
> + #
> + # Check if these logs are present in the fadump boot
> + self.wait_for_console_pattern("preserving crash data")
> +
> + # Wait for prompt
> + self.wait_for_console_pattern("sh-5.2#")
> +
> + # Mount /proc since not available in the initrd used
> + exec_command_and_wait_for_pattern(self,
> + command="mount -t proc proc /proc",
> + success_message="#"
> + )
> +
> + # Check if vmcore exists
> + exec_command_and_wait_for_pattern(self,
> + command="stat /proc/vmcore",
> + success_message="File: /proc/vmcore",
> + failure_message="No such file or directory"
> + )
> +
> + def test_fadump_pseries(self):
> + return self.do_test_fadump(is_kvm=False, is_powernv=False)
> +
> + @skip("PowerNV Fadump not supported yet")
> + def test_fadump_powernv(self):
> + return
> +
> + @skipUnless(platform.machine().startswith("ppc64"),
> + "KVM tests require the same host and guest architecture")
I think this is likely unreliable: The test could run on a ppc64 host, but
KVM could still be unavailable, e.g. if it has been disabled in the kernel.
It's better to use self.require_accelerator("kvm") instead (which will also
skip the test if it is not available).
Also, shouldn't there be a "-accel kvm" somewhere if you really want to be
sure to enable KVM ?
> + def test_fadump_pseries_kvm(self):
> + """
> + Test Fadump in PSeries with KVM accel
> + """
> + self.do_test_fadump(is_kvm=True, is_powernv=False)
> +
> +if __name__ == '__main__':
> + if os.getenv("DEBUG"):
> + logging.basicConfig(level=logging.DEBUG)
The setUp function in QemuSystemTest already sets the log level to DEBUG, so
this should not be necessary?
Thomas
Hi Thomas,
On 17/03/25 11:55, Thomas Huth wrote:
> Hi!
>
> On 15/03/2025 07.46, Aditya Gupta wrote:
>> Add testcases for testing fadump with PSeries and PSeries+KVM
>> combinations
> ...
>> diff --git a/tests/functional/test_ppc64_fadump.py
>> b/tests/functional/test_ppc64_fadump.py
>> new file mode 100755
>> index 000000000000..3d6d3734e243
>> --- /dev/null
>> +++ b/tests/functional/test_ppc64_fadump.py
>> @@ -0,0 +1,185 @@
>> +#!/usr/bin/env python3
>
> scripts/checkpatch.pl recently got a check for SPDX license tags, so
> please add a SPDX-License-Identifier here now to avoid a warning when
> the script is run with your patch.
>
Sure, don't know how I missed it. Will fix it.
>> <...snip...>
>>
>> + @skipUnless(platform.machine().startswith("ppc64"),
>> + "KVM tests require the same host and guest
>> architecture")
>
> I think this is likely unreliable: The test could run on a ppc64 host,
> but KVM could still be unavailable, e.g. if it has been disabled in
> the kernel. It's better to use self.require_accelerator("kvm") instead
> (which will also skip the test if it is not available).
>
Thanks, agreed, will remove it, and add self.require_accelerator("kvm").
>
> Also, shouldn't there be a "-accel kvm" somewhere if you really want
> to be sure to enable KVM ?
>
Will add it, this whole time I thought it's using kvm, guess the tests
were running in tcg mode only.
>> + def test_fadump_pseries_kvm(self):
>> + """
>> + Test Fadump in PSeries with KVM accel
>> + """
>> + self.do_test_fadump(is_kvm=True, is_powernv=False)
>> +
>> +if __name__ == '__main__':
>> + if os.getenv("DEBUG"):
>> + logging.basicConfig(level=logging.DEBUG)
>
> The setUp function in QemuSystemTest already sets the log level to
> DEBUG, so this should not be necessary?
>
I did that to see the QEMU VM booting logs. I see in QemuSystemTest, it
sets the log level of some loggers to DEBUG, don't know if it's the
same, as I didn't see the boot logs during testing (also, in
QemuSystemTest, we are setting specific loggers to DEBUG, while I did
.basicConfig to DEBUG which I think is like a global debug level setting)
How do I get the system booting logs in `make check` ? I didn't find it
in the docs.
Thanks,
Aditya Gupta
> Thomas
>
On 17/03/2025 07.51, Aditya Gupta wrote:
> Hi Thomas,
>
> On 17/03/25 11:55, Thomas Huth wrote:
>> Hi!
>>
>> On 15/03/2025 07.46, Aditya Gupta wrote:
>>> Add testcases for testing fadump with PSeries and PSeries+KVM
>>> combinations
>> ...
>>> diff --git a/tests/functional/test_ppc64_fadump.py b/tests/functional/
>>> test_ppc64_fadump.py
>>> new file mode 100755
>>> index 000000000000..3d6d3734e243
>>> --- /dev/null
>>> +++ b/tests/functional/test_ppc64_fadump.py
>>> @@ -0,0 +1,185 @@
>>> +#!/usr/bin/env python3
>>
>> scripts/checkpatch.pl recently got a check for SPDX license tags, so
>> please add a SPDX-License-Identifier here now to avoid a warning when the
>> script is run with your patch.
>>
> Sure, don't know how I missed it. Will fix it.
>
>
>>> <...snip...>
>>>
>>> + @skipUnless(platform.machine().startswith("ppc64"),
>>> + "KVM tests require the same host and guest architecture")
>>
>> I think this is likely unreliable: The test could run on a ppc64 host, but
>> KVM could still be unavailable, e.g. if it has been disabled in the
>> kernel. It's better to use self.require_accelerator("kvm") instead (which
>> will also skip the test if it is not available).
>>
> Thanks, agreed, will remove it, and add self.require_accelerator("kvm").
>>
>> Also, shouldn't there be a "-accel kvm" somewhere if you really want to be
>> sure to enable KVM ?
>>
> Will add it, this whole time I thought it's using kvm, guess the tests were
> running in tcg mode only.
>>> + def test_fadump_pseries_kvm(self):
>>> + """
>>> + Test Fadump in PSeries with KVM accel
>>> + """
>>> + self.do_test_fadump(is_kvm=True, is_powernv=False)
>>> +
>>> +if __name__ == '__main__':
>>> + if os.getenv("DEBUG"):
>>> + logging.basicConfig(level=logging.DEBUG)
>>
>> The setUp function in QemuSystemTest already sets the log level to DEBUG,
>> so this should not be necessary?
>>
> I did that to see the QEMU VM booting logs. I see in QemuSystemTest, it sets
> the log level of some loggers to DEBUG, don't know if it's the same, as I
> didn't see the boot logs during testing (also, in QemuSystemTest, we are
> setting specific loggers to DEBUG, while I did .basicConfig to DEBUG which I
> think is like a global debug level setting)
>
> How do I get the system booting logs in `make check` ? I didn't find it in
> the docs.
The log files should get written to
tests/functional/ppc64/test_ppc64_fadump.* - main log file is base.log, and
the console output should go into console.log. Can you spot there the
information you were looking for?
Anyway, that information is missing in the docs indeed ... I'll try to come
up with a patch when I got some spare time for it.
Thomas
On 17/03/25 12:30, Thomas Huth wrote:
> On 17/03/2025 07.51, Aditya Gupta wrote:
>> Hi Thomas,
>>
>> <...snip...>
>>>> + def test_fadump_pseries_kvm(self):
>>>> + """
>>>> + Test Fadump in PSeries with KVM accel
>>>> + """
>>>> + self.do_test_fadump(is_kvm=True, is_powernv=False)
>>>> +
>>>> +if __name__ == '__main__':
>>>> + if os.getenv("DEBUG"):
>>>> + logging.basicConfig(level=logging.DEBUG)
>>>
>>> The setUp function in QemuSystemTest already sets the log level to
>>> DEBUG, so this should not be necessary?
>>>
>> I did that to see the QEMU VM booting logs. I see in QemuSystemTest,
>> it sets the log level of some loggers to DEBUG, don't know if it's
>> the same, as I didn't see the boot logs during testing (also, in
>> QemuSystemTest, we are setting specific loggers to DEBUG, while I did
>> .basicConfig to DEBUG which I think is like a global debug level
>> setting)
>>
>> How do I get the system booting logs in `make check` ? I didn't find
>> it in the docs.
>
> The log files should get written to
> tests/functional/ppc64/test_ppc64_fadump.* - main log file is
> base.log, and the console output should go into console.log. Can you
> spot there the information you were looking for?
Yes, found them, thanks !
For me, the full path was
'<QEMU_SRC>/build/test_ppc64_fadump.QEMUFadump.test_fadump_pseries/console.log'
>
> Anyway, that information is missing in the docs indeed ... I'll try to
> come up with a patch when I got some spare time for it.
>
Thanks, also while you make change can you also add the 'build/' folder
at start of the path you mentioned. That might be good, I was searching
for the files in <QEMU_SRC>/tests/functional directory.
Thanks,
- Aditya G
> Thomas
>
© 2016 - 2025 Red Hat, Inc.