ppc/amigaone: Constify default_env

[PATCH] ppc/amigaone: Constify default_env

Posted by BALATON Zoltan 2 weeks, 4 days ago

The variable holding default env is not supposed to be written.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/ppc/amigaone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c
index 5d787c3059..e9407a51b5 100644
--- a/hw/ppc/amigaone.c
+++ b/hw/ppc/amigaone.c
@@ -63,7 +63,7 @@ static const char dummy_fw[] = {
 #define NVRAM_ADDR 0xfd0e0000
 #define NVRAM_SIZE (4 * KiB)
 
-static char default_env[] =
+static const char default_env[] =
     "baudrate=115200\0"
     "stdout=vga\0"
     "stdin=ps2kbd\0"
-- 
2.41.3

Re: [PATCH] ppc/amigaone: Constify default_env

Posted by Philippe Mathieu-Daudé 2 weeks, 2 days ago

On 14/3/25 21:01, BALATON Zoltan wrote:
> The variable holding default env is not supposed to be written.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/ppc/amigaone.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] ppc/amigaone: Constify default_env

Posted by Nicholas Piggin 2 weeks, 2 days ago

On Sat Mar 15, 2025 at 6:01 AM AEST, BALATON Zoltan wrote:
> The variable holding default env is not supposed to be written.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

> ---
>  hw/ppc/amigaone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c
> index 5d787c3059..e9407a51b5 100644
> --- a/hw/ppc/amigaone.c
> +++ b/hw/ppc/amigaone.c
> @@ -63,7 +63,7 @@ static const char dummy_fw[] = {
>  #define NVRAM_ADDR 0xfd0e0000
>  #define NVRAM_SIZE (4 * KiB)
>  
> -static char default_env[] =
> +static const char default_env[] =
>      "baudrate=115200\0"
>      "stdout=vga\0"
>      "stdin=ps2kbd\0"