Hi,
one patch is missing review:
[PATCH v5 12/17] hw/xen: add stubs for various functions.
Regards,
Pierrick
On 3/14/25 10:31, Pierrick Bouvier wrote:
> The main goal of this series is to be able to call any memory ld/st function
> from code that is *not* target dependent. As a positive side effect, we can
> turn related system compilation units into common code.
>
> The first 5 patches remove dependency of memory API to cpu headers and remove
> dependency to target specific code. This could be a series on its own, but it's
> great to be able to turn system memory compilation units into common code to
> make sure it can't regress, and prove it achieves the desired result.
>
> The next patches remove more dependencies on cpu headers (exec-all,
> memory-internal, ram_addr).
> Then, we add access to a needed function from kvm, some xen stubs, and we
> finally can turn our compilation units into common code.
>
> Every commit was tested to build correctly for all targets (on windows, linux,
> macos), and the series was fully tested by running all tests we have (linux,
> x86_64 host).
>
> v2:
> - reorder first commits (tswap change first, so memory cached functions can use it)
> - move st/ld*_p functions to tswap instead of bswap
> - add define for target_words_bigendian when COMPILING_PER_TARGET, equals to
> TARGET_BIG_ENDIAN (avoid overhead in target code)
> - rewrite devend_memop
> - remove useless exec-all.h in concerned patch
> - extract devend_big_endian function to reuse in system/memory.c
> - rewrite changes to system/memory.c
>
> v3:
> - move devend functions to memory_internal.h
> - completed description for commits removing cpu.h dependency
>
> v4:
> - rebase on top of master
> * missing include in 'codebase: prepare to remove cpu.h from exec/exec-all.h'
> * meson build conflict
>
> v5:
> - remove extra xen stub xen_invalidate_map_cache()
> - edit xen stubs commit message
>
> Pierrick Bouvier (17):
> exec/tswap: target code can use TARGET_BIG_ENDIAN instead of
> target_words_bigendian()
> exec/tswap: implement {ld,st}.*_p as functions instead of macros
> exec/memory_ldst: extract memory_ldst declarations from cpu-all.h
> exec/memory_ldst_phys: extract memory_ldst_phys declarations from
> cpu-all.h
> exec/memory.h: make devend_memop "target defines" agnostic
> codebase: prepare to remove cpu.h from exec/exec-all.h
> exec/exec-all: remove dependency on cpu.h
> exec/memory-internal: remove dependency on cpu.h
> exec/ram_addr: remove dependency on cpu.h
> system/kvm: make kvm_flush_coalesced_mmio_buffer() accessible for
> common code
> exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled
> hw/xen: add stubs for various functions
> system/physmem: compilation unit is now common to all targets
> include/exec/memory: extract devend_big_endian from devend_memop
> include/exec/memory: move devend functions to memory-internal.h
> system/memory: make compilation unit common
> system/ioport: make compilation unit common
>
> include/exec/cpu-all.h | 66 -----------------------
> include/exec/exec-all.h | 1 -
> include/exec/memory-internal.h | 21 +++++++-
> include/exec/memory.h | 30 ++++-------
> include/exec/ram_addr.h | 11 ++--
> include/exec/tswap.h | 81 +++++++++++++++++++++++++++--
> include/system/kvm.h | 6 +--
> include/tcg/tcg-op.h | 1 +
> target/ppc/helper_regs.h | 2 +
> include/exec/memory_ldst.h.inc | 4 --
> include/exec/memory_ldst_phys.h.inc | 5 +-
> cpu-target.c | 1 +
> hw/ppc/spapr_nested.c | 1 +
> hw/sh4/sh7750.c | 1 +
> hw/xen/xen_stubs.c | 51 ++++++++++++++++++
> page-vary-target.c | 2 +-
> system/ioport.c | 1 -
> system/memory.c | 17 ++----
> target/ppc/tcg-excp_helper.c | 1 +
> target/riscv/bitmanip_helper.c | 2 +-
> hw/xen/meson.build | 3 ++
> system/meson.build | 6 +--
> 22 files changed, 188 insertions(+), 126 deletions(-)
> create mode 100644 hw/xen/xen_stubs.c
>