[v1] gdb invalid memory access handling improvements

[PATCH 0/2] gdb invalid memory access handling improvements

Nicholas Piggin posted 2 patches 2 weeks, 6 days ago

Diff against v2 v3
Download series mbox

There is a newer version of this series

docs/devel/loads-stores.rst | 11 +++++++++++
include/exec/cpu-common.h   |  3 +++
gdbstub/system.c            |  7 +------
system/memory.c             | 37 ++++++++++++++++++++++---------------
system/physmem.c            | 16 ++++++++++++++++
5 files changed, 53 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH 0/2] gdb invalid memory access handling improvements

Posted by Nicholas Piggin 2 weeks, 6 days ago

This adds .debug=1 attribute for GDB's phys mem access mode, adds
memory transaction error handling for it so it reports cannot access
memory instead of silent success, and silences warning logs for
invalid memory access coming from the debugger.

Thanks,
Nick

Nicholas Piggin (2):
  gdbstub: Add phys_memory_rw_debug for physical memory access
  memory: suppress INVALID_MEM logs caused by debug access

 docs/devel/loads-stores.rst | 11 +++++++++++
 include/exec/cpu-common.h   |  3 +++
 gdbstub/system.c            |  7 +------
 system/memory.c             | 37 ++++++++++++++++++++++---------------
 system/physmem.c            | 16 ++++++++++++++++
 5 files changed, 53 insertions(+), 21 deletions(-)

-- 
2.47.1

Re: [PATCH 0/2] gdb invalid memory access handling improvements

Posted by David Hildenbrand 2 weeks, 5 days ago

On 14.03.25 08:41, Nicholas Piggin wrote:
> This adds .debug=1 attribute for GDB's phys mem access mode, adds
> memory transaction error handling for it so it reports cannot access
> memory instead of silent success, and silences warning logs for
> invalid memory access coming from the debugger.

Nothing jumped at me, with Richard's suggestion of keeping the new 
function limited in scope

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb