hw/uefi: flush variable store to disk in post load

[PATCH] hw/uefi: flush variable store to disk in post load

Gerd Hoffmann posted 1 patch 8 months, 1 week ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250313104119.2084313-1-kraxel@redhat.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>

hw/uefi/var-service-core.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] hw/uefi: flush variable store to disk in post load

Posted by Gerd Hoffmann 8 months, 1 week ago

Makes live migration more robust.  Commit 4c0cfc72b31a ("pflash_cfi01:
write flash contents to bdrv on incoming migration") elaborates in
detail on the motivation.

Cc: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/uefi/var-service-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/uefi/var-service-core.c b/hw/uefi/var-service-core.c
index 8ed8378ab991..4836a0cb8116 100644
--- a/hw/uefi/var-service-core.c
+++ b/hw/uefi/var-service-core.c
@@ -29,6 +29,7 @@ static int uefi_vars_post_load(void *opaque, int version_id)
     uefi_vars_state *uv = opaque;
 
     uefi_vars_update_storage(uv);
+    uefi_vars_json_save(uv);
     uv->buffer = g_malloc(uv->buf_size);
     return 0;
 }
-- 
2.48.1

Re: [PATCH] hw/uefi: flush variable store to disk in post load

Posted by Peter Krempa 8 months, 1 week ago

On Thu, Mar 13, 2025 at 11:41:19 +0100, Gerd Hoffmann wrote:
> Makes live migration more robust.  Commit 4c0cfc72b31a ("pflash_cfi01:
> write flash contents to bdrv on incoming migration") elaborates in
> detail on the motivation.
> 
> Cc: Peter Krempa <pkrempa@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---

Thanks!

>  hw/uefi/var-service-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/uefi/var-service-core.c b/hw/uefi/var-service-core.c
> index 8ed8378ab991..4836a0cb8116 100644
> --- a/hw/uefi/var-service-core.c
> +++ b/hw/uefi/var-service-core.c
> @@ -29,6 +29,7 @@ static int uefi_vars_post_load(void *opaque, int version_id)
>      uefi_vars_state *uv = opaque;
>  
>      uefi_vars_update_storage(uv);
> +    uefi_vars_json_save(uv);
>      uv->buffer = g_malloc(uv->buf_size);
>      return 0;
>  }
> -- 
> 2.48.1
> 

Reviewed-by: Peter Krempa <pkrempa@redhat.com>