error: Strip trailing '\n' from an error string argument

[PATCH] error: Strip trailing '\n' from an error string argument

Posted by Markus Armbruster 11 months ago

Tracked down with scripts/coccinelle/err-bad-newline.cocci.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 net/vmnet-common.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/vmnet-common.m b/net/vmnet-common.m
index 54d900ba67..ab33ce2b0c 100644
--- a/net/vmnet-common.m
+++ b/net/vmnet-common.m
@@ -94,7 +94,7 @@ ssize_t vmnet_receive_common(NetClientState *nc,
 
     if_status = vmnet_write(s->vmnet_if, &packet, &pkt_cnt);
     if (if_status != VMNET_SUCCESS) {
-        error_report("vmnet: write error: %s\n",
+        error_report("vmnet: write error: %s",
                      vmnet_status_map_str(if_status));
         return -1;
     }
-- 
2.48.1

Re: [PATCH] error: Strip trailing '\n' from an error string argument

Posted by Markus Armbruster 10 months, 3 weeks ago

Queued for 10.0.

Re: [PATCH] error: Strip trailing '\n' from an error string argument

Posted by gaosong 11 months ago

在 2025/3/12 下午10:35, Markus Armbruster 写道:
> Tracked down with scripts/coccinelle/err-bad-newline.cocci.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   net/vmnet-common.m | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Song Gao <gaosong@loongson.cn>

Thanks.
Song Gao
> diff --git a/net/vmnet-common.m b/net/vmnet-common.m
> index 54d900ba67..ab33ce2b0c 100644
> --- a/net/vmnet-common.m
> +++ b/net/vmnet-common.m
> @@ -94,7 +94,7 @@ ssize_t vmnet_receive_common(NetClientState *nc,
>   
>       if_status = vmnet_write(s->vmnet_if, &packet, &pkt_cnt);
>       if (if_status != VMNET_SUCCESS) {
> -        error_report("vmnet: write error: %s\n",
> +        error_report("vmnet: write error: %s",
>                        vmnet_status_map_str(if_status));
>           return -1;
>       }

Re: [PATCH] error: Strip trailing '\n' from an error string argument

Posted by Philippe Mathieu-Daudé 11 months ago

On 12/3/25 15:35, Markus Armbruster wrote:
> Tracked down with scripts/coccinelle/err-bad-newline.cocci.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   net/vmnet-common.m | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] error: Strip trailing '\n' from an error string argument

Posted by Peter Maydell 11 months ago

On Wed, 12 Mar 2025 at 14:35, Markus Armbruster <armbru@redhat.com> wrote:
>
> Tracked down with scripts/coccinelle/err-bad-newline.cocci.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  net/vmnet-common.m | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/vmnet-common.m b/net/vmnet-common.m
> index 54d900ba67..ab33ce2b0c 100644
> --- a/net/vmnet-common.m
> +++ b/net/vmnet-common.m
> @@ -94,7 +94,7 @@ ssize_t vmnet_receive_common(NetClientState *nc,
>
>      if_status = vmnet_write(s->vmnet_if, &packet, &pkt_cnt);
>      if (if_status != VMNET_SUCCESS) {
> -        error_report("vmnet: write error: %s\n",
> +        error_report("vmnet: write error: %s",
>                       vmnet_status_map_str(if_status));
>          return -1;
>      }
> --

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM